Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(config): reject NUL bytes in Hopper loader arguments (#2474)
Rudy Mizrahi Celeklia07ceaec3634
diff --git a/src/config.test.ts b/src/config.test.tsindex eb784802f..67db7e111 100644--- a/src/config.test.ts+++ b/src/config.test.ts@@ -3,6 +3,18 @@ import { describe, expect, it } from "vitest";import { parseConfig } from "./config/parseConfig.js";import { projectAnalysisError } from "./domain/analysisErrorProjection.js";+it("reports a configuration failure for a NUL in Hopper loader arguments", () => {+ const result = parseConfig({+ HOPPER_LOADER_ARGS_JSON: JSON.stringify(["--option", "value\0suffix"]),+ });+ if (result.ok)+ throw new Error("NUL argv cannot be passed to a child process");+ expect(result.error).toMatchObject({+ settings: [{ setting: "HOPPER_LOADER_ARGS_JSON" }],+ });+ expect(result.error.message).toContain("NUL");+});+describe("runtime configuration", () => {it("allows target-free startup and applies runtime defaults", () => {const empty = parseConfig({});diff --git a/src/config/parsers.ts b/src/config/parsers.tsindex fc842f884..52feae622 100644--- a/src/config/parsers.ts+++ b/src/config/parsers.ts@@ -1,6 +1,7 @@import { z } from "zod";import { ConfigurationError } from "../domain/configurationErrors.js";+import { nulFreeStringSchema } from "../domain/localPath.js";import { err, ok, type Result } from "../domain/result.js";import { safeParseJson } from "../domain/safeJson.js";@@ -20,7 +21,8 @@ export const parseLoaderArgs = (return parseConfiguredStringArray(encoded,"HOPPER_LOADER_ARGS_JSON",- z.string(),+ nulFreeStringSchema,+ "must encode an array of strings without NUL bytes",);};@@ -28,6 +30,7 @@ const parseConfiguredStringArray = (encoded: string,setting: string,itemSchema: z.ZodString,+ requirement = "must encode an array of strings",): Result<readonly string[], ConfigurationError> => {const decoded = safeParseJson(encoded);if (!decoded.ok)@@ -37,13 +40,7 @@ const parseConfiguredStringArray = (const parsed = z.array(itemSchema).safeParse(decoded.value);return parsed.success? ok(parsed.data)- : err(- configuredArrayError(- setting,- "must encode an array of strings",- parsed.error,- ),- );+ : err(configuredArrayError(setting, requirement, parsed.error));};const configuredArrayError = (