Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

refactor(evidence): remove obsolete ID resolvers

morlutoa3920e2abd91
diff --git a/src/application/EvidenceReferenceResolver.ts b/src/application/EvidenceReferenceResolver.ts
deleted file mode 100644
index 95544b2c3..000000000
--- a/src/application/EvidenceReferenceResolver.ts
+++ /dev/null
@@ -1,71 +0,0 @@
-import type { Evidence } from "../domain/evidence.js";
-import { EvidenceReferenceError } from "../domain/errors.js";
-import { err, ok, type Result } from "../domain/result.js";
-
-/** Semantic identity admitted for one authoritative Evidence reference. */
-export interface EvidenceSemanticIdentity {
- readonly operation: string;
- readonly predicate: string;
-}
-
-/** Read one Evidence record from an already-authorized authority. */
-export type EvidenceLookup = (evidenceId: string) => Evidence | undefined;
-
-/** Resolve IDs without accepting the digest-shaped identifier as proof itself. */
-export const resolveEvidenceReferences = (
- lookup: EvidenceLookup | undefined,
- evidenceIds: readonly string[],
- expected?: readonly EvidenceSemanticIdentity[],
-): Result<Evidence[], EvidenceReferenceError> => {
- const records: Evidence[] = [];
- for (const evidenceId of evidenceIds) {
- const record = lookup?.(evidenceId);
- if (record === undefined)
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "missing",
- expectationDescription(expected),
- null,
- ),
- );
- if (expected !== undefined) {
- const operations = expected.filter(
- ({ operation }) => operation === record.operation,
- );
- if (operations.length === 0)
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "wrong_operation",
- unique(expected.map(({ operation }) => operation)).join(" | "),
- record.operation,
- ),
- );
- if (
- !operations.some(({ predicate }) => predicate === record.predicate_type)
- )
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "wrong_predicate",
- unique(operations.map(({ predicate }) => predicate)).join(" | "),
- record.predicate_type,
- ),
- );
- }
- records.push(record);
- }
- return ok(records);
-};
-
-const expectationDescription = (
- expected: readonly EvidenceSemanticIdentity[] | undefined,
-): string =>
- expected === undefined
- ? "Evidence in the current authority"
- : expected
- .map(({ operation, predicate }) => `${operation}:${predicate}`)
- .join(" | ");
-
-const unique = (values: readonly string[]): string[] => [...new Set(values)];
diff --git a/src/server/sessionEvidence.ts b/src/server/sessionEvidence.ts
index 70615999d..d943787e8 100644
--- a/src/server/sessionEvidence.ts
+++ b/src/server/sessionEvidence.ts
@@ -1,61 +1,8 @@
import type { BinarySessionPort } from "../application/BinarySession.js";
-import {
- EvidenceIntegrityError,
- EvidenceReferenceError,
-} from "../domain/errors.js";
+import { EvidenceIntegrityError } from "../domain/errors.js";
import type { Evidence } from "../domain/evidence.js";
import { err, ok, type Result } from "../domain/result.js";
-type EvidenceAuthorityResult = Result<Evidence[], EvidenceIntegrityError>;
-
-/** Resolve session IDs to authoritative records with exact semantic identity. */
-export const resolveSessionEvidenceIds = (
- session: BinarySessionPort,
- evidenceIds: readonly string[],
- expected: {
- readonly operation: string | readonly string[];
- readonly predicate: string;
- },
-): EvidenceAuthorityResult => {
- const records: Evidence[] = [];
- const expectedOperations = Array.isArray(expected.operation)
- ? expected.operation
- : [expected.operation];
- const expectedOperationLabel = expectedOperations.join(" or ");
- for (const evidenceId of evidenceIds) {
- const record = session.evidenceById(evidenceId);
- if (record === undefined)
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "missing",
- expectedOperationLabel,
- null,
- ),
- );
- if (!expectedOperations.includes(record.operation))
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "wrong_operation",
- expectedOperationLabel,
- record.operation,
- ),
- );
- if (record.predicate_type !== expected.predicate)
- return err(
- new EvidenceReferenceError(
- evidenceId,
- "wrong_predicate",
- expected.predicate,
- record.predicate_type,
- ),
- );
- records.push(record);
- }
- return ok(records);
-};
-
/** Record source evidence in order, stopping at the first session rejection. */
export const recordSessionEvidenceSources = (
recordEvidence: BinarySessionPort["recordEvidence"] | undefined,