Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(errors): report union input issues at the union's path

Iwakurakaoru0822bddeb634b583
diff --git a/src/domain/inputIssueProjection.test.ts b/src/domain/inputIssueProjection.test.ts
index 127679971..0abc83431 100644
--- a/src/domain/inputIssueProjection.test.ts
+++ b/src/domain/inputIssueProjection.test.ts
@@ -26,4 +26,27 @@ describe("input issue projection", () => {
},
]);
});
+
+ it("reports union branch issues at the union's path once", () => {
+ const schema = z.object({
+ seed: z.union([
+ z.object({ value: z.string().min(1) }),
+ z.object({ value: z.literal(""), match: z.literal("exact") }),
+ ]),
+ });
+ const missing = schema.safeParse({});
+ if (missing.success) throw new Error("expected invalid input");
+ expect(projectInputIssues(missing.error.issues, {})).toEqual([
+ { path: ["seed"], reason: "missing_argument", expected: "object" },
+ ]);
+
+ const input = { seed: { value: 1 } };
+ const nested = schema.safeParse(input);
+ if (nested.success) throw new Error("expected invalid input");
+ expect(projectInputIssues(nested.error.issues, input)).toEqual(
+ expect.arrayContaining([
+ { path: ["seed", "value"], reason: "invalid_type", expected: "string" },
+ ]),
+ );
+ });
});
diff --git a/src/domain/inputIssueProjection.ts b/src/domain/inputIssueProjection.ts
index 1fff45e1c..08390df5a 100644
--- a/src/domain/inputIssueProjection.ts
+++ b/src/domain/inputIssueProjection.ts
@@ -15,9 +15,17 @@ const projectIssue = (
const path = issue.path.flatMap((part) =>
typeof part === "string" || typeof part === "number" ? [part] : [],
);
+ // Branch issue paths are relative to the union; branches often agree.
if (issue.code === "invalid_union")
- return issue.errors.flatMap((branch) =>
- branch.flatMap((branchIssue) => projectIssue(branchIssue, input)),
+ return uniqueIssues(
+ issue.errors.flatMap((branch) =>
+ branch.flatMap((branchIssue) =>
+ projectIssue(
+ { ...branchIssue, path: [...issue.path, ...branchIssue.path] },
+ input,
+ ),
+ ),
+ ),
);
if (issue.code === "unrecognized_keys")
return issue.keys.map((key) => ({
@@ -58,6 +66,12 @@ const projectIssue = (
];
};
+const uniqueIssues = (
+ issues: readonly AnalysisInputIssue[],
+): AnalysisInputIssue[] => [
+ ...new Map(issues.map((issue) => [JSON.stringify(issue), issue])).values(),
+];
+
const valueAtPath = (
input: unknown,
path: readonly (string | number)[],