Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(reference): retain partial imports for unreadable directories (#766)
Rudy Mizrahi Celeklicffc548cd312
diff --git a/src/reference/ReferenceSourceReaderEntries.ts b/src/reference/ReferenceSourceReaderEntries.tsindex a03e096a2..2b60f20c2 100644--- a/src/reference/ReferenceSourceReaderEntries.ts+++ b/src/reference/ReferenceSourceReaderEntries.ts@@ -79,6 +79,12 @@ export const traverseDirectory = async ();return { ok: true, value: undefined };}+ if (current.path !== state.root)+ state.entries.push({+ status: "read",+ kind: "directory",+ path: pathFromRoot(state.root, current.path),+ });const directories: PendingDirectory[] = [];for (const name of names.value) {const result = await processEntry(state, current, name, directories);@@ -168,7 +174,6 @@ const processEntry = async (await describeSymlink(state.root, absolute, path, state.signal),);else if (metadata.value.isDirectory()) {- state.entries.push({ status: "read", kind: "directory", path });directories.push({ path: absolute });} else if (!metadata.value.isFile())state.entries.push(diff --git a/tests/boundary/filesystem/referenceSourceUnreadableDirectories.test.ts b/tests/boundary/filesystem/referenceSourceUnreadableDirectories.test.tsnew file mode 100644index 000000000..545025f57--- /dev/null+++ b/tests/boundary/filesystem/referenceSourceUnreadableDirectories.test.ts@@ -0,0 +1,81 @@+import { chmod, mkdir, writeFile } from "node:fs/promises";+import { join } from "node:path";++import { describe, expect, it } from "vitest";++import { importReferenceSource } from "../../../src/application/ReferenceSourceImport.js";+import { readReferenceSource } from "../../../src/reference/ReferenceSourceReader.js";+import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";++const importTree = (root: string) =>+ importReferenceSource({+ root,+ caller: "native-unreadable-directory-test",+ policy: { secretPatterns: [] },+ });++const permissionChecksUnavailable =+ process.platform === "win32" || process.getuid?.() === 0;++describe("reference source native unreadable directories", () => {+ it.skipIf(permissionChecksUnavailable).each(["blocked", "src/blocked"])(+ "preserves a partial graph when %s cannot be enumerated",+ async (blocked) => {+ const root = await createTestTempDirectory("rea-source-unreadable-dir-");+ const deniedPath = join(root, blocked);+ await mkdir(deniedPath, { recursive: true });+ await writeFile(join(root, "main.ts"), "export const value = 1;\n");+ await chmod(deniedPath, 0);+ try {+ const read = await readReferenceSource(root);+ if (!read.ok) throw new Error(read.error.message);+ const directory = read.value.entries.filter(+ ({ path }) => path === blocked,+ );+ expect(directory).toHaveLength(1);+ expect(directory[0]).toMatchObject({+ status: "failed",+ kind: "directory",+ code: "io",+ message: expect.stringContaining("EACCES"),+ });+ const imported = await importTree(root);+ if (!imported.ok) throw new Error(imported.error.message);+ expect(imported.value.inventory_state).toBe("partial");+ expect(+ imported.value.entries.filter(({ path }) => path === blocked),+ ).toEqual([+ expect.objectContaining({+ kind: "directory",+ tree_state: "unreadable",+ limitations: [expect.any(String)],+ }),+ ]);+ expect(+ imported.value.entries.find(({ path }) => path === "main.ts"),+ ).toMatchObject({ content_state: "hashed" });+ } finally {+ await chmod(deniedPath, 0o700);+ }+ },+ );++ it("keeps readable and empty directories enumerated exactly once", async () => {+ const root = await createTestTempDirectory("rea-source-readable-dirs-");+ await mkdir(join(root, "src", "empty"), { recursive: true });+ await writeFile(join(root, "src", "main.ts"), "export const value = 1;\n");+ const imported = await importTree(root);+ if (!imported.ok) throw new Error(imported.error.message);+ for (const path of ["src", "src/empty"]) {+ expect(+ imported.value.entries.filter((entry) => entry.path === path),+ ).toEqual([+ expect.objectContaining({+ kind: "directory",+ tree_state: "enumerated",+ limitations: [],+ }),+ ]);+ }+ });+});