Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(gdb): validate complete thread-group inventories before cleanup
morlutod9aa06d93d95
diff --git a/src/gdb/GdbSessionManager.ts b/src/gdb/GdbSessionManager.tsindex 5102ad84e..ad4c5e21b 100644--- a/src/gdb/GdbSessionManager.ts+++ b/src/gdb/GdbSessionManager.ts@@ -105,13 +105,193 @@ const truncateUtf8RecordPrefix = (line: string): string => {return `${prefix}${RECENT_RECORD_TRUNCATION_MARKER}`;};+/** Bound parser memory when a capped MI record contains extreme nesting. */+const MAX_GDB_MI_NESTED_VALUE_FRAMES = 256;++/** Parse a complete MI result record and retain the unique top-level groups list span. */+const gdbMiGroupsListSpan = (+ mi: string,+): { readonly start: number; readonly end: number } | undefined => {+ const prefix = /^(?:\d+)?\^done/u.exec(mi)?.[0];+ if (prefix === undefined) return undefined;+ const isNameCharacter = (character: string | undefined): boolean =>+ character !== undefined &&+ !/[=,{}[\]"\s]/u.test(character) &&+ character.charCodeAt(0) >= 0x20;+ const readName = (start: number): number => {+ if (!isNameCharacter(mi[start])) return start;+ let cursor = start;+ while (isNameCharacter(mi[cursor])) cursor += 1;+ return cursor;+ };+ const readString = (start: number): number | undefined => {+ for (let cursor = start + 1; cursor < mi.length; cursor += 1) {+ const character = mi[cursor];+ if (character === '"') return cursor + 1;+ if (character === "\\") {+ cursor += 1;+ const escaped = mi[cursor];+ if (escaped === undefined) return undefined;+ if (escaped === "x") {+ const startHex = cursor + 1;+ cursor = startHex;+ while (/[0-9a-f]/iu.test(mi[cursor] ?? "")) cursor += 1;+ if (cursor === startHex) return undefined;+ cursor -= 1;+ } else if (/[0-7]/u.test(escaped)) {+ let digits = 1;+ while (digits < 3 && /[0-7]/u.test(mi[cursor + 1] ?? "")) {+ cursor += 1;+ digits += 1;+ }+ } else if (!/^[abfnrtv\\'"?]$/u.test(escaped)) return undefined;+ } else if (mi.charCodeAt(cursor) < 0x20) return undefined;+ }+ return undefined;+ };+ const stack: {+ readonly kind: "list" | "tuple";+ readonly close: "]" | "}";+ readonly groupInventory: boolean;+ readonly groupStart: number | undefined;+ readonly groupTuple: boolean;+ phase: "first" | "afterComma" | "afterItem";+ listItems: "result" | "value" | undefined;+ groupIdSeen: boolean;+ }[] = [];+ let groupSpan: { start: number; end: number } | undefined;+ let groupSeen = false;+ let cursor = prefix.length;+ let valueStart = -1;+ let pendingGroupList = false;++ const completeValue = (): void => {+ const parent = stack.at(-1);+ if (parent !== undefined) parent.phase = "afterItem";+ };++ const beginValue = (): boolean => {+ const character = mi[cursor];+ if (pendingGroupList && character !== "[") return false;+ if (character === '"') {+ const end = readString(cursor);+ if (end === undefined) return false;+ cursor = end;+ completeValue();+ return true;+ }+ if (character === "[" || character === "{") {+ const kind = character === "[" ? "list" : "tuple";+ const groupInventory = pendingGroupList;+ if (groupInventory && kind !== "list") return false;+ if (stack.length >= MAX_GDB_MI_NESTED_VALUE_FRAMES) return false;+ const parent = stack.at(-1);+ const groupTuple = kind === "tuple" && parent?.groupInventory === true;+ pendingGroupList = false;+ cursor += 1;+ stack.push({+ kind,+ close: kind === "list" ? "]" : "}",+ groupInventory,+ groupStart: groupInventory ? valueStart : undefined,+ groupTuple,+ phase: "first",+ listItems: undefined,+ groupIdSeen: false,+ });+ return true;+ }+ return false;+ };++ while (true) {+ const frame = stack.at(-1);+ if (frame === undefined) {+ if (cursor === mi.length) break;+ if (mi[cursor] !== ",") return undefined;+ cursor += 1;+ const nameEnd = readName(cursor);+ if (nameEnd === cursor || mi[nameEnd] !== "=") return undefined;+ const name = mi.slice(cursor, nameEnd);+ if (name === "groups") {+ if (groupSeen) return undefined;+ groupSeen = true;+ valueStart = nameEnd + 1;+ pendingGroupList = true;+ }+ cursor = nameEnd + 1;+ if (!beginValue()) return undefined;+ continue;+ }++ if (frame.phase === "afterItem") {+ if (mi[cursor] === ",") {+ cursor += 1;+ frame.phase = "afterComma";+ continue;+ }+ if (mi[cursor] !== frame.close) return undefined;+ if (frame.groupTuple && !frame.groupIdSeen) return undefined;+ cursor += 1;+ stack.pop();+ if (frame.groupInventory) {+ if (frame.groupStart === undefined) return undefined;+ groupSpan = { start: frame.groupStart, end: cursor };+ }+ completeValue();+ continue;+ }++ if (frame.phase === "first" && mi[cursor] === frame.close) {+ if (frame.groupTuple && !frame.groupIdSeen) return undefined;+ cursor += 1;+ stack.pop();+ if (frame.groupInventory) {+ if (frame.groupStart === undefined) return undefined;+ groupSpan = { start: frame.groupStart, end: cursor };+ }+ completeValue();+ continue;+ }+ if (frame.phase === "first" || frame.phase === "afterComma") {+ if (frame.kind === "tuple") {+ const nameEnd = readName(cursor);+ if (nameEnd === cursor || mi[nameEnd] !== "=") return undefined;+ if (frame.groupTuple && mi.slice(cursor, nameEnd) === "id") {+ if (frame.groupIdSeen || mi[nameEnd + 1] !== '"') return undefined;+ frame.groupIdSeen = true;+ }+ cursor = nameEnd + 1;+ if (!beginValue()) return undefined;+ continue;+ }++ const nameEnd = readName(cursor);+ const itemIsResult = nameEnd > cursor && mi[nameEnd] === "=";+ const itemKind = itemIsResult ? "result" : "value";+ if (frame.listItems !== undefined && frame.listItems !== itemKind)+ return undefined;+ frame.listItems = itemKind;+ if (frame.groupInventory && (itemIsResult || mi[cursor] !== "{"))+ return undefined;+ if (itemIsResult) cursor = nameEnd + 1;+ if (!beginValue()) return undefined;+ continue;+ }++ return undefined;+ }++ return groupSpan;+};+/** @internal Pure parser for live PIDs in recursive GDB MI thread groups. */export const gdbThreadGroupPids = (mi: string,): readonly string[] | undefined => {- const marker = mi.indexOf("groups=[");- if (marker < 0) return undefined;- const start = marker + "groups=[".length;+ const groupsSpan = gdbMiGroupsListSpan(mi);+ if (groupsSpan === undefined) return undefined;+ const start = groupsSpan.start + 1;let squareDepth = 1;let objectDepth = 0;let quoted = false;@@ -138,6 +318,11 @@ export const gdbThreadGroupPids = (}continue;}+ if (+ (mi[index - 1] === "{" || mi[index - 1] === ",") &&+ mi.startsWith("groups=", index)+ )+ return undefined;if (character === '"') {if (squareDepth === 1 &&@@ -154,9 +339,7 @@ export const gdbThreadGroupPids = (else if (character === "]") {squareDepth -= 1;if (squareDepth === 0) {- if (objectDepth !== 0) return undefined;- const body = mi.slice(start, index);- if (body.includes("groups=[")) return undefined;+ if (objectDepth !== 0 || index + 1 !== groupsSpan.end) return undefined;return pids;}} else if (character === "{") {diff --git a/tests/boundary/providers/GdbSessionManagerCoverage.test.ts b/tests/boundary/providers/GdbSessionManagerCoverage.test.tsindex fc5089989..5c85ccb25 100644--- a/tests/boundary/providers/GdbSessionManagerCoverage.test.ts+++ b/tests/boundary/providers/GdbSessionManagerCoverage.test.ts@@ -30,6 +30,16 @@ const managers: GdbSessionManager[] = [];it.each([["empty list", "1^done,groups=[]", 0],+ [+ "valid trailing extension fields",+ '1^done,groups=[],extension="retained",details=[{state="known"}]',+ 0,+ ],+ [+ "valid leading and trailing extension fields",+ '1^done,before={state="retained"},groups=[],after=["known"]',+ 0,+ ],["one group", '1^done,groups=[{id="i1",pid="123"}]', 1],["multiple groups",@@ -53,17 +63,54 @@ it.each([1,],[- "nested groups field",- '1^done,groups=[{id="i1",extra="groups=["}]',+ "unquoted nested groups field",+ '1^done,groups=[{id="i1",children=[{id="i2",groups=[{id="i3"}]}]}]',+ undefined,+ ],+ [+ "unknown extension field ending in groups",+ '1^done,groups=[{id="i1",other_groups=[{id="i2"}]}]',+ 0,+ ],+ [+ "quoted groups marker before the top-level inventory",+ '1^done,msg="fixture/groups=[",groups=[]',+ 0,+ ],+ [+ "duplicate top-level groups fields",+ '1^done,groups=[],groups=[{id="i1",pid="123"}]',undefined,],+ [+ "duplicate groups field with a non-list value",+ '1^done,groups=[],groups="unavailable"',+ undefined,+ ],+ ["trailing bytes after inventory", "1^done,groups=[]garbage", undefined],+ ["malformed trailing result value", "1^done,groups=[],extra=}", undefined],+ ["malformed prefix result", "1^done,extra=},groups=[]", undefined],+ ["groups list with a non-tuple value", '1^done,groups=["i1"]', undefined],+ ["group tuple without its required id", "1^done,groups=[{}]", undefined],["negative object depth", "1^done,groups=[}]", undefined],["unclosed list", '1^done,groups=[{id="i1"}', undefined],["missing groups field", "1^done", undefined],+ [+ "unclosed trailing quoted field",+ '1^done,groups=[],extra="unterminated',+ undefined,+ ],] as const)("parses recursive GDB MI groups: %s", (_label, mi, expected) => {expect(gdbThreadGroupCount(mi)).toBe(expected);});+it("keeps GDB inventory unknown when MI nesting exceeds the parser frame budget", () => {+ const nestedValue = "[".repeat(257) + "]".repeat(257);+ expect(+ gdbThreadGroupCount("1^done,groups=[],extension=" + nestedValue),+ ).toBeUndefined();+});+it.each([['1^done,inferior_tty_terminal="/dev/pts/2"', "/dev/pts/2"],['1^done,inferior_tty_terminal="line\\nnext"', "line\nnext"],@@ -716,6 +763,34 @@ it("waits for GDB stdout settlement after a no-inferior exit without re-enteringexpect(commands).toContain("-gdb-exit");});+it("closes an idle session when its quoted executable contains groups=[", async () => {+ const commands: string[] = [];+ const fake = createFakeSpawner((child, token, command) => {+ commands.push(command);+ if (command.includes("list-thread-groups"))+ child.stdout.write(+ `${token}^done,groups=[{id="i1",executable="fixture/groups=[.out"}]\n`,+ );+ else if (command.includes("gdb-exit")) {+ child.stdout.write(`${token}^exit\n`);+ queueMicrotask(() => child.exit(0, null));+ } else child.stdout.write(`${token}^done\n`);+ });+ const manager = managerWithFakeSpawner(fake.spawnProcess);+ const started = await expectGdbSessionStarted(manager);++ const closed = await manager.close(started.value.session_id);++ expect(closed).toMatchObject({+ ok: true,+ value: { target_state: "none_observed" },+ });+ expect(+ commands.filter((command) => command.includes("list-thread-groups")),+ ).toHaveLength(1);+ expect(commands).toContain("-gdb-exit");+}, 10_000);+it("reports incomplete stop if GDB exits while close waits in the serialized queue", async () => {let heldToken = "";const fake = createFakeSpawner((child, token, command) => {@@ -1696,31 +1771,43 @@ it("refuses to close a session while GDB reports a live target", async () => {);});-it("retains ownership when recursive MI returns an unknown inferior list", async () => {- const commands: string[] = [];- const fake = createFakeSpawner((child, token, command) => {- commands.push(command);- child.stdout.write(- command.includes("list-thread-groups")- ? `${token}^done,groups=[}]\n`- : `${token}^done\n`,- );- });- const manager = managerWithFakeSpawner(fake.spawnProcess);- const started = await expectGdbSessionStarted(manager);+it.each([+ ["malformed recursive list", "groups=[}]"],+ ["malformed result suffix", "groups=[],extra=}"],+ ["malformed leading result", "extra=},groups=[]"],+ [+ "duplicate inventory with a live PID after an empty list",+ 'groups=[],groups=[{id="i1",pid="123"}]',+ ],+] as const)(+ "retains ownership when recursive MI cannot establish one safe inventory: %s",+ async (_label, groups) => {+ const commands: string[] = [];+ const fake = createFakeSpawner((child, token, command) => {+ commands.push(command);+ child.stdout.write(+ command.includes("list-thread-groups")+ ? `${token}^done,${groups}\n`+ : `${token}^done\n`,+ );+ });+ const manager = managerWithFakeSpawner(fake.spawnProcess);+ const started = await expectGdbSessionStarted(manager);- const closed = await manager.close(started.value.session_id);+ const closed = await manager.close(started.value.session_id);- expect(closed).toMatchObject({- ok: false,- error: { _tag: "AnalysisCapabilityUnavailableError" },- });- expect(- commands.filter((command) => command.includes("list-thread-groups")),- ).toHaveLength(2);- expect(manager.status(started.value.session_id)).toBeDefined();- expect(fake.children[0]?.killSignals).toEqual([]);-});+ expect(closed).toMatchObject({+ ok: false,+ error: { _tag: "AnalysisCapabilityUnavailableError" },+ });+ expect(+ commands.filter((command) => command.includes("list-thread-groups")),+ ).toHaveLength(2);+ expect(commands).not.toContain("-gdb-exit");+ expect(manager.status(started.value.session_id)).toBeDefined();+ expect(fake.children[0]?.killSignals).toEqual([]);+ },+);it("detaches a live inferior before the shared stop helper signals GDB", async () => {const tty = "/dev/pts/42";