Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
refactor(javascript): share result binding projection and facts
morlutodbcec4cf56e7
diff --git a/src/application/javascript/JavaScriptSemanticGraphAsyncProjection.ts b/src/application/javascript/JavaScriptSemanticGraphAsyncProjection.tsindex fa2053d83..6c8ac206d 100644--- a/src/application/javascript/JavaScriptSemanticGraphAsyncProjection.ts+++ b/src/application/javascript/JavaScriptSemanticGraphAsyncProjection.ts@@ -10,7 +10,10 @@ import {addSemanticGraphUnknown,} from "./JavaScriptSemanticGraphConstruction.js";import { unknownSemanticEvidence } from "./JavaScriptSemanticGraphEvidence.js";-import type { SemanticFlowProjectionContext } from "./JavaScriptSemanticGraphFlowProjection.js";+import {+ projectSemanticResultBindings,+ type SemanticFlowProjectionContext,+} from "./JavaScriptSemanticGraphFlowProjection.js";/** Project literal EventEmitter registrations, removals, and dispatches. */export const projectSemanticEvents = (@@ -180,18 +183,11 @@ const projectTimerSchedule = (relation: "schedules-timer",resolution: "resolved",});- for (const projected of operation.projectedResultBindings)- addSemanticGraphRelation(context.state, {- source: timerNodes.get(operation.timerId),- target: context.bindingNodes.get(projected.bindingId),- relation: "destructures",- resolution:- projected.resolution === "complete" ? "resolved" : "candidate",- properties: {- projection_path: [...projected.projectionPath],- projection_resolution: projected.resolution,- },- });+ projectSemanticResultBindings(+ context,+ timerNodes.get(operation.timerId),+ operation.projectedResultBindings,+ );};const projectTimerCancellation = (diff --git a/src/application/javascript/JavaScriptSemanticGraphChildProcessProjection.ts b/src/application/javascript/JavaScriptSemanticGraphChildProcessProjection.tsindex df3f932ff..de01c7af3 100644--- a/src/application/javascript/JavaScriptSemanticGraphChildProcessProjection.ts+++ b/src/application/javascript/JavaScriptSemanticGraphChildProcessProjection.ts@@ -9,7 +9,10 @@ import {addSemanticGraphUnknown,} from "./JavaScriptSemanticGraphConstruction.js";import { unknownSemanticEvidence } from "./JavaScriptSemanticGraphEvidence.js";-import type { SemanticFlowProjectionContext } from "./JavaScriptSemanticGraphFlowProjection.js";+import {+ projectSemanticResultBindings,+ type SemanticFlowProjectionContext,+} from "./JavaScriptSemanticGraphFlowProjection.js";interface ChildUnknownInput {readonly context: SemanticFlowProjectionContext;@@ -80,18 +83,7 @@ const projectSpawn = (relation: "spawns",resolution: spawn.resolution === "complete" ? "resolved" : "candidate",});- for (const projected of spawn.projectedResultBindings)- addSemanticGraphRelation(context.state, {- source: child,- target: context.bindingNodes.get(projected.bindingId),- relation: "destructures",- resolution:- projected.resolution === "complete" ? "resolved" : "candidate",- properties: {- projection_path: [...projected.projectionPath],- projection_resolution: projected.resolution,- },- });+ projectSemanticResultBindings(context, child, spawn.projectedResultBindings);if (spawn.argvCount !== null)addSemanticGraphRelation(context.state, {source: callSite,diff --git a/src/application/javascript/JavaScriptSemanticGraphDataProjection.ts b/src/application/javascript/JavaScriptSemanticGraphDataProjection.tsindex b1862168f..c5b7e9abb 100644--- a/src/application/javascript/JavaScriptSemanticGraphDataProjection.ts+++ b/src/application/javascript/JavaScriptSemanticGraphDataProjection.ts@@ -10,7 +10,10 @@ import {addSemanticGraphUnknown,} from "./JavaScriptSemanticGraphConstruction.js";import { unknownSemanticEvidence } from "./JavaScriptSemanticGraphEvidence.js";-import type { SemanticFlowProjectionContext } from "./JavaScriptSemanticGraphFlowProjection.js";+import {+ projectSemanticResultBindings,+ type SemanticFlowProjectionContext,+} from "./JavaScriptSemanticGraphFlowProjection.js";import { semanticResourceLimitReason } from "../../domain/javascript/javascriptSemanticResourceLimits.js";/** Project environment, argv, file, default, and precedence candidates. */@@ -179,18 +182,11 @@ const projectRequestConstruction = (relation: "constructs-request",resolution: operation.resolution === "complete" ? "resolved" : "candidate",});- for (const projected of operation.projectedResultBindings)- addSemanticGraphRelation(context.state, {- source: request,- target: context.bindingNodes.get(projected.bindingId),- relation: "destructures",- resolution:- projected.resolution === "complete" ? "resolved" : "candidate",- properties: {- projection_path: [...projected.projectionPath],- projection_resolution: projected.resolution,- },- });+ projectSemanticResultBindings(+ context,+ request,+ operation.projectedResultBindings,+ );for (const field of operation.fields)addSemanticGraphRelation(context.state, {source:diff --git a/src/application/javascript/JavaScriptSemanticGraphFlowProjection.ts b/src/application/javascript/JavaScriptSemanticGraphFlowProjection.tsindex 59ab8b52d..6b2acc8de 100644--- a/src/application/javascript/JavaScriptSemanticGraphFlowProjection.ts+++ b/src/application/javascript/JavaScriptSemanticGraphFlowProjection.ts@@ -1,6 +1,9 @@import type { JavaScriptSemanticGraphNode } from "../../domain/javascript/javascriptSemanticGraphSchemas.js";import { javaScriptSemanticNodeId } from "../../domain/javascript/javascriptSemanticGraph.js";-import type { JavaScriptSemanticIr } from "../../domain/javascript/javascriptSemanticIr.js";+import type {+ JavaScriptSemanticIr,+ JavaScriptSemanticProjectedResultBinding,+} from "../../domain/javascript/javascriptSemanticIr.js";import { sourceRangesEqual } from "../../domain/javascript/javascriptStaticAnalysisHelpers.js";import type { JavaScriptSourceRange } from "../../domain/javascript/javascriptStaticAnalysisTypes.js";import type { JavaScriptArtifactFile } from "../../domain/javascript/javascriptArtifactFiles.js";@@ -34,6 +37,26 @@ export interface SemanticFlowProjectionContext {) => JavaScriptSemanticGraphNode | undefined;}+/** Project result destructuring consistently for timers, child processes, and requests. */+export const projectSemanticResultBindings = (+ context: Pick<SemanticFlowProjectionContext, "state" | "bindingNodes">,+ source: JavaScriptSemanticGraphNode | undefined,+ bindings: readonly JavaScriptSemanticProjectedResultBinding[],+): void => {+ for (const projected of bindings)+ addSemanticGraphRelation(context.state, {+ source,+ target: context.bindingNodes.get(projected.bindingId),+ relation: "destructures",+ resolution:+ projected.resolution === "complete" ? "resolved" : "candidate",+ properties: {+ projection_path: [...projected.projectionPath],+ projection_resolution: projected.resolution,+ },+ });+};+/** Project explicit static Promise/task ownership without runtime claims. */export const projectSemanticPromises = (context: SemanticFlowProjectionContext,diff --git a/src/domain/javascript/javascriptSemanticAsyncEffects.ts b/src/domain/javascript/javascriptSemanticAsyncEffects.tsindex 99fe53873..bb2b6876d 100644--- a/src/domain/javascript/javascriptSemanticAsyncEffects.ts+++ b/src/domain/javascript/javascriptSemanticAsyncEffects.ts@@ -2,6 +2,7 @@ import * as t from "@babel/types";import type {JavaScriptSemanticCallable,+ JavaScriptSemanticProjectedResultBinding,JavaScriptSemanticEventOperation,JavaScriptSemanticTimerOperation,} from "./javascriptSemanticIr.js";@@ -71,11 +72,7 @@ interface TimerCandidate {readonly kind: JavaScriptSemanticTimerOperation["kind"];readonly ownerCallableId: string | null;readonly handleBindingId: string | null;- readonly projectedResultBindings: readonly {- readonly bindingId: string;- readonly projectionPath: readonly (string | number | null)[];- readonly resolution: "complete" | "partial";- }[];+ readonly projectedResultBindings: readonly JavaScriptSemanticProjectedResultBinding[];readonly handleRead: {readonly origins: readonly t.Node[];readonly complete: boolean;diff --git a/src/domain/javascript/javascriptSemanticChildProcesses.ts b/src/domain/javascript/javascriptSemanticChildProcesses.tsindex 639be8268..3140e08bf 100644--- a/src/domain/javascript/javascriptSemanticChildProcesses.ts+++ b/src/domain/javascript/javascriptSemanticChildProcesses.ts@@ -2,6 +2,7 @@ import * as t from "@babel/types";import type {JavaScriptSemanticCallable,+ JavaScriptSemanticProjectedResultBinding,JavaScriptSemanticChildProcessInteraction,JavaScriptSemanticChildProcessSpawn,} from "./javascriptSemanticIr.js";@@ -49,11 +50,7 @@ interface SpawnCandidate {readonly method: JavaScriptSemanticChildProcessSpawn["method"];readonly ownerCallableId: string | null;readonly resultBindingId: string | null;- readonly projectedResultBindings: readonly {- readonly bindingId: string;- readonly projectionPath: readonly (string | number | null)[];- readonly resolution: "complete" | "partial";- }[];+ readonly projectedResultBindings: readonly JavaScriptSemanticProjectedResultBinding[];}interface ChildInteractionContext {diff --git a/src/domain/javascript/javascriptSemanticDataEffectHelpers.ts b/src/domain/javascript/javascriptSemanticDataEffectHelpers.tsindex 6c0f3c210..e014149f5 100644--- a/src/domain/javascript/javascriptSemanticDataEffectHelpers.ts+++ b/src/domain/javascript/javascriptSemanticDataEffectHelpers.ts@@ -8,7 +8,10 @@ import {semanticGlobalProcessOrigin,semanticMutableBuiltinOrigin,} from "./javascriptSemanticRequireOrigin.js";-import type { JavaScriptModuleOrigin } from "./javascriptSemanticIr.js";+import type {+ JavaScriptModuleOrigin,+ JavaScriptSemanticProjectedResultBinding,+} from "./javascriptSemanticIr.js";import {evaluateSemanticProvenance,evaluateSemanticProvenanceAtRead,@@ -35,11 +38,8 @@ import {unwrapJavaScriptExpression,} from "./javascriptAstValues.js";-export interface SemanticProjectedBinding {- readonly bindingId: string;+export interface SemanticProjectedBinding extends JavaScriptSemanticProjectedResultBinding {readonly identifier: t.Identifier;- readonly projectionPath: readonly (string | number | null)[];- readonly resolution: "complete" | "partial";}/** Resolve bindings written by the nearest variable or assignment owner. */@@ -136,7 +136,7 @@ const projectedPatternBindings = (export const semanticProjectedBindingFacts = (bindings: readonly SemanticProjectedBinding[],-): Omit<SemanticProjectedBinding, "identifier">[] =>+): JavaScriptSemanticProjectedResultBinding[] =>bindings.map(({ identifier: _identifier, ...fact }) => fact);/** Return a scalar owner only for an unprojected identifier result. */