Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(browser): preserve repeated document Link fields
morlutodf2fc251e318
diff --git a/docs/browser-observation.md b/docs/browser-observation.mdindex ca860ed00..dc940f49c 100644--- a/docs/browser-observation.md+++ b/docs/browser-observation.md@@ -285,6 +285,10 @@ REA establishes a main-frame origin boundary before enabling Runtime, Debugger,## Data minimization+The Link projection parses repeated CDP header field lines independently and+retains their declarations in order, including derived untrusted agent hints.+Commas inside URI targets or quoted parameters remain part of those values.+REA retains local observation data and removes only URL userinfo credentials, explicitly declared scenario secrets, and values from structured credential/storage fields:- URL observations preserve the complete local URL, including query values, fragments, duplicate parameters, and their order. Only username/password userinfo is removed; malformed original URL strings remain available with `origin: null`.diff --git a/src/browser/CdpSafeMetadata.test.ts b/src/browser/CdpSafeMetadata.test.tsindex ef9c42e14..7ff6e7142 100644--- a/src/browser/CdpSafeMetadata.test.ts+++ b/src/browser/CdpSafeMetadata.test.ts@@ -202,6 +202,53 @@ describe("Link header value delimiters", () => {new Set(["https://owned.test"]),).response.links;+ it.each([", ", "\n", "\r\n"])(+ "preserves repeated field declarations and agent hints joined by %j",+ (separator) => {+ const captured = safeResponseMetadata(+ "document-response",+ `${origin}/page`,+ {+ headers: {+ Link: [+ '</assets/red,blue.js>; rel="preload"; type="text/javascript; charset=utf-8"; title="a,b"',+ '</agent?selected=keep>; rel="mcp service-desc"',+ ].join(separator),+ },+ },+ new Set([origin]),+ );+ expect(captured.response.links).toMatchObject([+ {+ href: `${origin}/assets/red,blue.js`,+ rel: ["preload"],+ type: "text/javascript; charset=utf-8",+ },+ {+ href: `${origin}/agent?selected=keep`,+ rel: ["mcp", "service-desc"],+ },+ ]);+ expect(captured.agentHints).toContainEqual({+ mechanism: "link_rel",+ declaration: "mcp service-desc",+ url: `${origin}/agent?selected=keep`,+ trust: "page-declared-untrusted",+ });+ },+ );++ it("keeps delimiters scoped to each CDP field line", () => {+ const links = captureLinks(+ '</first>; title="unterminated\n</agent>; rel=mcp',+ );+ expect(links.map(({ href }) => href)).toEqual([+ "https://owned.test/first",+ "https://owned.test/agent",+ ]);+ expect(links[1]?.rel).toEqual(["mcp"]);+ });+it("preserves commas in URI references and separates later links", () => {const links = captureLinks('</assets/red,blue.js>; rel="preload"; as=script, </ordinary.js>; rel="modulepreload"',diff --git a/src/browser/CdpSafeMetadata.ts b/src/browser/CdpSafeMetadata.tsindex 1347cdcca..db8589fb7 100644--- a/src/browser/CdpSafeMetadata.ts+++ b/src/browser/CdpSafeMetadata.ts@@ -185,26 +185,29 @@ const parseLinks = (allowedOrigins: ReadonlySet<string>,): LinkMetadata[] => {const links: LinkMetadata[] = [];- for (const entry of splitLinkHeader(value ?? "")) {- const match = /^\s*<([^>]*)>(.*)$/u.exec(entry);- if (match === null) continue;- const parameters = linkParameters(match[2] ?? "");- const destination = safeDestination(- match[1] ?? "",- baseUrl,- allowedOrigins,- );- links.push({- href: destination.url,- destination_scope: destination.scope,- rel: (parameters.get("rel") ?? "")- .toLowerCase()- .split(/\s+/u)- .filter(Boolean),- as: boundedHeader(parameters.get("as")),- type: boundedHeader(parameters.get("type")),- crossorigin: boundedHeader(parameters.get("crossorigin")),- });+ // CDP joins repeated field lines with LF; quoted delimiters belong to one line.+ for (const line of (value ?? "").split(/\r?\n/u)) {+ for (const entry of splitLinkHeader(line)) {+ const match = /^\s*<([^>]*)>(.*)$/u.exec(entry);+ if (match === null) continue;+ const parameters = linkParameters(match[2] ?? "");+ const destination = safeDestination(+ match[1] ?? "",+ baseUrl,+ allowedOrigins,+ );+ links.push({+ href: destination.url,+ destination_scope: destination.scope,+ rel: (parameters.get("rel") ?? "")+ .toLowerCase()+ .split(/\s+/u)+ .filter(Boolean),+ as: boundedHeader(parameters.get("as")),+ type: boundedHeader(parameters.get("type")),+ crossorigin: boundedHeader(parameters.get("crossorigin")),+ });+ }}return links;};diff --git a/tests/boundary/browser/cdpBrowserProvider.network.test.ts b/tests/boundary/browser/cdpBrowserProvider.network.test.tsindex a481af2ce..7e3ab444e 100644--- a/tests/boundary/browser/cdpBrowserProvider.network.test.ts+++ b/tests/boundary/browser/cdpBrowserProvider.network.test.ts@@ -5,6 +5,73 @@ import { inspectWebPageInputSchema } from "../../../src/domain/browserObservatioimport { startFakeCdpBrowser } from "../../fixtures/fakeCdpBrowser.js";import { trackBrowser } from "./cdpBrowserProvider.support.js";+it("preserves repeated Document Link fields and their derived agent hints", async () => {+ const browser = await startFakeCdpBrowser({+ commandEvents(command, origin) {+ if (command.method !== "Network.enable") return undefined;+ const session =+ command.sessionId === undefined ? {} : { sessionId: command.sessionId };+ return [+ {+ ...session,+ method: "Network.requestWillBeSent",+ params: {+ requestId: "repeated-document",+ type: "Document",+ request: { url: `${origin}/frame`, method: "GET" },+ initiator: { type: "parser" },+ },+ },+ {+ ...session,+ method: "Network.responseReceived",+ params: {+ requestId: "repeated-document",+ type: "Document",+ response: {+ url: `${origin}/frame`,+ status: 200,+ mimeType: "text/html",+ headers: { Link: "</next>; rel=next\n</agent>; rel=mcp" },+ },+ },+ },+ ];+ },+ });+ trackBrowser(browser);+ const result = await new CdpBrowserProvider().inspectPage(+ inspectWebPageInputSchema.parse({+ cdp_endpoint: browser.endpoint,+ allowed_origins: [browser.allowedOrigin],+ target_id: "allowed-page",+ observation_ms: 1,+ }),+ );+ if (!result.ok) throw result.error;+ expect(result.value.metadata.responses).toContainEqual(+ expect.objectContaining({+ request_id: "repeated-document",+ links: [+ expect.objectContaining({+ href: `${browser.allowedOrigin}/next`,+ rel: ["next"],+ }),+ expect.objectContaining({+ href: `${browser.allowedOrigin}/agent`,+ rel: ["mcp"],+ }),+ ],+ }),+ );+ expect(result.value.metadata.agent_hints).toContainEqual({+ mechanism: "link_rel",+ declaration: "mcp",+ url: `${browser.allowedOrigin}/agent`,+ trust: "page-declared-untrusted",+ });+});+it("preserves unavailable response observations and captures completed peers", async () => {const browser = await startFakeCdpBrowser({commandEvents(command, origin) {