Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(semantics): preserve direct promise ownership boundaries (#758)
Rudy Mizrahi Celeklie1ca412757bb
diff --git a/src/application/JavaScriptSemanticGraphBuilder.test.ts b/src/application/JavaScriptSemanticGraphBuilder.test.tsindex 5b2804615..b888d9721 100644--- a/src/application/JavaScriptSemanticGraphBuilder.test.ts+++ b/src/application/JavaScriptSemanticGraphBuilder.test.ts@@ -286,3 +286,27 @@ const graphFor = (source: string) => {analysis,});};++it.each([+ "const value = consume(Promise.resolve(1));",+ "async function run() { await consume(Promise.resolve(1)); }",+ "function run() { return consume(Promise.resolve(1)); }",+ "const value = Promise.all([{ promise: Promise.resolve(1) }]);",+])(+ "does not claim direct Promise ownership through an enclosing expression: %s",+ (source) => {+ const graph = graphFor(source);+ const promise = graph.nodes.find(+ ({ kind, properties }) =>+ kind === "promise" && properties.method === "resolve",+ );+ expect(promise?.properties.ownership).toBe("unknown");+ expect(+ graph.relations.filter(+ ({ target_node_id, relation }) =>+ target_node_id === promise?.node_id &&+ ["owns", "awaits", "returns-task", "aggregates"].includes(relation),+ ),+ ).toEqual([]);+ },+);diff --git a/src/domain/javascriptSemanticAnalysis.promise_ownership.test.ts b/src/domain/javascriptSemanticAnalysis.promise_ownership.test.tsnew file mode 100644index 000000000..2a5348aa6--- /dev/null+++ b/src/domain/javascriptSemanticAnalysis.promise_ownership.test.ts@@ -0,0 +1,61 @@+import { expect, it } from "vitest";++import { analyzeJavaScriptSemantics } from "./javascriptSemanticAnalysis.js";++it.each([+ {+ source: "const value = (Promise.resolve(1) as Promise<number>);",+ ownership: "assigned",+ },+ {+ source: "const run = () => (Promise.resolve(1) as Promise<number>);",+ ownership: "returned",+ },+ {+ source: "const value = consume(Promise.resolve(1)).then(work);",+ ownership: "unknown",+ },+ {+ source: "const value = consume(Promise.resolve(1));",+ ownership: "unknown",+ },+ {+ source: "async function run() { await consume(Promise.resolve(1)); }",+ ownership: "unknown",+ },+ {+ source: "function run() { return consume(Promise.resolve(1)); }",+ ownership: "unknown",+ },+ { source: "const value = [Promise.resolve(1)];", ownership: "unknown" },+ {+ source: "const value = Promise.all([{promise: Promise.resolve(1)}]);",+ ownership: "unknown",+ },+ { source: "const value = Promise.resolve(1);", ownership: "assigned" },+ {+ source: "async function run() { await Promise.resolve(1); }",+ ownership: "awaited",+ },+ {+ source: "function run() { return Promise.resolve(1); }",+ ownership: "returned",+ },+ {+ source: "const value = Promise.resolve(1).then(work);",+ ownership: "chained",+ },+ {+ source: "const value = Promise.all([Promise.resolve(1)]);",+ ownership: "aggregated",+ },+ { source: "Promise.resolve(1);", ownership: "detached" },+])("retains direct Promise ownership in $source", ({ source, ownership }) => {+ const ir = analyzeJavaScriptSemantics(source);+ const promise = ir.promiseOperations.find(+ ({ method }) => method === "resolve",+ );+ expect(promise).toMatchObject({ ownership });+ if (ownership === "unknown")+ expect(promise).toMatchObject({ ownerBindingId: null, returnSiteId: null });+});diff --git a/src/domain/javascriptSemanticPromises.ts b/src/domain/javascriptSemanticPromises.tsindex 4b320a267..6e718db74 100644--- a/src/domain/javascriptSemanticPromises.ts+++ b/src/domain/javascriptSemanticPromises.ts@@ -18,7 +18,6 @@ import { traverseJavaScriptAst } from "./javascriptSemanticTraversal.js";import { range, sourceRangesEqual } from "./javascriptStaticAnalysisHelpers.js";import {assignedSemanticResultBindings,- containsSemanticNode,dataEffectMemberCallee,scalarAssignedResultBinding,} from "./javascriptSemanticDataEffectHelpers.js";@@ -205,7 +204,10 @@ const ownershipAtAncestor = (context: PromiseOwnershipContext,): PromiseOwnership | "boundary" | null => {const { candidate, candidateByNode, state, callables } = context;- if (t.isAwaitExpression(ancestor)) return emptyOwnership("awaited");+ if (t.isAwaitExpression(ancestor))+ return unwrapExpression(ancestor.argument) === candidate.node+ ? emptyOwnership("awaited")+ : "boundary";const outer = candidateByNode.get(ancestor);if (outer !== undefined &&@@ -215,25 +217,35 @@ const ownershipAtAncestor = (return outer.kind === "chain"? emptyOwnership("chained"): emptyOwnership("aggregated");- const assigned = assignedPromiseBinding(ancestor, state);+ if (isUnmodeledCall(ancestor, outer)) return "boundary";+ const assigned = assignedPromiseBinding(ancestor, candidate.node, state);if (assigned !== undefined)return {ownership: "assigned",ownerBindingId: assigned,returnSiteId: null,};- if (t.isReturnStatement(ancestor))+ if (t.isReturnStatement(ancestor)) {+ if (+ ancestor.argument == null ||+ unwrapExpression(ancestor.argument) !== candidate.node+ )+ return "boundary";return returnedPromiseOwnership(candidate.ownerCallableId,range(ancestor),callables,);- if (t.isExpressionStatement(ancestor)) return emptyOwnership("detached");+ }+ if (t.isExpressionStatement(ancestor))+ return unwrapExpression(ancestor.expression) === candidate.node+ ? emptyOwnership("detached")+ : "boundary";const callableId = semanticCallableIdForNode(ancestor);if (callableId === null || callableId !== candidate.ownerCallableId)return null;return t.isArrowFunctionExpression(ancestor) &&- ancestor.body === candidate.node+ unwrapExpression(ancestor.body) === candidate.node? returnedPromiseOwnership(candidate.ownerCallableId,range(candidate.node),@@ -242,8 +254,18 @@ const ownershipAtAncestor = (: "boundary";};+const isUnmodeledCall = (+ node: t.Node,+ candidate: PromiseCandidate | undefined,+): boolean =>+ candidate === undefined &&+ (t.isCallExpression(node) ||+ t.isOptionalCallExpression(node) ||+ t.isNewExpression(node));+const assignedPromiseBinding = (ancestor: t.Node,+ candidate: t.Node,state: JavaScriptSemanticAnalysisState,): string | null | undefined => {if (!t.isVariableDeclarator(ancestor) && !t.isAssignmentExpression(ancestor))@@ -252,6 +274,7 @@ const assignedPromiseBinding = (? ancestor.init: ancestor.right;if (source == null) return undefined;+ if (unwrapExpression(source) !== candidate) return undefined;return scalarAssignedResultBinding(assignedSemanticResultBindings(source, [ancestor], state),);@@ -277,7 +300,7 @@ const outerConsumesCandidate = () {const member = dataEffectMemberCallee(outer.node);return (- member !== null && containsSemanticNode(member.object, candidate.node)+ member !== null && unwrapExpression(member.object) === candidate.node);}if (@@ -285,7 +308,15 @@ const outerConsumesCandidate = ((t.isCallExpression(outer.node) || t.isOptionalCallExpression(outer.node))) {const input = outer.node.arguments[0];- return t.isNode(input) && containsSemanticNode(input, candidate.node);+ return (+ t.isArrayExpression(input) &&+ input.elements.some(+ (element) =>+ element !== null &&+ !t.isSpreadElement(element) &&+ unwrapExpression(element) === candidate.node,+ )+ );}return false;};