Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(managed): avoid duplicate decode budget charging on cached metadata strings

keeponlighte26bb49a4b83
diff --git a/src/dotnet/ManagedMetadataHeaps.test.ts b/src/dotnet/ManagedMetadataHeaps.test.ts
index ebc2a0d49..0795455c7 100644
--- a/src/dotnet/ManagedMetadataHeaps.test.ts
+++ b/src/dotnet/ManagedMetadataHeaps.test.ts
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
import {
readMetadataBlob,
+ readMetadataString,
readMetadataUserString,
} from "./ManagedMetadataHeaps.js";
import type { ManagedMetadataLayout } from "./ManagedMetadataLayout.js";
@@ -56,4 +57,36 @@ describe("managed metadata heaps", () => {
);
},
);
+
+ it("does not re-charge the decode budget on metadata string cache hits", () => {
+ const strLen = 10 * 1024 * 1024;
+ const strBytes = Buffer.alloc(strLen + 2, 0x61);
+ strBytes[0] = 0x00;
+ strBytes[strLen + 1] = 0x00;
+ const layout = {
+ rootOffset: 0,
+ size: strBytes.length,
+ version: "",
+ streamNames: ["#Strings"],
+ strings: { name: "#Strings", offset: 0, size: strBytes.length },
+ guid: { name: "#GUID", offset: 0, size: 0 },
+ blob: { name: "#Blob", offset: 0, size: 0 },
+ userStrings: null,
+ tables: new Map(),
+ rowCounts: [],
+ stringIndexSize: 2,
+ guidIndexSize: 2,
+ blobIndexSize: 2,
+ table: () => undefined,
+ tableIndexSize: () => 2,
+ codedIndexSize: () => 2,
+ } as unknown as ManagedMetadataLayout;
+
+ const first = readMetadataString(strBytes, layout, 1, layout.strings.size);
+ expect(first).toHaveLength(strLen);
+
+ expect(() =>
+ readMetadataString(strBytes, layout, 1, layout.strings.size),
+ ).not.toThrow();
+ });
});
diff --git a/src/dotnet/ManagedMetadataHeaps.ts b/src/dotnet/ManagedMetadataHeaps.ts
index 0987680f0..706980a63 100644
--- a/src/dotnet/ManagedMetadataHeaps.ts
+++ b/src/dotnet/ManagedMetadataHeaps.ts
@@ -125,7 +125,6 @@ export const readMetadataString = (
const start = layout.strings.offset + index;
const cached = managedDecodeBudget(layout).cachedString(index);
if (cached !== undefined && cached.encodedBytes <= heapExtent) {
- managedDecodeBudget(layout).reserveString(cached.encodedBytes, start);
return cached.value;
}
const maximum = Math.min(