Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(gpu): accept PTX entries without parameter lists
morlutoe44899d510ce
diff --git a/src/gpu/PtxKernels.test.ts b/src/gpu/PtxKernels.test.tsindex 3b811fcc9..48dd48c32 100644--- a/src/gpu/PtxKernels.test.ts+++ b/src/gpu/PtxKernels.test.ts@@ -83,6 +83,8 @@ it("does not round overflowing register totals or accept truncated ranges", () =it.each(["/* unfinished",".entry broken(",+ ".entry k",+ ".entry k ) { ret; }",".entry k() {",".entry k() {.reg .u32 %x}",".entry k() {.reg %x;}",diff --git a/src/gpu/PtxKernels.ts b/src/gpu/PtxKernels.tsindex fcdcc01c8..d15ac6bd6 100644--- a/src/gpu/PtxKernels.ts+++ b/src/gpu/PtxKernels.ts@@ -190,7 +190,7 @@ export function* readPtxKernels(}if (outerDepth !== 0 || token.value !== ".entry") continue;const name = next();- if (!/^[A-Za-z_$][\w$@.]*$/u.test(name.value) || next().value !== "(")+ if (!/^[A-Za-z_$][\w$@.]*$/u.test(name.value))rejectGpu("Malformed PTX entry name or parameters");const parameters: GpuKernel["parameters"] = [];let part: string[] = [],@@ -222,18 +222,23 @@ export function* readPtxKernels(});part = [];};- for (let t = next(); t.value !== ")"; t = next()) {- if (t.value === ",") flush();- else part.push(t.value);- if (part.length > 128 || parameters.length > 65536)- throw new BinaryResourceFailure(- "structure",- 65536,- "PTX parameter declarations exceed the facts budget",- );- }- flush();let t = next();+ if (t.value === "(") {+ for (t = next(); t.value !== ")"; t = next()) {+ if (t.value === ",") flush();+ else part.push(t.value);+ if (part.length > 128 || parameters.length > 65536)+ throw new BinaryResourceFailure(+ "structure",+ 65536,+ "PTX parameter declarations exceed the facts budget",+ );+ }+ flush();+ t = next();+ } else if (t.value !== "{" && t.value !== ";" && !t.value.startsWith(".")) {+ rejectGpu("Malformed PTX entry name or parameters");+ }// Entry directives can occur between the parameter list and body.let headerTokens = 0;while (t.value !== "{" && t.value !== ";") {diff --git a/tests/boundary/gpu/codeObjects.test.ts b/tests/boundary/gpu/codeObjects.test.tsindex e464fa599..b5f6d067f 100644--- a/tests/boundary/gpu/codeObjects.test.ts+++ b/tests/boundary/gpu/codeObjects.test.ts@@ -314,6 +314,21 @@ it("retains unknown PTX virtual counts and partial payload coverage", async () =count: null,});});+it.each([+ ".entry k { ret; }",+ ".entry k() { ret; }",+ ".entry k .maxntid 1 { ret; }",+])("inspects PTX entry with optional parameters: %s", async (entry) => {+ const result = await inspect(+ Buffer.from(`.version 7.0\n.target sm_80\n.address_size 64\n${entry}`),+ );+ if (!result.ok) throw result.error;+ expect(result.value.objects[0]!.inspection).toBe("complete");+ expect(result.value.coverage.payloads).toBe("complete");+ expect(result.value.kernels).toMatchObject([+ { name: "k", parameter_count: 0, parameter_bytes: 0, parameters: [] },+ ]);+});it.each([["parameter", ".u64 output", ".u64 .ptr .global output"],["shared", "scratch[32]", "scratch[]"],