Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(artifacts): mark Windows launchable files as host executables (#1824)

Itoje Dollare8491e023a25
diff --git a/src/artifacts/hostExecutableMarking.test.ts b/src/artifacts/hostExecutableMarking.test.ts
index 7aff5bbda..9f97186d2 100644
--- a/src/artifacts/hostExecutableMarking.test.ts
+++ b/src/artifacts/hostExecutableMarking.test.ts
@@ -13,6 +13,16 @@ describe("hostExecutableMarking", () => {
expect(
hostExecutableMarking("C:\\scratch\\SETUP.CMD", file(0o444), "win32"),
).toBe(true);
+ for (const path of [
+ "tools/SETUP.EXE",
+ "run.Cmd",
+ "build.bat",
+ "legacy.com",
+ ])
+ expect(hostExecutableMarking(path, file(0o666), "win32")).toBe(true);
+ expect(hostExecutableMarking("readonly.exe", file(0o444), "win32")).toBe(
+ true,
+ );
expect(
hostExecutableMarking("C:\\scratch\\library.dll", file(0o666), "win32"),
).toBe(false);
@@ -25,6 +35,11 @@ describe("hostExecutableMarking", () => {
).toBe(false);
});
+ it("does not treat other Windows filenames as executable even with execute bits", () => {
+ for (const path of ["notes.txt", "README", "archive.exe.bak"])
+ expect(hostExecutableMarking(path, file(0o777), "win32")).toBe(false);
+ });
+
it("keeps POSIX permission bits authoritative regardless of extension", () => {
expect(hostExecutableMarking("/scratch/tool", file(0o755), "linux")).toBe(
true,