Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(wasm): stop appending WABT remediation to unrelated runtime-root failures (#2084)

Hill Patelea2f94d4de22
diff --git a/src/wasm/WabtArtifactProvider.test.ts b/src/wasm/WabtArtifactProvider.test.ts
index 5a9e1cc45..74d481de3 100644
--- a/src/wasm/WabtArtifactProvider.test.ts
+++ b/src/wasm/WabtArtifactProvider.test.ts
@@ -3,7 +3,10 @@ import { join } from "node:path";
import { expect, it } from "vitest";
import { createTestTempDirectory } from "../../tests/fixtures/temporaryDirectory.js";
import { WabtArtifactProvider } from "./WabtArtifactProvider.js";
-import { PrivateRuntimeRoot } from "../process/PrivateRuntimeRoot.js";
+import {
+ PrivateRuntimeRoot,
+ PrivateRuntimeRootUnavailableError,
+} from "../process/PrivateRuntimeRoot.js";
import { spawnOwnedProviderProcess } from "../process/ProviderProcess.js";
import { OwnedCommandFailure } from "../process/OwnedCommand.js";
@@ -36,6 +39,41 @@ it("returns actionable unavailable without creating a workspace when tools are a
},
});
});
+
+it("reports an unavailable private runtime root without a misleading WABT remediation", async () => {
+ const toolRoot = await createTestTempDirectory("rea-wabt-tool-root-");
+ for (const tool of ["wasm-validate", "wasm-objdump", "wasm2wat"])
+ await writeFile(
+ join(toolRoot, tool + (process.platform === "win32" ? ".exe" : "")),
+ "source-owned executable seam",
+ { mode: 0o700 },
+ );
+ const provider = new WabtArtifactProvider(
+ { REA_WABT_BIN_DIRECTORY: toolRoot },
+ undefined,
+ () => {
+ throw new PrivateRuntimeRootUnavailableError(
+ "REA Windows native controls are unavailable: probe failure",
+ );
+ },
+ );
+ expect(
+ await provider.inspect({
+ path: "/module.wasm",
+ glue_paths: [],
+ candidate_paths: [],
+ }),
+ ).toMatchObject({
+ ok: false,
+ error: {
+ _tag: "AnalysisCapabilityUnavailableError",
+ userMessage: undefined,
+ message: expect.stringContaining(
+ "REA Windows native controls are unavailable",
+ ),
+ },
+ });
+});
it.each([
"success",
"invalid",
diff --git a/src/wasm/WabtFailures.ts b/src/wasm/WabtFailures.ts
index 520fa9ed3..ef5692f1b 100644
--- a/src/wasm/WabtFailures.ts
+++ b/src/wasm/WabtFailures.ts
@@ -11,6 +11,7 @@ import {
} from "../domain/analysisErrorCore.js";
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
import { OwnedCommandFailure } from "../process/OwnedCommand.js";
+import { PrivateRuntimeRootUnavailableError } from "../process/PrivateRuntimeRoot.js";
import { WABT_LIMITS, WABT_PROVIDER_IDENTITY } from "./WabtRelease.js";
/** Preserve lifecycle failures and diagnostic bytes instead of returning partial success. */
export const wabtFailure = (
@@ -70,6 +71,13 @@ export const wabtFailure = (
);
return new AnalysisOutputError("inspect_wasm_artifact", reason, options);
}
+ if (cause instanceof PrivateRuntimeRootUnavailableError)
+ return new AnalysisCapabilityUnavailableError(
+ WABT_PROVIDER_IDENTITY.id,
+ "inspect_wasm_artifact",
+ reason,
+ { cause },
+ );
if (phase === "configuration")
return new AnalysisCapabilityUnavailableError(
WABT_PROVIDER_IDENTITY.id,