Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

refactor(managed): return singular admitted evidence records

morlutofafc1881b590
diff --git a/src/domain/comparisonEvidenceIdentity.ts b/src/domain/comparisonEvidenceIdentity.ts
index cb9fd7fc6..61d05660a 100644
--- a/src/domain/comparisonEvidenceIdentity.ts
+++ b/src/domain/comparisonEvidenceIdentity.ts
@@ -33,8 +33,7 @@ const COMPARISON_EVIDENCE_IDENTITIES = {
},
} as const;
-type ComparisonEvidenceOperation =
- keyof typeof COMPARISON_EVIDENCE_IDENTITIES;
+type ComparisonEvidenceOperation = keyof typeof COMPARISON_EVIDENCE_IDENTITIES;
/** Whether an operation is one of the comparison workflows this domain owns. */
export const isComparisonEvidenceOperation = (
@@ -43,9 +42,7 @@ export const isComparisonEvidenceOperation = (
Object.hasOwn(COMPARISON_EVIDENCE_IDENTITIES, operation);
/** Check shared Evidence identity without imposing a consumer's link policy. */
-export const hasComparisonEvidenceIdentity = (
- evidence: Evidence,
-): boolean => {
+export const hasComparisonEvidenceIdentity = (evidence: Evidence): boolean => {
if (!isComparisonEvidenceOperation(evidence.operation)) return false;
const expected = COMPARISON_EVIDENCE_IDENTITIES[evidence.operation];
const providerMatches =
diff --git a/src/server/registerManagedWorkflowTools/compareManagedMembers.ts b/src/server/registerManagedWorkflowTools/compareManagedMembers.ts
index 6313211c4..90251146b 100644
--- a/src/server/registerManagedWorkflowTools/compareManagedMembers.ts
+++ b/src/server/registerManagedWorkflowTools/compareManagedMembers.ts
@@ -40,12 +40,8 @@ export const registerCompareManagedMembers = (
rightResolved,
compareContract,
);
- const [left] = leftResolved.value;
- const [right] = rightResolved.value;
- if (left === undefined || right === undefined)
- throw new TypeError(
- "Managed comparison Evidence resolution failed",
- );
+ const left = leftResolved.value;
+ const right = rightResolved.value;
const parsed = { left, right };
const result = await logToolExecution(
options.logger,
diff --git a/src/server/registerManagedWorkflowTools/evidence.ts b/src/server/registerManagedWorkflowTools/evidence.ts
index ea266428f..761f345eb 100644
--- a/src/server/registerManagedWorkflowTools/evidence.ts
+++ b/src/server/registerManagedWorkflowTools/evidence.ts
@@ -4,26 +4,12 @@ import { EvidenceIntegrityError } from "../../domain/evidenceErrors.js";
import type { Result } from "../../domain/result.js";
import { err, ok } from "../../domain/result.js";
-/**
- * Authenticate caller-supplied records. When `expectedOperations` is omitted,
- * the shared workflow owns which authentic operations it can use.
- */
-const parseExpectedEvidence = (
- rawEvidence: readonly Evidence[],
- expectedOperations?: readonly string[],
-): Result<Evidence[], EvidenceIntegrityError> => {
+/** Authenticate one caller-supplied record and preserve Evidence errors. */
+const parseEvidenceRecord = (
+ rawEvidence: Evidence,
+): Result<Evidence, EvidenceIntegrityError> => {
try {
- const evidence = rawEvidence.map(parseEvidence);
- if (expectedOperations !== undefined)
- for (const record of evidence)
- if (
- !expectedOperations.includes(record.operation) ||
- record.predicate_type !== "rea.analysis"
- )
- throw new TypeError(
- `Expected ${expectedOperations.join(" or ")} Evidence, received ${record.operation}`,
- );
- return ok(evidence);
+ return ok(parseEvidence(rawEvidence));
} catch (cause: unknown) {
return err(
new EvidenceIntegrityError(
@@ -33,20 +19,50 @@ const parseExpectedEvidence = (
}
};
+const parseEvidenceRecords = (
+ rawEvidence: readonly Evidence[],
+): Result<Evidence[], EvidenceIntegrityError> => {
+ const evidence: Evidence[] = [];
+ for (const rawRecord of rawEvidence) {
+ const record = parseEvidenceRecord(rawRecord);
+ if (!record.ok) return err(record.error);
+ evidence.push(record.value);
+ }
+ return ok(evidence);
+};
+
+const resolveExpectedEvidence = (
+ rawEvidence: Evidence,
+ expectedOperation: string,
+): Result<Evidence, EvidenceIntegrityError> => {
+ const evidence = parseEvidenceRecord(rawEvidence);
+ if (!evidence.ok) return evidence;
+ if (
+ evidence.value.operation !== expectedOperation ||
+ evidence.value.predicate_type !== "rea.analysis"
+ )
+ return err(
+ new EvidenceIntegrityError(
+ `Expected ${expectedOperation} Evidence, received ${evidence.value.operation}`,
+ ),
+ );
+ return evidence;
+};
+
export const resolveManagedEvidence = (
evidence: Evidence,
-): Result<Evidence[], EvidenceIntegrityError> =>
- parseExpectedEvidence([evidence], ["inspect_managed_members"]);
+): Result<Evidence, EvidenceIntegrityError> =>
+ resolveExpectedEvidence(evidence, "inspect_managed_members");
export const resolveManagedArtifactEvidence = (
evidence: Evidence,
-): Result<Evidence[], EvidenceIntegrityError> =>
- parseExpectedEvidence([evidence], ["inspect_managed_artifact"]);
+): Result<Evidence, EvidenceIntegrityError> =>
+ resolveExpectedEvidence(evidence, "inspect_managed_artifact");
export const resolveManagedBoundaryEvidence = (
evidence: Evidence,
-): Result<Evidence[], EvidenceIntegrityError> =>
- parseExpectedEvidence([evidence], ["inspect_managed_native_boundaries"]);
+): Result<Evidence, EvidenceIntegrityError> =>
+ resolveExpectedEvidence(evidence, "inspect_managed_native_boundaries");
/**
* Authenticate native observations without an operation allowlist: the domain
@@ -54,8 +70,7 @@ export const resolveManagedBoundaryEvidence = (
*/
export const resolveNativeEvidence = (
evidence: readonly Evidence[],
-): Result<Evidence[], EvidenceIntegrityError> =>
- parseExpectedEvidence(evidence);
+): Result<Evidence[], EvidenceIntegrityError> => parseEvidenceRecords(evidence);
export const sourceEvidence = (input: {
readonly managed_artifact?: Evidence | undefined;
diff --git a/src/server/registerManagedWorkflowTools/importManagedReconstruction.ts b/src/server/registerManagedWorkflowTools/importManagedReconstruction.ts
index 0381164fb..48a694ccc 100644
--- a/src/server/registerManagedWorkflowTools/importManagedReconstruction.ts
+++ b/src/server/registerManagedWorkflowTools/importManagedReconstruction.ts
@@ -33,11 +33,7 @@ export const registerImportManagedReconstruction = (
resolved,
reconstructionContract,
);
- const staticMembers = resolved.value[0];
- if (staticMembers === undefined)
- throw new TypeError(
- "Managed reconstruction Evidence resolution failed",
- );
+ const staticMembers = resolved.value;
const parsed = { ...input, static_members: staticMembers };
const result = await logToolExecution(
options.logger,
diff --git a/src/server/registerManagedWorkflowTools/projectManagedApplicationGraph.ts b/src/server/registerManagedWorkflowTools/projectManagedApplicationGraph.ts
index 10b850cfc..478f08d87 100644
--- a/src/server/registerManagedWorkflowTools/projectManagedApplicationGraph.ts
+++ b/src/server/registerManagedWorkflowTools/projectManagedApplicationGraph.ts
@@ -61,9 +61,9 @@ export const registerProjectManagedApplicationGraph = (
graphContract,
);
const parsed = {
- managed_artifact: managedArtifact?.value[0],
- managed_members: managedMembers?.value[0],
- managed_native_boundaries: managedBoundaries?.value[0],
+ managed_artifact: managedArtifact?.value,
+ managed_members: managedMembers?.value,
+ managed_native_boundaries: managedBoundaries?.value,
};
const result = await logToolExecution(
options.logger,
diff --git a/src/server/registerManagedWorkflowTools/verifyManagedNativeBoundaries.ts b/src/server/registerManagedWorkflowTools/verifyManagedNativeBoundaries.ts
index 5bea7f952..c51f5f0a0 100644
--- a/src/server/registerManagedWorkflowTools/verifyManagedNativeBoundaries.ts
+++ b/src/server/registerManagedWorkflowTools/verifyManagedNativeBoundaries.ts
@@ -49,9 +49,7 @@ export const registerVerifyManagedNativeBoundaries = (
nativeObservations,
nativeVerificationContract,
);
- const managedBoundary = managedBoundaries.value[0];
- if (managedBoundary === undefined)
- throw new TypeError("Managed boundary Evidence resolution failed");
+ const managedBoundary = managedBoundaries.value;
const parsed = {
...input,
managed_boundaries: managedBoundary,