Skip to content

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!

fix: keep marketing controls usable with a root resume

Amruth Pillai161dd3441679
diff --git a/apps/web/src/features/homepage/footer.tsx b/apps/web/src/features/homepage/footer.tsx
index 42697b735..763b979c8 100644
--- a/apps/web/src/features/homepage/footer.tsx
+++ b/apps/web/src/features/homepage/footer.tsx
@@ -26,7 +26,7 @@ const getColumns = (story: boolean): { id: string; title: string; links: FooterL
title: t`Product`,
links: [
{ label: t`Templates`, to: "/resume-templates" },
- { label: t`Features`, href: story ? "#write" : "/#write" },
+ { label: t`Features`, href: story ? "#write" : "https://rxresu.me/#write" },
{ label: t`ATS checker`, to: "/ats-checker" },
{ label: t`Get started`, to: "/auth/register" },
{ label: t`Sign in`, to: "/auth/login" },
diff --git a/apps/web/src/features/homepage/sections.tsx b/apps/web/src/features/homepage/sections.tsx
index 0c8569e47..ee5771cf7 100644
--- a/apps/web/src/features/homepage/sections.tsx
+++ b/apps/web/src/features/homepage/sections.tsx
@@ -11,6 +11,7 @@ import { cn } from "@reactive-resume/utils/style";
import { prefersReducedMotion, SCENE, useLanding } from "./scroll";
import { CtaLink, SignInLink, Doodle, labelClass } from "./ui";
import { RollingNumber } from "@/components/ui/rolling-number";
+import { LocaleCombobox } from "@/features/locale/combobox";
import { localeMap } from "@/libs/locale";
import { orpc } from "@/libs/orpc/client";
@@ -197,20 +198,37 @@ function languageHref(locale: string) {
type LanguageDoorwayProps = { className?: string; nameClassName?: string; story?: boolean };
-/** The current language, in its own name, leading to the Languages scene: the header's and the footer's way there. */
+/** Home uses its Languages scene; standalone pages can change language even when a resume replaces the home. */
export function LanguageDoorway({ className, nameClassName, story = true }: LanguageDoorwayProps) {
const { i18n } = useLingui();
const name = getLanguageName(i18n.locale, i18n.locale, false);
- return (
- <a
- href={story ? "#languages" : `/?locale=${i18n.locale}#languages`}
- title={t`Change language`}
- className={cn("flex items-center", className)}
- >
+ const content = (
+ <>
<Icon name="translate" size={16} />
<span lang={i18n.locale} className={nameClassName}>
{name}
</span>
+ </>
+ );
+ if (!story)
+ return (
+ <LocaleCombobox
+ render={(props) => (
+ <button
+ {...props}
+ type="button"
+ aria-label={t`Change language`}
+ title={t`Change language`}
+ className={cn("touch-target relative flex items-center", props.className, className)}
+ >
+ {content}
+ </button>
+ )}
+ />
+ );
+ return (
+ <a href="#languages" title={t`Change language`} className={cn("flex items-center", className)}>
+ {content}
</a>
);
}
diff --git a/docs/guides/choosing-a-template.mdx b/docs/guides/choosing-a-template.mdx
index 02c87720e..0d7f9b981 100644
--- a/docs/guides/choosing-a-template.mdx
+++ b/docs/guides/choosing-a-template.mdx
@@ -5,11 +5,11 @@ description: "Browse the 18 Reactive Resume templates drawn with your own conten
[Browse the free resume template gallery](https://rxresu.me/resume-templates) to compare all 18 layouts and download sample PDFs before creating an account. Select **Use this template** on one to sign up (or sign in) and start a blank resume in it.
-The public gallery keeps **Sign in** and **Build your resume** in the header, including on phones. When you're signed in, the header offers **Go to dashboard**. The hanging bulb changes the theme, and the language link opens the homepage's language list. Footer links lead to features, guides and the community.
+The public gallery keeps **Sign in** and **Build your resume** in the header, including on phones. When you're signed in, the header offers **Go to dashboard**. The hanging bulb changes the theme, and the language control changes the gallery's language. Footer links lead to the product homepage's features, guides and the community.
<Frame caption="Compare sample layouts in the public gallery before creating an account">
<img
- src="/images/guides/choosing-a-template/public-gallery.png"
+ src="/images/guides/choosing-a-template/public-gallery.jpg"
alt="Public template gallery with Sign in, Build your resume, the theme cord, layout advice and fictional sample resumes"
/>
</Frame>
diff --git a/docs/guides/using-the-ats-checker.mdx b/docs/guides/using-the-ats-checker.mdx
index ca5c7d5ad..abcf57a87 100644
--- a/docs/guides/using-the-ats-checker.mdx
+++ b/docs/guides/using-the-ats-checker.mdx
@@ -9,7 +9,7 @@ The ATS checker answers one question: can software read your resume? It opens a
The check runs entirely in your browser. The file isn't uploaded or stored, and you don't need an account.
-The header keeps **Sign in** and **Build your resume** available on phones too; signed-in visitors get **Go to dashboard**. Use the hanging bulb to change the theme, or the language link to open the homepage's language list. The footer shares the homepage's feature, documentation and community links.
+The header keeps **Sign in** and **Build your resume** available on phones too; signed-in visitors get **Go to dashboard**. Use the hanging bulb to change the theme, or the language control to choose the checker's language. The footer links to the product homepage's features, documentation and community.
## Before you start
@@ -29,7 +29,7 @@ The header keeps **Sign in** and **Build your resume** available on phones too;
Drag the file onto the box, or select **Choose a PDF** to pick it. To see how the checker works first, select **Try a sample file**.
<Frame caption="Check a PDF locally in your browser">
- <img src="/images/guides/using-the-ats-checker/drop-zone-and-posting.png" alt="Public ATS checker with Sign in, Build your resume, the theme cord, Choose a PDF, Try a sample file and optional Job posting" />
+ <img src="/images/guides/using-the-ats-checker/drop-zone-and-posting.jpg" alt="Public ATS checker with Sign in, Build your resume, the theme cord, Choose a PDF, Try a sample file and optional Job posting" />
</Frame>
</Step>
diff --git a/docs/images/guides/choosing-a-template/public-gallery.jpg b/docs/images/guides/choosing-a-template/public-gallery.jpg
new file mode 100644
index 000000000..84793d4dc
Binary files /dev/null and b/docs/images/guides/choosing-a-template/public-gallery.jpg differ
diff --git a/docs/images/guides/choosing-a-template/public-gallery.png b/docs/images/guides/choosing-a-template/public-gallery.png
deleted file mode 100644
index d6f06bcb3..000000000
Binary files a/docs/images/guides/choosing-a-template/public-gallery.png and /dev/null differ
diff --git a/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.jpg b/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.jpg
new file mode 100644
index 000000000..cb0a9d7de
Binary files /dev/null and b/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.jpg differ
diff --git a/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.png b/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.png
deleted file mode 100644
index 00bd7e32f..000000000
Binary files a/docs/images/guides/using-the-ats-checker/drop-zone-and-posting.png and /dev/null differ
diff --git a/tests/e2e/specs/marketing-navigation.spec.ts b/tests/e2e/specs/marketing-navigation.spec.ts
index 35b4c9697..b4d54ce0b 100644
--- a/tests/e2e/specs/marketing-navigation.spec.ts
+++ b/tests/e2e/specs/marketing-navigation.spec.ts
@@ -21,7 +21,7 @@ for (const path of ["/resume-templates", "/ats-checker"]) {
await expect(start).toBeVisible();
await expect(header.locator("nav")).toHaveCount(0);
await expect(header.locator('a[href="/"]')).toHaveAccessibleName("Reactive Resume");
- const boxes = await header.locator("a").evaluateAll((links) =>
+ const boxes = await header.locator("a, button").evaluateAll((links) =>
links
.filter((link) => link.getBoundingClientRect().width > 0)
.map((link) => {
@@ -49,8 +49,9 @@ for (const path of ["/resume-templates", "/ats-checker"]) {
const footer = page.getByRole("contentinfo");
await footer.scrollIntoViewIfNeeded();
await expect(footer.getByRole("navigation")).toHaveCount(4);
- await expect(footer.locator('a[href="/#write"]')).toBeVisible();
- await expect(footer.locator(`a[href="/?locale=${locale}#languages"]`)).toBeVisible();
+ await expect(footer.locator('a[href="https://rxresu.me/#write"]')).toBeVisible();
+ await expect(footer.locator("button[title]")).toBeVisible();
+ await expect(footer.locator("button[title]")).toHaveAccessibleName(/\S+/);
await expect(footer.locator('img[src*="footer-desk"]')).toHaveCount(0);
await expect(header).toBeInViewport();
await expect(signIn).toBeInViewport();
@@ -66,7 +67,7 @@ for (const path of ["/resume-templates", "/ats-checker"]) {
expect(html).toContain('href="/auth/login"');
expect(html).toContain('href="/auth/register"');
expect(html).toContain("<footer");
- expect(html).toContain('href="/#write"');
+ expect(html).toContain('href="https://rxresu.me/#write"');
expect(html).not.toContain('href="/dashboard"');
await page.goto(path);
await expect(page.getByRole("heading", { level: 1 })).toBeFocused();
@@ -77,22 +78,25 @@ for (const path of ["/resume-templates", "/ats-checker"]) {
});
}
-test("marketing theme, language and footer links reach their existing destinations", async ({ page }) => {
+test("marketing theme and language persist while footer links name their destinations", async ({ page }) => {
await page.goto("/ats-checker");
await expect(page.getByRole("heading", { level: 1 })).toBeFocused();
await page.getByRole("button", { name: "Switch to dark mode", exact: true }).click();
await expect(page.locator("html")).toHaveClass(/dark/);
await page.reload();
await expect(page.locator("html")).toHaveClass(/dark/);
- await page.getByRole("contentinfo").getByRole("link", { name: "Features", exact: true }).click();
- await expect(page).toHaveURL(/\/#write$/);
- await expect(page.locator("#write")).toBeInViewport();
+ await expect(page.getByRole("contentinfo").getByRole("link", { name: "Features", exact: true })).toHaveAttribute(
+ "href",
+ "https://rxresu.me/#write",
+ );
await page.goto("/resume-templates?locale=de-DE");
await expect(page.getByRole("heading", { level: 1 })).toBeFocused();
- await page.getByRole("banner").locator('a[href="/?locale=de-DE#languages"]').click();
- await expect(page).toHaveURL(/\/\?locale=de-DE#languages$/);
- await expect(page.locator("html")).toHaveAttribute("lang", "de-DE");
- await expect(page.locator("#languages")).toBeInViewport();
+ await page.getByRole("banner").locator("button[title]").click();
+ await page.getByRole("option", { name: /American English/ }).click();
+ await expect(page.locator("html")).toHaveAttribute("lang", "en-US");
+ expect(new URL(page.url()).pathname).toBe("/resume-templates");
+ await page.reload();
+ await expect(page.locator("html")).toHaveAttribute("lang", "en-US");
});
test("marketing account actions remain keyboard destinations on phones", async ({ page }) => {