Skip to content

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!

Preserve independent letter sender during style refresh (#3730)

Amruth Pillai4e448207bfc7
diff --git a/packages/api/src/features/cover-letters/service.integration.test.ts b/packages/api/src/features/cover-letters/service.integration.test.ts
index aa5e8413c..4ee7ce518 100644
--- a/packages/api/src/features/cover-letters/service.integration.test.ts
+++ b/packages/api/src/features/cover-letters/service.integration.test.ts
@@ -464,6 +464,56 @@ describe.skipIf(!process.env.COVER_LETTER_TEST_DATABASE_URL)("cover-letter owned
).toBe("Still editable");
});
+ it.each([false, true])("refreshes design while respecting sender linking (%s)", async (senderLinked) => {
+ const { coverLettersRouter } = await import("./router");
+ const client = createRouterClient(coverLettersRouter, { context: { user: { id: "alice" } } as never });
+ const source = structuredClone(defaultResumeData);
+ source.basics.name = "Original sender";
+ source.picture.url = "https://example.test/original.png";
+ await getPool().query("UPDATE resume SET data=$1 WHERE id='alice-resume'", [source]);
+ const created = await client.create({
+ name: "Refresh design",
+ resumeId: "alice-resume",
+ template: "pikachu",
+ content: "<p>Keep this letter</p>",
+ });
+ const letter = senderLinked
+ ? created
+ : await client.update({
+ id: created.id,
+ expectedRevision: created.revision,
+ senderLinked: false,
+ sender: {
+ name: "Independent sender",
+ email: "[email protected]",
+ phone: "+49 30 5550100",
+ location: "Berlin",
+ },
+ });
+ source.basics.name = "Current resume sender";
+ source.basics.email = "[email protected]";
+ source.picture.url = "https://example.test/current.png";
+ source.metadata.page.marginX = 22;
+ await getPool().query("UPDATE resume SET data=$1 WHERE id='alice-resume'", [source]);
+
+ const refreshed = await client.refreshStyle({
+ id: letter.id,
+ expectedRevision: letter.revision,
+ resumeId: "alice-resume",
+ });
+ const basics = senderLinked ? source.basics : letter.style.basics;
+ const picture = senderLinked ? source.picture : letter.style.picture;
+ expect(refreshed).toMatchObject({
+ content: "<p>Keep this letter</p>",
+ senderLinked,
+ style: { basics, picture, metadata: { template: "pikachu", page: { marginX: 22 } } },
+ });
+ expect((await client.getById({ id: letter.id })).style).toMatchObject({ basics, picture });
+ expect((await client.export({ id: letter.id })).style).toMatchObject({ basics, picture });
+ await getPool().query("DELETE FROM resume WHERE id='alice-resume'");
+ expect((await client.getById({ id: letter.id })).style).toMatchObject({ basics, picture });
+ });
+
it("edits standalone sender details and isolates copies, links and account ownership", async () => {
const { coverLettersRouter } = await import("./router");
const client = createRouterClient(coverLettersRouter, { context: { user: { id: "alice" } } as never });
diff --git a/packages/api/src/features/cover-letters/service.ts b/packages/api/src/features/cover-letters/service.ts
index fb0959537..d2663dc37 100644
--- a/packages/api/src/features/cover-letters/service.ts
+++ b/packages/api/src/features/cover-letters/service.ts
@@ -391,6 +391,10 @@ export const coverLetterService = {
refreshStyle: async (input: RevisionInput & { resumeId: string }) => {
const letter = await getById(input);
const style = await getResumeStyle(input.userId, input.resumeId, letter.style.sectionId, letter.style.itemId);
+ if (!letter.senderLinked) {
+ style.basics = letter.style.basics;
+ style.picture = letter.style.picture;
+ }
style.metadata.template = letter.style.metadata.template;
return resolveLinks(await updateRevision(input, { style, sourceResumeId: input.resumeId }), input.userId);
},