Skip to content

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!

fix: keep tablet titles readable beside issue counts

Amruth Pillai52699c63ad60
diff --git a/apps/web/src/features/resume/editor/chrome/bar.tsx b/apps/web/src/features/resume/editor/chrome/bar.tsx
index f7c5d40f1..99acbf54d 100644
--- a/apps/web/src/features/resume/editor/chrome/bar.tsx
+++ b/apps/web/src/features/resume/editor/chrome/bar.tsx
@@ -35,7 +35,9 @@ export function EditorBarFrame({ layout, pinnable, menu, modes, history, childre
<header
className={cn(
"grid h-(--editor-bar) items-center gap-3 border-b border-line bg-surface px-3",
- layout === "tablet" ? "grid-cols-[minmax(0,1fr)_auto_auto]" : "grid-cols-[minmax(0,1fr)_auto_minmax(0,1fr)]",
+ layout === "tablet"
+ ? "grid-cols-[minmax(0,1fr)_auto_auto] gap-2"
+ : "grid-cols-[minmax(0,1fr)_auto_minmax(0,1fr)]",
)}
>
<div className="flex min-w-0 items-center gap-1.5">
diff --git a/apps/web/src/features/resume/editor/write/rich-text-editor.test.tsx b/apps/web/src/features/resume/editor/write/rich-text-editor.test.tsx
index b7b982459..fcffc02db 100644
--- a/apps/web/src/features/resume/editor/write/rich-text-editor.test.tsx
+++ b/apps/web/src/features/resume/editor/write/rich-text-editor.test.tsx
@@ -43,8 +43,12 @@ it.each([false, true])(
await userEvent.keyboard("{Enter}");
expect(screen.getByRole("button", { name: "Italic" }).getAttribute("aria-pressed")).toBe("true");
await act(async () => {
- screen.getByRole("button", { name: "Outside" }).focus();
+ editor.focus();
});
+ await userEvent.tab();
+ expect(toolbar.contains(document.activeElement)).toBe(true);
+ await userEvent.tab();
+ expect(screen.getByRole("button", { name: "Outside" })).toHaveFocus();
expect(screen.queryByRole("toolbar")).toBeNull();
},
);
diff --git a/apps/web/src/routes/builder/$resumeId/-components/editor-bar.tsx b/apps/web/src/routes/builder/$resumeId/-components/editor-bar.tsx
index 9f1cdf476..88c33e9e3 100644
--- a/apps/web/src/routes/builder/$resumeId/-components/editor-bar.tsx
+++ b/apps/web/src/routes/builder/$resumeId/-components/editor-bar.tsx
@@ -106,7 +106,7 @@ function ModeTabs({ compact }: ModeTabsProps) {
<TabsTrigger
key={mode}
value={mode}
- className={compact ? "relative px-2.5" : "px-4"}
+ className={compact ? "px-2" : "px-4"}
aria-keyshortcuts={characterShortcuts ? String(index + 1) : undefined}
title={
characterShortcuts
diff --git a/tests/e2e/specs/deferred-accessibility.spec.ts b/tests/e2e/specs/deferred-accessibility.spec.ts
index 5f8b23de4..bff86a811 100644
--- a/tests/e2e/specs/deferred-accessibility.spec.ts
+++ b/tests/e2e/specs/deferred-accessibility.spec.ts
@@ -39,7 +39,9 @@ test("short landscape application header scrolls away while footer stays reachab
});
test("tablet mode icons leave space for the document title", async ({ authPage: page }, info) => {
- const created = await page.request.post("/api/openapi/resumes", { data: { name: "Untitled resume", tags: [] } });
+ const created = await page.request.post("/api/openapi/resumes", {
+ data: { name: "Untitled resume", tags: [], withSampleData: true },
+ });
await expect(created).toBeOK();
const id = await created.json();
for (const width of [640, 717, 820, 1023]) {
@@ -52,6 +54,11 @@ test("tablet mode icons leave space for the document title", async ({ authPage:
await expect(page.getByRole("tab", { name: /^Write/ })).toHaveAccessibleName(/Write/);
}
await page.setViewportSize({ width: 717, height: 1024 });
+ const show = page.getByRole("button", { name: "Show panel", exact: true });
+ if (await show.isVisible()) await show.click();
+ await expect(page.locator('[data-resume-preview-template][aria-hidden="false"] canvas').first()).toBeVisible();
+ await page.mouse.move(12, 60);
+ await expect(page.getByRole("tooltip")).toBeHidden();
await page.screenshot({ animations: "disabled", path: info.outputPath("tablet-title.png") });
});
@@ -78,6 +85,9 @@ test("tablet long titles truncate and three-digit Check badges keep their own sp
if (!icon || !count) throw new Error("Missing Check badge geometry");
expect(count.x).toBeGreaterThanOrEqual(icon.x + icon.width);
expect((await title.boundingBox())?.x).toBeGreaterThanOrEqual(0);
+ const titleBox = await title.boundingBox();
+ if (!titleBox) throw new Error("Missing title geometry");
+ expect(titleBox.x + titleBox.width).toBeLessThanOrEqual(640);
});
for (const width of [1440, 390]) {