A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!
TypeScript agent-skillsaidsh-pluginhacktoberfestjavascriptmcp-serverreactresume-builderself-hostedtypescript
fix(builder): center preview in RTL interfaces (#3446)
Amruth Pillai9fdcec2eca02
diff --git a/apps/web/src/routes/builder/$resumeId/-components/preview-page.tsx b/apps/web/src/routes/builder/$resumeId/-components/preview-page.tsxindex 0dbd57c3e..a68376b45 100644--- a/apps/web/src/routes/builder/$resumeId/-components/preview-page.tsx+++ b/apps/web/src/routes/builder/$resumeId/-components/preview-page.tsx@@ -32,7 +32,8 @@ export function PreviewPage() {wheel={{ step: 0.001 }}onPanningStart={blurFocusedElementOnPan}>- <TransformComponent wrapperClass="h-full! w-full!">+ {/* Zoom transforms use left-origin coordinates, regardless of the interface language. */}+ <TransformComponent wrapperClass="h-full! w-full!" wrapperProps={{ dir: "ltr" }}><ResumePreview showPageNumbers pageLayout={pageLayout} /></TransformComponent>diff --git a/tests/e2e/specs/preview-direction.spec.ts b/tests/e2e/specs/preview-direction.spec.tsnew file mode 100644index 000000000..3823ce0a4--- /dev/null+++ b/tests/e2e/specs/preview-direction.spec.ts@@ -0,0 +1,77 @@+import type { Page } from "@playwright/test";+import { Pool } from "pg";+import { expect, test } from "../fixtures/test";++async function expectCenteredPreview(page: Page) {+ const canvas = page.locator('[aria-hidden="false"] canvas').first();+ await expect(canvas).toBeVisible();+ await expect+ .poll(async () => {+ const bounds = await canvas.boundingBox();+ if (!bounds) return Number.POSITIVE_INFINITY;+ return Math.abs(bounds.x + bounds.width / 2 - (page.viewportSize()?.width ?? 0) / 2);+ })+ .toBeLessThan(1);+}++for (const uiLanguage of ["English", "Arabic"]) {+ for (const resumeLocale of ["en-US", "ar-SA"]) {+ test(`centers preview with ${uiLanguage} UI and ${resumeLocale} resume`, async ({ authPage: page }, info) => {+ test.setTimeout(60_000);+ await page.setViewportSize({ width: 1920, height: 950 });+ await page.goto("/dashboard/resumes");+ await page.getByText("Create a new resume", { exact: true }).click();+ const dialog = page.getByRole("dialog", { name: "Create a new resume" });+ await dialog.getByLabel("Name", { exact: true }).fill("Preview direction fixture");+ await dialog.getByRole("button", { name: "Create", exact: true }).click();+ await page.waitForURL(/\/builder\/.+/);+ const builderUrl = page.url();+ const resumeId = builderUrl.split("/").at(-1);+ await page.goto("/dashboard/resumes");+ const pool = new Pool({ connectionString: process.env.DATABASE_URL });+ try {+ await pool.query(+ `update resume set data = jsonb_set(jsonb_set(data, '{metadata,page,locale}', $2::jsonb), '{basics,name}', '"Preview direction fixture"'::jsonb) where id = $1`,+ [resumeId, JSON.stringify(resumeLocale)],+ );+ } finally {+ await pool.end();+ }+ await page.goto(builderUrl);+ if (uiLanguage === "Arabic") {+ await page.getByRole("button", { name: "Account menu", exact: true }).click();+ await page.getByRole("menuitem", { name: "Language", exact: true }).click();+ await page.getByRole("menuitemradio", { name: "Arabic", exact: true }).click();+ await expect(page.locator("html")).toHaveAttribute("dir", "rtl");+ await page.reload();+ }+ await expectCenteredPreview(page);+ const zoom = page.getByRole("button", {+ name: uiLanguage === "Arabic" ? "مستوى التكبير" : "Zoom level",+ exact: true,+ });+ await expect(zoom).toHaveCSS("direction", uiLanguage === "Arabic" ? "rtl" : "ltr");+ await zoom.click();+ await page+ .getByRole("menuitem", {+ name: uiLanguage === "Arabic" ? "الحجم الفعلي (100%)" : "Actual size (100%)",+ exact: true,+ })+ .click();+ await expect(zoom).toHaveText("100%");+ await expectCenteredPreview(page);+ await zoom.click();+ await page+ .getByRole("menuitem", { name: uiLanguage === "Arabic" ? "مناسب للعرض" : "Fit to view", exact: true })+ .click();+ await expect(zoom).toHaveText("75%");+ await expectCenteredPreview(page);+ const direction = await page+ .locator('[aria-hidden="false"] canvas')+ .first()+ .evaluate((canvas) => canvas.closest("[dir]")?.getAttribute("dir"));+ expect(direction).toBe(resumeLocale === "ar-SA" ? "rtl" : "ltr");+ await page.screenshot({ path: info.outputPath("centered-preview.png") });+ });+ }+}