A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!
TypeScript agent-skillsaidsh-pluginhacktoberfestjavascriptmcp-serverreactresume-builderself-hostedtypescript
fix(pdf): bump @formepdf to 0.28.0, fixing mid-word wraps in item headers (#3588)
Santhi Prakasha033d00a9137
diff --git a/apps/server/package.json b/apps/server/package.jsonindex 4219368d1..12137476c 100644--- a/apps/server/package.json+++ b/apps/server/package.json@@ -35,8 +35,8 @@"@better-auth/oauth-provider": "catalog:","@better-auth/passkey": "catalog:","@bramus/specificity": "^2.4.2",- "@formepdf/core": "0.27.0",- "@formepdf/react": "0.27.0",+ "@formepdf/core": "0.28.0",+ "@formepdf/react": "0.28.0","@hono/node-server": "^2.1.3","@modelcontextprotocol/sdk": "^1.32.0","@orpc/client": "catalog:",diff --git a/packages/pdf/package.json b/packages/pdf/package.jsonindex 12d96b969..47b27f47b 100644--- a/packages/pdf/package.json+++ b/packages/pdf/package.json@@ -25,8 +25,8 @@"test:agent": "vitest run --reporter=agent --reporter=json --outputFile.json=reports/vitest-results.json --passWithNoTests"},"dependencies": {- "@formepdf/core": "0.27.0",- "@formepdf/react": "0.27.0",+ "@formepdf/core": "0.28.0",+ "@formepdf/react": "0.28.0","@reactive-resume/fonts": "workspace:*","@reactive-resume/resume": "workspace:*","@reactive-resume/schema": "workspace:*",diff --git a/packages/pdf/src/location-wrap.integration.test.tsx b/packages/pdf/src/location-wrap.integration.test.tsxnew file mode 100644index 000000000..18c13cb5a--- /dev/null+++ b/packages/pdf/src/location-wrap.integration.test.tsx@@ -0,0 +1,87 @@+import type { SectionTitleResolver } from "./section-title";+import type { ElementInfo } from "@formepdf/core";+import type { ResumeData } from "@reactive-resume/schema/resume/data";+import type { Template } from "@reactive-resume/schema/templates";+import { describe, expect, it } from "vitest";+import * as forme from "@formepdf/core";+import { defaultResumeData } from "@reactive-resume/schema/resume/default";+import { templateSchema } from "@reactive-resume/schema/templates";+import { renderResume } from "./forme/render";++const resolveSectionTitle: SectionTitleResolver = (input) => input.defaultEnglishTitle ?? input.sectionId;++/**+ * Issue #3586: the work-experience location wrapped mid-word ("Mumbai" rendered as+ * "Mumba"/"i", "Mumbai," as "Mumbai"/",") after the Forme v6 renderer landed. The trailing+ * header text goes into a row item measured by the engine; a nested inline run makes the line+ * breaker fall back to character breaks when the measured box is a hair under the shaped width.+ */++const buildData = (location: string): ResumeData => {+ const data = structuredClone(defaultResumeData);+ data.picture.hidden = true;+ data.sections.experience.items = [+ {+ id: "experience/1",+ hidden: false,+ company: "Acme",+ position: "Engineer",+ location,+ period: "Jan 2024 - Mar 2025",+ website: { url: "", label: "", inlineLink: false },+ description: "",+ roles: [],+ },+ ];+ const page = data.metadata.layout.pages[0];+ if (!page) throw new Error("Missing authored page");+ page.main = ["experience"];+ page.sidebar = [];+ return data;+};++const textBlocks = (node: ElementInfo, out: ElementInfo[] = []): ElementInfo[] => {+ if (node.nodeType === "Text") out.push(node);+ node.children.forEach((child) => textBlocks(child, out));+ return out;+};++const linesOf = (block: ElementInfo): string[] =>+ block.children.filter((line) => line.nodeType === "TextLine").map((line) => line.textContent ?? "");++/** Every laid-out text block whose lines reassemble into the location token, as line arrays. */+const tokenBlocks = (layout: Awaited<ReturnType<typeof renderResume>>["layout"], token: string): string[][] =>+ layout.pages+ .flatMap((page) => page.elements.flatMap((element) => textBlocks(element)))+ .map(linesOf)+ .filter((lines) => lines.join("").includes(token));++const expectSingleLine = (layout: Awaited<ReturnType<typeof renderResume>>["layout"], token: string) => {+ const blocks = tokenBlocks(layout, token);+ expect(blocks).not.toEqual([]);+ for (const lines of blocks) {+ // The whole token appears on one line, with no mid-word fragment on another.+ expect(lines.some((line) => line.includes(token))).toBe(true);+ expect(lines.filter((line) => line !== "" && line !== token && token.includes(line))).toEqual([]);+ }+};++describe("experience location wrapping (#3586)", () => {+ it.each(templateSchema.options)("keeps the whole location on one line in %s", async (template) => {+ const { layout } = await renderResume(forme, {+ data: buildData("Mumbai"),+ template: template as Template,+ resolveSectionTitle,+ });+ expectSingleLine(layout, "Mumbai");+ });++ it.each(templateSchema.options)("keeps a trailing comma on the same line in %s", async (template) => {+ const { layout } = await renderResume(forme, {+ data: buildData("Mumbai,"),+ template: template as Template,+ resolveSectionTitle,+ });+ expectSingleLine(layout, "Mumbai,");+ });+});diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex 4e39a9c32..c89d9e1db 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -394,11 +394,11 @@ importers:specifier: ^2.4.2version: 2.4.2'@formepdf/core':- specifier: 0.27.0- version: 0.27.0([email protected])+ specifier: 0.28.0+ version: 0.28.0([email protected])'@formepdf/react':- specifier: 0.27.0- version: 0.27.0([email protected])+ specifier: 0.28.0+ version: 0.28.0([email protected])'@hono/node-server':specifier: ^2.1.3version: 2.1.3([email protected])@@ -1365,11 +1365,11 @@ importers:packages/pdf:dependencies:'@formepdf/core':- specifier: 0.27.0- version: 0.27.0([email protected])+ specifier: 0.28.0+ version: 0.28.0([email protected])'@formepdf/react':- specifier: 0.27.0- version: 0.27.0([email protected])+ specifier: 0.28.0+ version: 0.28.0([email protected])'@reactive-resume/fonts':specifier: workspace:*version: link:../fonts@@ -2866,18 +2866,18 @@ packages:'@fontsource-variable/[email protected]':resolution: {integrity: sha512-rrzYi43qMpbzwuFtf9OkWH8sxAPVPcQQQEwXpPtwaKYeJ8yVg5aLs5kawmo1f2Q1t1M38TLmEKCkGVDsYwgdFw==}- '@formepdf/[email protected]':- resolution: {integrity: sha512-FjeJKTwKMevvJo9lmXH9ciRS/RiAWQ1ww5Ce7XB29FZgw44yuAwpCUzLF+kueMdtM/7Shf9VVk+jpSKzxlmpzQ==}+ '@formepdf/[email protected]':+ resolution: {integrity: sha512-0wJKPpCq15jPTNv82OG6zZeE6S2b2B5beIbkIrWQ5T8kOVNq5lAAsiO/+/42vunejgqPLA8H5pA4AQ+pcqLwLQ==}peerDependencies:react: ^18 || ^19- '@formepdf/[email protected]':- resolution: {integrity: sha512-S9IPzigmIjNDu/+Wwi9uV29iqu8YQUK4nnKOce4YUm+3zaKSORtTie7/47RZkfE5nFt3zqumzuq1A51l5tCAvQ==}+ '@formepdf/[email protected]':+ resolution: {integrity: sha512-mytvkfkMQ83h2rBm/f0HrQ3EBU675CvazOun+XWhBHxd54GTHE/XKDqiYZ3GgmHjNGYhjRqQClFPDoRXmaVS7w==}peerDependencies:react: ^18 || ^19- '@formepdf/[email protected]':- resolution: {integrity: sha512-1wgE/yogCAiRGit1Vt62DOjvmjStsYN5rzNVg7sdKQenTMVtQ+ssoO7UX7eRprJFA4Se8GfRo7M0acZy1rb1cw==}+ '@formepdf/[email protected]':+ resolution: {integrity: sha512-i9XsJFM07U3pMcdQRM5xHa98WamYf9U+S1UOeBxKWWPCGBpHWx94dAkzFsglGekHAXDiFDkDEFHSgvHHL91Q2w==}'@hexagon/[email protected]':resolution: {integrity: sha512-lhqDEAvWixy3bZ+UOYbPwUbBkwBq5C1LAJ/xPC8Oi+lL54oyakv/npbA0aU2hgCsx/1NUd4IBvV03+aUBWxerw==}@@ -10923,17 +10923,17 @@ snapshots:'@fontsource-variable/[email protected]': {}- '@formepdf/[email protected]([email protected])':+ '@formepdf/[email protected]([email protected])':dependencies:- '@formepdf/react': 0.27.0([email protected])+ '@formepdf/react': 0.28.0([email protected])react: 19.3.0- '@formepdf/[email protected]([email protected])':+ '@formepdf/[email protected]([email protected])':dependencies:- '@formepdf/shared': 0.27.0+ '@formepdf/shared': 0.28.0react: 19.3.0- '@formepdf/[email protected]':+ '@formepdf/[email protected]':dependencies:parse5: 7.3.0