Skip to content

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!

fix(pdf): render text symbols like ★ instead of failing every PDF (#3583)

Amruth Pillaifa3e4cbf471c
diff --git a/apps/web/src/features/resume/export/pdf-document.ts b/apps/web/src/features/resume/export/pdf-document.ts
index b54e3cb74..26f512b91 100644
--- a/apps/web/src/features/resume/export/pdf-document.ts
+++ b/apps/web/src/features/resume/export/pdf-document.ts
@@ -17,7 +17,8 @@ type RenderInput = { data: ResumeData; template?: Template | undefined; renderOp
export type PdfWorkerRequest = RenderInput & { id: number };
export type PdfWorkerResponse =
| { id: number; blob: Blob; pageMap: PageMap | undefined }
- | { id: number; error: string };
+ // `cause` survives the worker boundary so callers can still tell text loss apart (see `getReadableErrorMessage`).
+ | { id: number; error: string; cause: string | undefined };
type Rendered = { blob: Blob; pageMap: PageMap | undefined };
@@ -61,7 +62,7 @@ function getWorker(): Worker | null {
const request = pending.get(response.id);
if (!request) return;
pending.delete(response.id);
- if ("error" in response) request.reject(new Error(response.error));
+ if ("error" in response) request.reject(new Error(response.error, { cause: response.cause }));
else request.resolve({ blob: response.blob, pageMap: response.pageMap });
});
// Every render is caught inside the worker, so an error here means it couldn't start: render here instead.
diff --git a/apps/web/src/features/resume/export/pdf.worker.ts b/apps/web/src/features/resume/export/pdf.worker.ts
index 7e4923ed9..69b2ba16c 100644
--- a/apps/web/src/features/resume/export/pdf.worker.ts
+++ b/apps/web/src/features/resume/export/pdf.worker.ts
@@ -21,6 +21,11 @@ self.addEventListener("message", async ({ data: request }: MessageEvent<PdfWorke
});
self.postMessage({ id, blob, pageMap } satisfies PdfWorkerResponse);
} catch (error) {
- self.postMessage({ id, error: error instanceof Error ? error.message : String(error) } satisfies PdfWorkerResponse);
+ const cause = error instanceof Error && typeof error.cause === "string" ? error.cause : undefined;
+ self.postMessage({
+ id,
+ error: error instanceof Error ? error.message : String(error),
+ cause,
+ } satisfies PdfWorkerResponse);
}
});
diff --git a/apps/web/src/features/resume/preview/preview.browser.tsx b/apps/web/src/features/resume/preview/preview.browser.tsx
index be1fa0ba6..af9acdbf3 100644
--- a/apps/web/src/features/resume/preview/preview.browser.tsx
+++ b/apps/web/src/features/resume/preview/preview.browser.tsx
@@ -15,6 +15,7 @@ import { ResumePreviewLoader } from "./preview.shared";
import { getResumePreviewGapValue, getResumePreviewPageCount } from "./preview.shared.utils";
import { ResumeAccessibleText } from "./resume-accessible-text";
import { createResumePdfBlob } from "@/features/resume/export/pdf-document";
+import { getReadableErrorMessage } from "@/libs/error-message";
import { EASE } from "@/libs/motion";
type PreviewPdf = {
@@ -156,11 +157,16 @@ export function ResumePreviewClient({
hasPreviewRef.current = true;
setPreviewLayers((current) => addPreviewLayer(current, nextPdf));
}
- } catch {
+ } catch (error) {
if (stale()) return;
+ const fallback = t`The resume preview could not be updated. The last valid preview is still shown.`;
toast.add({
type: "error",
- description: t`The resume preview could not be updated. The last valid preview is still shown.`,
+ // Name the cause the user can fix (an unsupported character, a font that didn't load); keep other engine errors generic.
+ description:
+ error instanceof Error && error.cause === "pdf-text-loss"
+ ? getReadableErrorMessage(error, fallback)
+ : fallback,
id: "resume-preview-render-error",
});
}
diff --git a/packages/fonts/src/index.ts b/packages/fonts/src/index.ts
index c5ea8a21b..185b77f1e 100644
--- a/packages/fonts/src/index.ts
+++ b/packages/fonts/src/index.ts
@@ -85,6 +85,8 @@ const scriptFonts: Record<Script, { serif: string; sansSerif: string }> = {
// Monochrome outlines (TrueType glyf, not CBDT bitmaps) so react-pdf can
// embed them; the serif/sans distinction is meaningless for emoji (#3321).
emoji: { serif: "Noto Emoji", sansSerif: "Noto Emoji" },
+ // Text symbols (★, ☆, ●, ■, ◆, ✦, ✓) that aren't emoji (#3581).
+ symbols: { serif: "Noto Sans Symbols 2", sansSerif: "Noto Sans Symbols 2" },
};
// Covers General Punctuation (U+2000–U+206F) and other symbols missing from
diff --git a/packages/fonts/src/webfontlist.json b/packages/fonts/src/webfontlist.json
index f54480e97..067b3118a 100644
--- a/packages/fonts/src/webfontlist.json
+++ b/packages/fonts/src/webfontlist.json
@@ -5861,6 +5861,16 @@
"900": "https://fonts.gstatic.com/s/notosanssymbols/v47/rP2up3q65FkAtHfwd-eIS2brbDN6gxP34F9jRRCe4W3g1AggavVFRkzrbQ.ttf"
}
},
+ {
+ "type": "web",
+ "category": "sans-serif",
+ "family": "Noto Sans Symbols 2",
+ "weights": ["400"],
+ "preview": "https://fonts.gstatic.com/s/notosanssymbols2/v25/I_uyMoGduATTei9eI8daxVHDyfisHr71ypM.ttf",
+ "files": {
+ "400": "https://fonts.gstatic.com/s/notosanssymbols2/v25/I_uyMoGduATTei9eI8daxVHDyfisHr71ypM.ttf"
+ }
+ },
{
"type": "web",
"category": "sans-serif",
diff --git a/packages/pdf/src/forme/export-text.integration.test.ts b/packages/pdf/src/forme/export-text.integration.test.ts
index d41b174d7..dee37c7be 100644
--- a/packages/pdf/src/forme/export-text.integration.test.ts
+++ b/packages/pdf/src/forme/export-text.integration.test.ts
@@ -33,6 +33,7 @@ it.each([
["日本語の履歴書 職務経験", "Noto Sans JP", "ja-JP"],
["Hello 💻 engineer 🚀 coding 😀", "Noto Sans", "en-US"],
["Family 👨‍👩‍👧‍👦 love 👩‍❤️‍💋‍👩 ❤️", "Noto Sans", "en-US"],
+ ["LessPass 6.1k⭐★ rated ★★★☆☆", "IBM Plex Sans", "en-US"],
] as const)("preserves exported Unicode text: %s", { timeout: 60_000 }, async (text, font, locale) => {
expect(await exportText(`<p>${text}</p>`, font, locale)).toContain(text);
});
diff --git a/packages/pdf/src/hooks/use-register-fonts.ts b/packages/pdf/src/hooks/use-register-fonts.ts
index e7d21916a..8bf8f03af 100644
--- a/packages/pdf/src/hooks/use-register-fonts.ts
+++ b/packages/pdf/src/hooks/use-register-fonts.ts
@@ -166,6 +166,10 @@ const thaiRegex = /[฀-๿]/;
// same reason: without it, keycap-only content falls back to a font without
// the enclosure mark and renders garbled.
const emojiRegex = /[\u{1F1E6}-\u{1F1FF}]|\u{20E3}|\p{Extended_Pictographic}/u;
+// Geometric Shapes, Miscellaneous Symbols, Dingbats and Miscellaneous Symbols
+// and Arrows: text symbols like ★ (U+2605) that Latin fonts and Noto Emoji lack (#3581).
+// Pictographs in these blocks (☀, ✔, ⭐) are emoji and already resolve to Noto Emoji.
+const symbolsRegex = /(?!\p{Extended_Pictographic})[■-➿⬀-⯿]/u;
const scriptDetectors: { script: Script; regex: RegExp }[] = [
{ script: "hangul", regex: hangulRegex },
@@ -175,6 +179,7 @@ const scriptDetectors: { script: Script; regex: RegExp }[] = [
{ script: "hebrew", regex: hebrewRegex },
{ script: "thai", regex: thaiRegex },
{ script: "emoji", regex: emojiRegex },
+ { script: "symbols", regex: symbolsRegex },
];
const collectScripts = (value: unknown, scripts: Set<Script>): void => {
diff --git a/packages/utils/src/locale.ts b/packages/utils/src/locale.ts
index cafe29b1c..cac9c314e 100644
--- a/packages/utils/src/locale.ts
+++ b/packages/utils/src/locale.ts
@@ -97,7 +97,18 @@ export function getLocaleAlternates(pageUrl: string) {
// of falling back to a Latin/Han-only font and producing tofu. "emoji" is
// content-detected only (never locale-derived) and resolves to Noto Emoji so
// pictographs and regional indicators render instead of mojibake (#3321).
-export type Script = "hangul" | "kana" | "han-traditional" | "han-simplified" | "arabic" | "hebrew" | "thai" | "emoji";
+// "symbols" is content-detected too and resolves to Noto Sans Symbols 2 for
+// text symbols such as ★ that neither Latin fonts nor Noto Emoji cover (#3581).
+export type Script =
+ | "hangul"
+ | "kana"
+ | "han-traditional"
+ | "han-simplified"
+ | "arabic"
+ | "hebrew"
+ | "thai"
+ | "emoji"
+ | "symbols";
// The CJK subset of `Script`. CJK needs extra per-character line breaking that
// must NOT be applied to Arabic (cursive, joined letters) or Thai (combining
diff --git a/tests/e2e/specs/pdf-text.spec.ts b/tests/e2e/specs/pdf-text.spec.ts
index aa4cc9237..71f748d3f 100644
--- a/tests/e2e/specs/pdf-text.spec.ts
+++ b/tests/e2e/specs/pdf-text.spec.ts
@@ -41,12 +41,14 @@ test("browser PDF downloads preserve shaped scripts and report unsupported text"
data.summary.content = "<p>Unsupported \u{10FFFF}</p>";
expect((await page.request.put(`/api/openapi/resumes/${id}`, { data: { data } })).ok()).toBe(true);
await page.goto(`/builder/${id}`);
+ const textLoss = page.getByText(
+ "Some PDF text could not be rendered. Choose a font containing these characters, then retry the export.",
+ );
+ // The preview reports it first (#3581); let that toast time out so the next one can only come from the download.
+ await expect(textLoss).toBeVisible();
+ await expect(textLoss).toBeHidden({ timeout: 15_000 });
await page.getByRole("button", { name: "Download PDF", exact: true }).click();
- await expect(
- page.getByText(
- "Some PDF text could not be rendered. Choose a font containing these characters, then retry the export.",
- ),
- ).toBeVisible();
+ await expect(textLoss).toBeVisible();
const rejected = await page.request.get(`/api/openapi/resumes/${id}/pdf`);
expect(rejected.status()).toBe(400);
expect(await rejected.text()).toContain("Choose a font containing these characters");