Skip to content

Reason Network: your team's coding agents, talking to each other. The engine behind `reason network`.

Pin deunicode and keep slug's work bounded

WhitePepperLambSoupbb93207b567f
diff --git a/Cargo.toml b/Cargo.toml
index a133c4a..2496efa 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -17,7 +17,7 @@ blake3 = "1"
clap = { version = "4", features = ["derive"] }
cliclack = "0.5"
data-encoding = "2"
-deunicode = "1"
+deunicode = { version = "=1.6.2", default-features = false }
futures-lite = "2"
getrandom = "0.3"
iroh = "1.3"
diff --git a/src/util.rs b/src/util.rs
index 4ee4f9b..4a5a7df 100644
--- a/src/util.rs
+++ b/src/util.rs
@@ -101,10 +101,15 @@ pub fn process(pid: u32) -> Option<(u32, String)> {
/// Lowercase letters, digits and single dashes: a name that is safe in an address. Letters of other scripts are
/// transliterated first (`José` -> `jose`, `代码` -> `dai-ma`), so the address stays plain ASCII, which every version
-/// accepts, and nothing but punctuation comes out empty.
+/// accepts, and nothing but punctuation comes out empty. A character it can't transliterate is a separator.
pub fn slug(s: &str) -> String {
let mut out = String::new();
- for c in deunicode::deunicode(s).chars() {
+ // One character at a time, so a long name (teammates' names arrive up to megabytes long) costs no more than what is
+ // kept: one character can become up to 41.
+ for c in s.chars().flat_map(|c| deunicode::deunicode_char(c).unwrap_or(" ").chars()) {
+ if out.len() > 40 {
+ break;
+ }
if c.is_ascii_alphanumeric() {
out.push(c.to_ascii_lowercase());
} else if !out.is_empty() && !out.ends_with('-') {
@@ -273,6 +278,21 @@ mod tests {
// What was already a slug stays one, so names saved by an older version don't change.
assert_eq!(slug("sams-macbook-pro"), "sams-macbook-pro");
assert_eq!(slug("v2"), "v2");
+ // Only symbols: still empty, however they are written.
+ assert_eq!(slug("!@#$%^&*()"), "");
+ assert_eq!(slug("“—…”"), "");
+ }
+
+ #[test]
+ fn a_long_name_of_wide_characters_costs_what_is_kept() {
+ // Teammates' names arrive through `slug` too, and one character can become many letters.
+ let started = std::time::Instant::now();
+ let s = slug(&"龘".repeat(1 << 20));
+ assert_eq!(s.len(), 40, "{s}");
+ assert!(started.elapsed() < std::time::Duration::from_secs(1), "slowed by input it never keeps");
+ // The cut is the same as slugging everything first.
+ let long = "api ".repeat(100);
+ assert_eq!(slug(&long), long.trim().replace(' ', "-").chars().take(40).collect::<String>());
}
#[test]