Skip to content

🎥 Make videos programmatically with React

Add web renderer SVG sizing regression test

Jonny Burger06033d59b8a9
diff --git a/packages/docs/docs/client-side-rendering/limitations.mdx b/packages/docs/docs/client-side-rendering/limitations.mdx
index f8fdca42c7..47badd7f6f 100644
--- a/packages/docs/docs/client-side-rendering/limitations.mdx
+++ b/packages/docs/docs/client-side-rendering/limitations.mdx
@@ -74,6 +74,10 @@ The `text-decoration` property is <a style={{color: 'green'}}>supported</a> for
The `text-shadow` property is <a style={{color: 'green'}}>supported</a>.
The `-webkit-text-stroke`, `-webkit-text-stroke-color`, `-webkit-text-stroke-width`, `paint-order` properties are <a style={{color: 'green'}}>supported</a>.
+### SVG sizing
+
+The `preserveAspectRatio="none"` SVG attribute is <a style={{color: 'green'}}>supported</a>, including SVGs sized through CSS without `width` or `height` attributes, from <AvailableFrom v="4.0.535" inline />.
+
### Web fonts inside SVG
Fonts loaded through [`@remotion/fonts`](/docs/fonts-api) or [`@remotion/google-fonts`](/docs/google-fonts) are embedded automatically when they are used by `<text>`, `<tspan>`, or `<textPath>` inside an `<svg>` from <AvailableFrom v="4.0.525" inline />.
diff --git a/packages/web-renderer/src/test/Root.tsx b/packages/web-renderer/src/test/Root.tsx
index 179282b9f9..59adc9e5aa 100644
--- a/packages/web-renderer/src/test/Root.tsx
+++ b/packages/web-renderer/src/test/Root.tsx
@@ -76,6 +76,7 @@ import {selfTransformOrigin} from './fixtures/self-transform-origin';
import {simpleRotatedSvg} from './fixtures/simple-rotated-svg';
import {svgDataUri} from './fixtures/svg-data-uri';
import {svgExplicitDimensions} from './fixtures/svg-explicit-dimensions';
+import {svgPreserveAspectRatioNone} from './fixtures/svg-preserve-aspect-ratio-none';
import {backgroundClipText} from './fixtures/text/background-clip-text';
import {backgroundClipText3dTransform} from './fixtures/text/background-clip-text-3d-transform';
import {filterText} from './fixtures/text/filter-text';
@@ -141,6 +142,7 @@ export const Root: React.FC = () => {
<Composition {...scaledTranslatedSvg} />
<Composition {...svgExplicitDimensions} />
<Composition {...svgDataUri} />
+ <Composition {...svgPreserveAspectRatioNone} />
<Composition {...flexPositionedScaled} />
<Composition {...displayNone} />
<Composition {...scaleFixture} />
diff --git a/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-chromium-darwin.png b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-chromium-darwin.png
new file mode 100644
index 0000000000..518d786d3f
Binary files /dev/null and b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-chromium-darwin.png differ
diff --git a/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-firefox-darwin.png b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-firefox-darwin.png
new file mode 100644
index 0000000000..a2c7170734
Binary files /dev/null and b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-firefox-darwin.png differ
diff --git a/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-webkit-darwin.png b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-webkit-darwin.png
new file mode 100644
index 0000000000..dc980dad69
Binary files /dev/null and b/packages/web-renderer/src/test/__screenshots__/svg-preserve-aspect-ratio-none.test.tsx/svg-preserve-aspect-ratio-none-webkit-darwin.png differ
diff --git a/packages/web-renderer/src/test/fixtures/svg-preserve-aspect-ratio-none.tsx b/packages/web-renderer/src/test/fixtures/svg-preserve-aspect-ratio-none.tsx
new file mode 100644
index 0000000000..4e26d5a09d
--- /dev/null
+++ b/packages/web-renderer/src/test/fixtures/svg-preserve-aspect-ratio-none.tsx
@@ -0,0 +1,40 @@
+import {AbsoluteFill} from 'remotion';
+
+const Component: React.FC = () => {
+ return (
+ <AbsoluteFill style={{backgroundColor: 'white'}}>
+ <div
+ style={{
+ position: 'absolute',
+ left: 0,
+ top: 0,
+ width: 400,
+ height: 100,
+ }}
+ >
+ <svg
+ viewBox="0 0 100 100"
+ preserveAspectRatio="none"
+ style={{
+ position: 'absolute',
+ inset: 0,
+ width: '100%',
+ height: '100%',
+ }}
+ >
+ <rect width={100} height={100} fill="red" />
+ <path d="M0 0 L100 100" stroke="black" strokeWidth={4} />
+ </svg>
+ </div>
+ </AbsoluteFill>
+ );
+};
+
+export const svgPreserveAspectRatioNone = {
+ component: Component,
+ id: 'svg-preserve-aspect-ratio-none',
+ width: 400,
+ height: 100,
+ fps: 30,
+ durationInFrames: 1,
+} as const;
diff --git a/packages/web-renderer/src/test/svg-preserve-aspect-ratio-none.test.tsx b/packages/web-renderer/src/test/svg-preserve-aspect-ratio-none.test.tsx
new file mode 100644
index 0000000000..50d876cf9a
--- /dev/null
+++ b/packages/web-renderer/src/test/svg-preserve-aspect-ratio-none.test.tsx
@@ -0,0 +1,18 @@
+import {test} from 'vitest';
+import {renderStillOnWeb} from '../render-still-on-web';
+import '../symbol-dispose';
+import {svgPreserveAspectRatioNone} from './fixtures/svg-preserve-aspect-ratio-none';
+import {testImage} from './utils';
+
+test('renders SVGs without size attributes with preserveAspectRatio="none" (issue #12095)', async () => {
+ const blob = await (
+ await renderStillOnWeb({
+ licenseKey: 'free-license',
+ composition: svgPreserveAspectRatioNone,
+ frame: 0,
+ inputProps: {},
+ })
+ ).blob({format: 'png'});
+
+ await testImage({blob, testId: 'svg-preserve-aspect-ratio-none'});
+});