Skip to content

🎥 Make videos programmatically with React

remotion: Support connected compositions in Series.Sequence (#10501)

Jonny Burger148f5e8b9413
diff --git a/packages/core/src/series/index.tsx b/packages/core/src/series/index.tsx
index 2a152d4f04..90b375ce48 100644
--- a/packages/core/src/series/index.tsx
+++ b/packages/core/src/series/index.tsx
@@ -5,7 +5,10 @@ import React, {
type PropsWithChildren,
} from 'react';
import type {SequenceControls} from '../CompositionManager.js';
-import {addSequenceStackTraces} from '../enable-sequence-stack-traces.js';
+import {
+ addSequenceStackTraces,
+ getSingleChildComponent,
+} from '../enable-sequence-stack-traces.js';
import {Interactive} from '../Interactive.js';
import {
sequenceSchemaDefaultLayoutNone,
@@ -220,6 +223,9 @@ const SeriesInner: FC<SeriesProps> = (props) => {
from={currentStartFrame}
durationInFrames={durationInFramesProp}
{...passedProps}
+ _remotionInternalSingleChildComponent={getSingleChildComponent(
+ sequenceChildren,
+ )}
>
<IsNotInsideSeriesProvider>
{sequenceChildren}
diff --git a/packages/core/src/test/sequence-register-once.test.tsx b/packages/core/src/test/sequence-register-once.test.tsx
index 6cb6641332..9cd2d79c8f 100644
--- a/packages/core/src/test/sequence-register-once.test.tsx
+++ b/packages/core/src/test/sequence-register-once.test.tsx
@@ -436,6 +436,7 @@ test('Series.Sequence registers with its own visual controls', () => {
const registeredSequences: TSequence[] = [];
const firstStack = 'Error\n at FirstSeriesSequence';
const secondStack = 'Error\n at SecondSeriesSequence';
+ const ConnectedComposition: React.FC = () => null;
render(
<SequenceTestWrapper
@@ -451,7 +452,7 @@ test('Series.Sequence registers with its own visual controls', () => {
_remotionInternalStack: firstStack,
} as {readonly _remotionInternalStack: string})}
>
- First
+ <ConnectedComposition />
</Series.Sequence>
<Series.Sequence
durationInFrames={20}
@@ -487,6 +488,7 @@ test('Series.Sequence registers with its own visual controls', () => {
firstStack,
secondStack,
]);
+ expect(seriesSequences[0]?.singleChildComponent).toBe(ConnectedComposition);
});
test('Interactive.withSchema preserves source stacks through controls without consuming a public stack prop', () => {