Skip to content

🎥 Make videos programmatically with React

Avoid quadratic key checks when comparing Studio data

Jonny Burger1672d211c64b
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/deep-equal.ts b/packages/studio/src/components/RenderModal/SchemaEditor/deep-equal.ts
index b1b904b65e..5a82a603db 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/deep-equal.ts
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/deep-equal.ts
@@ -24,8 +24,18 @@ export function deepEqual(a: any, b: any): boolean {
return false;
}
- for (const key of keysA) {
- if (!keysB.includes(key) || !deepEqual(a[key], b[key])) {
+ let keySetB: Set<string> | null = null;
+ for (let i = 0; i < keysA.length; i++) {
+ const key = keysA[i];
+ // Arrays and JSON round trips normally keep the same key order.
+ if (keysB[i] !== key) {
+ keySetB ??= new Set(keysB);
+ if (!keySetB.has(key)) {
+ return false;
+ }
+ }
+
+ if (!deepEqual(a[key], b[key])) {
return false;
}
}