Skip to content

🎥 Make videos programmatically with React

Move transcription options to advanced pane

JonnyBurger1dd321d94ea9
diff --git a/packages/studio/src/components/Transcription/TranscriptionModal.tsx b/packages/studio/src/components/Transcription/TranscriptionModal.tsx
index a3d81492af..ce8e6d72ea 100644
--- a/packages/studio/src/components/Transcription/TranscriptionModal.tsx
+++ b/packages/studio/src/components/Transcription/TranscriptionModal.tsx
@@ -18,6 +18,7 @@ import {BLUE_DISABLED, LIGHT_TEXT, WHITE} from '../../helpers/colors';
import {getFileManagerName} from '../../helpers/get-file-manager-name';
import {Checkmark} from '../../icons/Checkmark';
import {ExpandedFolderIconSolid} from '../../icons/folder';
+import {GearIcon} from '../../icons/gear';
import {ModelsIcon} from '../../icons/models';
import {TranscriptionIcon} from '../../icons/transcription';
import type {TranscriptionModalState} from '../../state/modals';
@@ -79,7 +80,7 @@ const DEFAULT_REPETITION_PENALTY = 1;
const DEFAULT_NO_REPEAT_NGRAM_SIZE = 0;
const MAX_CHUNK_LENGTH_IN_SECONDS = 30;
-type Tab = 'transcribe' | 'models';
+type Tab = 'transcribe' | 'advanced' | 'models';
type SupportState =
| {type: 'checking'}
@@ -910,6 +911,18 @@ export const TranscriptionModal: React.FC<TranscriptionModalState> = ({
>
Transcribe
</VerticalTab>
+ <VerticalTab
+ style={horizontalTab}
+ selected={tab === 'advanced'}
+ onClick={() => setTab('advanced')}
+ renderIcon={(color) => (
+ <div style={iconContainer}>
+ <GearIcon color={color} style={icon} />
+ </div>
+ )}
+ >
+ Advanced
+ </VerticalTab>
<VerticalTab
style={horizontalTab}
selected={tab === 'models'}
@@ -944,7 +957,11 @@ export const TranscriptionModal: React.FC<TranscriptionModalState> = ({
setSelectedTask={setSelectedTask}
supportState={supportState}
/>
- <RenderModalHr />
+ </div>
+ <div
+ style={tab === 'advanced' ? settingsPanel : hiddenPanel}
+ className={VERTICAL_SCROLLBAR_CLASSNAME}
+ >
<AdvancedSettings
chunkLengthInSeconds={chunkLengthInSeconds}
decodingValidationMessage={decodingValidationMessage}
diff --git a/packages/studio/src/test/transcription-modal.test.tsx b/packages/studio/src/test/transcription-modal.test.tsx
index 95e940149a..4e36233cd9 100644
--- a/packages/studio/src/test/transcription-modal.test.tsx
+++ b/packages/studio/src/test/transcription-modal.test.tsx
@@ -175,12 +175,9 @@ test('serializes transcription modal settings into caption jobs', async () => {
expect(captionType.style.fontSize).toBe('inherit');
expect(captionType.style.lineHeight).toBe('inherit');
fireEvent.pointerUp(outputHelp);
- screen.getByTitle('Learn more about Chunk length');
- screen.getByTitle('Learn more about Stride length');
- screen.getByTitle('Learn more about Force full sequences');
- screen.getByTitle('Learn more about Use sampling');
- screen.getByTitle('Learn more about Repetition penalty');
- screen.getByTitle('Learn more about No-repeat n-gram size');
+ expect(
+ screen.queryByRole('checkbox', {name: 'Force full sequences'}),
+ ).toBeNull();
expect(screen.queryByTitle('Task')).toBeNull();
await selectComboboxItem(screen.getByTitle('Whisper model'), /^tiny ·/);
@@ -220,6 +217,14 @@ test('serializes transcription modal settings into caption jobs', async () => {
screen.getByText('Exists, will be overwritten');
screen.getByTitle(/^Open in (Finder|File Explorer|File Manager)$/);
+ fireEvent.click(screen.getByRole('button', {name: 'Advanced'}));
+ screen.getByTitle('Learn more about Chunk length');
+ screen.getByTitle('Learn more about Stride length');
+ screen.getByTitle('Learn more about Force full sequences');
+ screen.getByTitle('Learn more about Use sampling');
+ screen.getByTitle('Learn more about Repetition penalty');
+ screen.getByTitle('Learn more about No-repeat n-gram size');
+
const forceFullSequences = screen.getByRole('checkbox', {
name: 'Force full sequences',
});