🎥 Make videos programmatically with React
Permit updates to existing tests without explicit request
JonnyBurger21e194256676
diff --git a/.agents/skills/nullable-new-params/SKILL.md b/.agents/skills/nullable-new-params/SKILL.mdindex 790d91b1b4..0e45f3440e 100644--- a/.agents/skills/nullable-new-params/SKILL.md+++ b/.agents/skills/nullable-new-params/SKILL.md@@ -64,7 +64,7 @@ const after = (frame: number | null) => {};5. Update implementation logic:- Replace truthy checks when `0`, `''`, or `false` are valid values.- Prefer `value !== null` over `value` for nullable numbers/strings/booleans.- - When the user explicitly requests test changes, keep tests and fixtures explicit; do not make large fixtures `Partial<T>` only to dodge the new field.+ - When updating existing tests or fixtures, keep them explicit; do not make large fixtures `Partial<T>` only to dodge the new field.6. For public candidates, preserve backwards compatibility:- Keep the new field optional in the public type.diff --git a/.agents/skills/pr/SKILL.md b/.agents/skills/pr/SKILL.mdindex 6839b6431d..49936c3dd3 100644--- a/.agents/skills/pr/SKILL.md+++ b/.agents/skills/pr/SKILL.md@@ -6,7 +6,7 @@ description: Open a pull request for the current featureEnsure we are not on the main branch, make a branch if necessary.Check whether a PR already exists for the current branch with `gh pr status` or `gh pr view`. If one exists, update it with local changes.-Keep agent-authored test, fixture, and snapshot changes out of the PR unless the user explicitly requested test changes. Review the diff for this without removing pre-existing user changes.+Keep new agent-authored tests, including new test cases in existing files, out of the PR unless the user explicitly requested them. Updates to existing tests, fixtures, and snapshots are allowed when needed for the change. Review the diff and preserve pre-existing user changes.If the changes add a Remotion Element, read the [Element contribution guide](../../../packages/docs/elements/contributing.mdx) before continuing.diff --git a/.agents/skills/web-renderer-test/SKILL.md b/.agents/skills/web-renderer-test/SKILL.mdindex 92f08fadce..96f48123a2 100644--- a/.agents/skills/web-renderer-test/SKILL.md+++ b/.agents/skills/web-renderer-test/SKILL.md@@ -1,9 +1,9 @@---name: web-renderer-test-description: Add or update web renderer tests when the user explicitly requests test changes.+description: Add explicitly requested web renderer tests or update existing ones for implementation changes.----Use this skill only when the user explicitly requests web renderer test changes.+Use this skill to update existing web renderer tests when needed for implementation changes. Add new tests only when the user explicitly requests them.The web renderer is in `packages/web-renderer` and the test suite is in `packages/web-renderer/src/test`.diff --git a/.agents/skills/writing-tests/SKILL.md b/.agents/skills/writing-tests/SKILL.mdindex 3414cf8c2a..9a821c3263 100644--- a/.agents/skills/writing-tests/SKILL.md+++ b/.agents/skills/writing-tests/SKILL.md@@ -1,11 +1,11 @@---name: writing-tests-description: Guidance for explicitly requested test writing, editing, or review in the Remotion repository. Use only when the user asks for test work.+description: Guidance for explicitly requested new tests and for updating or reviewing existing tests in the Remotion repository.---# Writing Tests-Apply this skill only when the user explicitly requests test work. Do not add or modify tests, fixtures, or snapshots as part of ordinary feature work, bug fixes, refactors, or PR preparation. A request to review tests does not authorize changing them.+Apply this skill when the user explicitly requests new tests or when existing tests, fixtures, or snapshots need updates for feature work, bug fixes, refactors, or PR preparation. Do not add new tests, including new test cases in existing files, unless the user explicitly requests them. A request to review tests does not authorize changing them.The purpose of a test is confidence that a workflow or contract works for a Studio user, CLI user, package consumer, or renderer consumer.diff --git a/AGENTS.md b/AGENTS.mdindex e4552422ba..98c4d8edec 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -28,7 +28,7 @@ The current Remotion version can be found in `packages/core/src/version.ts`. The## Test changes-Do not add or modify tests, test fixtures, or snapshots unless the user explicitly asks for test changes. Feature work, bug fixes, refactors, and PR preparation do not imply permission to write tests. Keep agent-authored test changes out of PRs unless explicitly requested, and preserve pre-existing user changes.+Do not add new tests, including new test cases in existing files, unless the user explicitly asks for them. Edit or remove existing tests, fixtures, and snapshots as needed for feature work, bug fixes, refactors, and PR preparation. Preserve pre-existing user changes.Running existing tests for validation is allowed.