Skip to content

🎥 Make videos programmatically with React

`@remotion/studio`: Fix timeline selection for JSX on one line

JonnyBurger2319c5367d0c
diff --git a/packages/bundler/src/test/setup-sequence-stack-traces.test.ts b/packages/bundler/src/test/setup-sequence-stack-traces.test.ts
index b50e83ff40..943460a77a 100644
--- a/packages/bundler/src/test/setup-sequence-stack-traces.test.ts
+++ b/packages/bundler/src/test/setup-sequence-stack-traces.test.ts
@@ -79,7 +79,7 @@ test('defers and idempotently enables source stack injection in production', asy
readonly _remotionInternalStack: string;
};
expect(sourceProps._remotionInternalStack).toBe(
- 'Error\n at remotionOriginalSource (studio-original://.%2Fsrc%2FVideo.tsx:12:4)',
+ 'Error\n at remotionOriginalSource (studio-original://.%2Fsrc%2FVideo.tsx:12:3)',
);
} finally {
if (previousNodeEnv === undefined) {
diff --git a/packages/core/src/create-element-source-proxy.ts b/packages/core/src/create-element-source-proxy.ts
index b08a3ec729..4326d5dc18 100644
--- a/packages/core/src/create-element-source-proxy.ts
+++ b/packages/core/src/create-element-source-proxy.ts
@@ -47,7 +47,9 @@ export const createElementSourceProxy = <
? makeOriginalSourceStack({
fileName: getSourceFileName(source.fileName),
lineNumber: source.lineNumber,
- columnNumber: source.columnNumber,
+ // JSX development locations are one-based, like stack traces.
+ // Resolved source locations and AST lookups use zero-based columns.
+ columnNumber: source.columnNumber - 1,
})
: new Error().stack));
const newProps = existingStack