Skip to content

🎥 Make videos programmatically with React

`@remotion/studio`: Add shortcut remapping menu action

JonnyBurger2c1dc43f8ec5
diff --git a/packages/example/e2e/studio.test.mts b/packages/example/e2e/studio.test.mts
index 8804df8d99..a39642004d 100644
--- a/packages/example/e2e/studio.test.mts
+++ b/packages/example/e2e/studio.test.mts
@@ -1853,7 +1853,8 @@ test.describe('visual mode', () => {
name: 'Actions for Play / Pause',
});
await expect(playPauseActions).toBeVisible();
- await playPauseShortcut.click();
+ await playPauseActions.click();
+ await page.getByText('Remap shortcut', {exact: true}).click();
await expect(playPauseShortcut).toContainText('Press shortcut');
await page.keyboard.press('q');
await expect
diff --git a/packages/studio/src/components/KeyboardShortcutsSettings.tsx b/packages/studio/src/components/KeyboardShortcutsSettings.tsx
index 8a150c16f0..5e10dafaf9 100644
--- a/packages/studio/src/components/KeyboardShortcutsSettings.tsx
+++ b/packages/studio/src/components/KeyboardShortcutsSettings.tsx
@@ -283,10 +283,31 @@ export const KeyboardShortcutsSettings: React.FC = () => {
shortcut.actionId,
configuredShortcuts,
).map(formatKeyboardShortcut);
+ const shortcutButtonId =
+ shortcut.actionId === null
+ ? null
+ : `keyboard-shortcut-${shortcut.actionId}`;
const shortcutMenuItems: ComboboxValue[] =
shortcut.actionId === null
? []
: [
+ {
+ id: 'remap-shortcut',
+ keyHint: null,
+ label: 'Remap shortcut',
+ leftItem: null,
+ onClick: () => {
+ setError(null);
+ setRecording(shortcut.actionId);
+ requestAnimationFrame(() => {
+ document.getElementById(shortcutButtonId!)?.focus();
+ });
+ },
+ quickSwitcherLabel: null,
+ subMenu: null,
+ type: 'item',
+ value: 'remap-shortcut',
+ },
...(configured
? [
{
@@ -355,6 +376,7 @@ export const KeyboardShortcutsSettings: React.FC = () => {
<>
<span style={shortcutCell}>
<button
+ id={shortcutButtonId!}
type="button"
style={chordButton}
aria-label={`Change shortcut for ${shortcut.action}`}