Skip to content

🎥 Make videos programmatically with React

fix media playback rate reset on resource reload

Jonny Burger2c68166259fa
diff --git a/packages/core/src/use-media-playback.ts b/packages/core/src/use-media-playback.ts
index 29f4f1a1e0..654194207c 100644
--- a/packages/core/src/use-media-playback.ts
+++ b/packages/core/src/use-media-playback.ts
@@ -164,6 +164,14 @@ export const useMediaPlayback = ({
// and it is also in a useLayoutEffect.
useLayoutEffect(() => {
const playbackRateToSet = Math.max(0, playbackRate);
+ // Loading a resource resets playbackRate to defaultPlaybackRate.
+ if (
+ mediaRef.current &&
+ mediaRef.current.defaultPlaybackRate !== playbackRateToSet
+ ) {
+ mediaRef.current.defaultPlaybackRate = playbackRateToSet;
+ }
+
if (
mediaRef.current &&
mediaRef.current.playbackRate !== playbackRateToSet
diff --git a/packages/media/src/test/html5-playback-rate.test.tsx b/packages/media/src/test/html5-playback-rate.test.tsx
new file mode 100644
index 0000000000..4c4d5cca95
--- /dev/null
+++ b/packages/media/src/test/html5-playback-rate.test.tsx
@@ -0,0 +1,46 @@
+import {Player} from '@remotion/player';
+import React from 'react';
+import {createRoot} from 'react-dom/client';
+import {Html5Video} from 'remotion';
+import {expect, test} from 'vitest';
+
+test('preserves the Player media playback rate across source changes and reloads', async () => {
+ const container = document.createElement('div');
+ document.body.appendChild(container);
+ const root = createRoot(container);
+ const Composition: React.FC<{readonly src: string}> = ({src}) => (
+ <Html5Video src={src} playbackRate={0.6} />
+ );
+
+ try {
+ for (const [index, globalRate] of [1, 0.5].entries()) {
+ root.render(
+ <Player
+ acknowledgeRemotionLicense
+ component={Composition}
+ compositionHeight={720}
+ compositionWidth={1280}
+ durationInFrames={100}
+ fps={30}
+ initiallyMuted
+ playbackRate={globalRate}
+ inputProps={{src: `/bigbuckbunny.mp4?source=${index}`}}
+ />,
+ );
+ await expect
+ .poll(() => container.querySelector('video')?.readyState)
+ .toBe(4);
+ const video = container.querySelector('video')!;
+ await expect.poll(() => video.playbackRate).toBe(0.6 * globalRate);
+
+ // Loading a new resource resets playbackRate to defaultPlaybackRate.
+ video.src = `/bigbuckbunny.mp4?reload=${index}`;
+ video.load();
+ await expect.poll(() => video.readyState).toBe(4);
+ expect(video.playbackRate).toBe(0.6 * globalRate);
+ }
+ } finally {
+ root.unmount();
+ container.remove();
+ }
+});