Skip to content

🎥 Make videos programmatically with React

Raise child transition seams to leave room for labels

JonnyBurger2d4d08bb1ae4
diff --git a/packages/studio/src/components/Timeline/TimelineSequence.tsx b/packages/studio/src/components/Timeline/TimelineSequence.tsx
index 9dc4bc9b7a..a4ad51eba2 100644
--- a/packages/studio/src/components/Timeline/TimelineSequence.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequence.tsx
@@ -556,6 +556,7 @@ const TimelineSequenceBar: React.FC<{
s.timelineTrack?.role === 'clip'
? Number(style.height)
: (sceneClipHeight ?? Number(style.height)),
+ seamFraction: s.timelineTrack?.role === 'clip' ? 0.5 : 0.3,
cropHeight: Number(style.height),
});
}, [
@@ -585,6 +586,7 @@ const TimelineSequenceBar: React.FC<{
s.timelineTrack?.role === 'clip'
? Number(style.height)
: (sceneClipHeight ?? Number(style.height)),
+ seamFraction: s.timelineTrack?.role === 'clip' ? 0.5 : 0.3,
cropHeight: Number(style.height),
});
}, [
@@ -619,6 +621,7 @@ const TimelineSequenceBar: React.FC<{
durationInFrames: Number(style.width) / frameIncrement,
pixelsPerFrame: frameIncrement,
height: Number(style.height),
+ seamFraction: 0.5,
cropHeight: null,
})
: undefined,
diff --git a/packages/studio/src/components/Timeline/TimelineTracks.tsx b/packages/studio/src/components/Timeline/TimelineTracks.tsx
index ffd1f4ecb5..e4edb2062e 100644
--- a/packages/studio/src/components/Timeline/TimelineTracks.tsx
+++ b/packages/studio/src/components/Timeline/TimelineTracks.tsx
@@ -141,6 +141,7 @@ const TimelineTracksInner: React.FC<{
(windowWidth - TIMELINE_PADDING * 2) /
video.durationInFrames,
height: virtualItem.size,
+ seamFraction: 0.3,
cropHeight: null,
})
: undefined,
diff --git a/packages/studio/src/components/Timeline/get-timeline-scene-clip-path.ts b/packages/studio/src/components/Timeline/get-timeline-scene-clip-path.ts
index b9fe775945..c08213d133 100644
--- a/packages/studio/src/components/Timeline/get-timeline-scene-clip-path.ts
+++ b/packages/studio/src/components/Timeline/get-timeline-scene-clip-path.ts
@@ -6,6 +6,7 @@ type TimelineSceneClipOptions = {
readonly offsetInFrames: number;
readonly pixelsPerFrame: number;
readonly height: number;
+ readonly seamFraction: number;
readonly cropHeight: number | null;
};
@@ -15,6 +16,7 @@ export const getTimelineSceneShape = ({
offsetInFrames,
pixelsPerFrame,
height,
+ seamFraction,
cropHeight,
}: TimelineSceneClipOptions): {
readonly clipPath: string;
@@ -39,7 +41,7 @@ export const getTimelineSceneShape = ({
};
}
- const middle = (Math.round(height / 2) / height) * 100;
+ const middle = (Math.round(height * seamFraction) / height) * 100;
const outgoingInset =
sceneRange.transitionOutStart === null ? 0 : 1 / pixelsPerFrame;
const outgoingMiddle =