Skip to content

🎥 Make videos programmatically with React

Handle timeline tracker remounts

JonnyBurger2d8b93edf530
diff --git a/packages/studio/src/helpers/drag-aware-double-click.ts b/packages/studio/src/helpers/drag-aware-double-click.ts
index b58f81acbd..28c6c8c6d3 100644
--- a/packages/studio/src/helpers/drag-aware-double-click.ts
+++ b/packages/studio/src/helpers/drag-aware-double-click.ts
@@ -29,8 +29,8 @@ export const createDragAwareDoubleClickTracker =
return (
clickCount > 0 &&
clickCount % 2 === 0 &&
- previousPointerButton === 0 &&
- currentPointerButton === 0
+ currentPointerButton === 0 &&
+ (clickCount > 2 || previousPointerButton === 0)
);
},
};
diff --git a/packages/studio/src/test/drag-aware-double-click.test.ts b/packages/studio/src/test/drag-aware-double-click.test.ts
index 077b87584b..fc37bf980e 100644
--- a/packages/studio/src/test/drag-aware-double-click.test.ts
+++ b/packages/studio/src/test/drag-aware-double-click.test.ts
@@ -39,3 +39,11 @@ test('A mixed-button click succession can recover on the next primary double cli
tracker.beginPointerGesture({button: 0});
expect(tracker.acceptClickAsDoubleClick(4)).toBe(true);
});
+
+test('A continued click succession can recover after the tracker remounts', () => {
+ const tracker = createDragAwareDoubleClickTracker();
+
+ tracker.beginPointerGesture({button: 0});
+ expect(tracker.acceptClickAsDoubleClick(2)).toBe(false);
+ expect(tracker.acceptClickAsDoubleClick(4)).toBe(true);
+});