🎥 Make videos programmatically with React
Skip empty Fiber commit order events
JonnyBurger3dd2961ce5b1
diff --git a/packages/studio/src/helpers/install-fiber-sequence-order-observer.ts b/packages/studio/src/helpers/install-fiber-sequence-order-observer.tsindex 058fee30fe..e06c7dfa98 100644--- a/packages/studio/src/helpers/install-fiber-sequence-order-observer.ts+++ b/packages/studio/src/helpers/install-fiber-sequence-order-observer.ts@@ -172,11 +172,16 @@ export const installFiberCommitOrderObserver = (try {const [, root] = args;const order = collectCommitOrderFromFiber(root);- target.dispatchEvent(- new CustomEvent(Internals.CommitOrderInternals.eventName, {- detail: order,- }),- );+ if (+ order.sequenceManagers.length > 0 ||+ order.compositionManagers.length > 0+ ) {+ target.dispatchEvent(+ new CustomEvent(Internals.CommitOrderInternals.eventName, {+ detail: order,+ }),+ );+ }} catch {// Fiber is private React API. An unsupported shape must not break Studio.}diff --git a/packages/studio/src/test/fiber-sequence-order-observer.test.ts b/packages/studio/src/test/fiber-sequence-order-observer.test.tsindex 9b87dd2340..c477b0f929 100644--- a/packages/studio/src/test/fiber-sequence-order-observer.test.ts+++ b/packages/studio/src/test/fiber-sequence-order-observer.test.ts@@ -165,6 +165,7 @@ test('chains the existing commit hook and emits the committed order once', () =>try {expect(installFiberCommitOrderObserver(window)).toBe(true);expect(installFiberCommitOrderObserver(window)).toBe(true);+ hook.onCommitFiberRoot(1, {current: makeFiber()}, null, false);hook.onCommitFiberRoot(1, root, null, false);} finally {window.removeEventListener(@@ -173,7 +174,7 @@ test('chains the existing commit hook and emits the committed order once', () =>);}- expect(previousHookCalls).toBe(1);+ expect(previousHookCalls).toBe(2);expect(events).toEqual([{sequenceManagers: [{managerId: 'manager-a', sequenceIds: ['first']}],