Skip to content

🎥 Make videos programmatically with React

Elements: Apply metadata dimensions during insertion

Jonny Burger3e4a7dc4a0a7
diff --git a/packages/docs/elements/commerce/product-discount-callout/product-discount-callout.tsx b/packages/docs/elements/commerce/product-discount-callout/product-discount-callout.tsx
index d658ab9eb0..db5cbad0fb 100644
--- a/packages/docs/elements/commerce/product-discount-callout/product-discount-callout.tsx
+++ b/packages/docs/elements/commerce/product-discount-callout/product-discount-callout.tsx
@@ -34,11 +34,11 @@ const ProductDiscountCalloutInner: React.FC<InteractiveTransformProps> = ({
style={{
WebkitFontSmoothing: 'antialiased',
fontFamily: 'Inter',
- height: 720,
+ height: '100%',
isolation: 'isolate',
overflow: 'hidden',
position: 'relative',
- width: 720,
+ width: '100%',
...style,
}}
>
diff --git a/packages/docs/elements/data/number-counter/number-counter.tsx b/packages/docs/elements/data/number-counter/number-counter.tsx
index eb56aa484c..5fe59560f5 100644
--- a/packages/docs/elements/data/number-counter/number-counter.tsx
+++ b/packages/docs/elements/data/number-counter/number-counter.tsx
@@ -29,8 +29,8 @@ const NumberCounterInner: React.FC<InteractiveTransformProps> = ({style}) => {
name="Container"
style={{
display: 'flex',
- width: 640,
- height: 200,
+ width: '100%',
+ height: '100%',
alignItems: 'center',
justifyContent: 'center',
fontFamily: 'Inter',
diff --git a/packages/docs/elements/text/crossed-off/crossed-off.tsx b/packages/docs/elements/text/crossed-off/crossed-off.tsx
index 706e6d0cc0..df07b054b5 100644
--- a/packages/docs/elements/text/crossed-off/crossed-off.tsx
+++ b/packages/docs/elements/text/crossed-off/crossed-off.tsx
@@ -23,8 +23,7 @@ const CrossedOffTextInner: React.FC<InteractiveTransformProps> = ({style}) => {
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
- width: 900,
- height: 220,
+ height: '100%',
fontSize: 80,
fontWeight: 700,
lineHeight: 1.1,
diff --git a/packages/docs/elements/text/strike-through/strike-through.tsx b/packages/docs/elements/text/strike-through/strike-through.tsx
index 9df5ab6f2b..7ba8aab81f 100644
--- a/packages/docs/elements/text/strike-through/strike-through.tsx
+++ b/packages/docs/elements/text/strike-through/strike-through.tsx
@@ -25,8 +25,7 @@ const StrikeThroughTextInner: React.FC<InteractiveTransformProps> = ({
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
- width: 900,
- height: 220,
+ height: '100%',
fontSize: 80,
fontWeight: 700,
lineHeight: 1.1,
diff --git a/packages/docs/src/components/Elements/element-definitions.ts b/packages/docs/src/components/Elements/element-definitions.ts
index 24d7d8ecfb..76bc84fff1 100644
--- a/packages/docs/src/components/Elements/element-definitions.ts
+++ b/packages/docs/src/components/Elements/element-definitions.ts
@@ -568,8 +568,8 @@ const elementImplementations = [
{name: '@remotion/shapes', version: null},
],
durationInFrames: 120,
- elementHeight: 720,
- elementWidth: 720,
+ elementHeight: 760,
+ elementWidth: 760,
fps: 30,
height: 1080,
posterFrame: 57,
diff --git a/packages/studio-server/src/preview-server/routes/insert-element.ts b/packages/studio-server/src/preview-server/routes/insert-element.ts
index 53440ecbb3..022cf60118 100644
--- a/packages/studio-server/src/preview-server/routes/insert-element.ts
+++ b/packages/studio-server/src/preview-server/routes/insert-element.ts
@@ -317,6 +317,14 @@ export const insertElementHandler: ApiHandler<
const shouldWriteElementFile =
!plan.elementFileExists || elementSourcesDiffer;
+ const initialProps = {...element.initialProps};
+ if (componentOwnsSequence && element.dimensions !== null) {
+ initialProps.style = {
+ ...element.dimensions,
+ ...(typeof initialProps.style === 'object' ? initialProps.style : {}),
+ };
+ }
+
const insertionInput = {
remotionRoot,
compositionFile,
@@ -327,9 +335,10 @@ export const insertElementHandler: ApiHandler<
importName: plan.componentName,
importPath: plan.importPath,
props: [
- ...Object.entries(element.initialProps ?? {}).map(
- ([name, value]) => ({name, value}),
- ),
+ ...Object.entries(initialProps).map(([name, value]) => ({
+ name,
+ value,
+ })),
...(componentOwnsSequence && element.durationInFrames !== null
? [
{