Skip to content

🎥 Make videos programmatically with React

Hide redundant canvas wrapping quick actions

Jonny Burger3f1bf733a68d
diff --git a/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx b/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
index 64e5001a98..a6ba50c134 100644
--- a/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
+++ b/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
@@ -362,14 +362,12 @@ const SequenceSourceQuickActions: React.FC<{
>
Duplicate
</InspectorQuickAction>
- {mediaSequence === null ? (
- <SequenceWrapAction
- nodePathInfo={selection.nodePathInfo}
- track={track}
- sourceActionsDisabled={sourceActionsDisabled}
- sourceLocation={validatedLocation}
- />
- ) : null}
+ <SequenceWrapAction
+ nodePathInfo={selection.nodePathInfo}
+ track={track}
+ sourceActionsDisabled={sourceActionsDisabled}
+ sourceLocation={validatedLocation}
+ />
<SequencePrecomposeAction
targets={[
{
diff --git a/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx b/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
index 24b702b2aa..6d255cf55e 100644
--- a/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
+++ b/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
@@ -48,11 +48,18 @@ export const SequenceWrapAction: React.FC<{
);
const {sequence} = track;
const [busy, setBusy] = useState(false);
+ const canWrapInHtmlInCanvas =
+ sequence.type === 'sequence' &&
+ !nodePathInfo.supportsEffects &&
+ !htmlInCanvasComponentIdentities.has(
+ sequence.controls?.componentIdentity ?? '',
+ );
const onWrap = useCallback(
async (wrapper: HtmlInCanvasWrapper) => {
if (
busy ||
+ !canWrapInHtmlInCanvas ||
sourceActionsDisabled ||
canvasContent?.type !== 'composition'
) {
@@ -191,6 +198,7 @@ export const SequenceWrapAction: React.FC<{
},
[
busy,
+ canWrapInHtmlInCanvas,
canvasContent,
nodePathInfo.sequenceSubscriptionKey,
overrideIdToNodePathMappingsRef,
@@ -204,7 +212,11 @@ export const SequenceWrapAction: React.FC<{
],
);
- if (sourceActionsDisabled || canvasContent?.type !== 'composition') {
+ if (
+ !canWrapInHtmlInCanvas ||
+ sourceActionsDisabled ||
+ canvasContent?.type !== 'composition'
+ ) {
return null;
}