Skip to content

🎥 Make videos programmatically with React

Internal: Remove flaky media frame accuracy tests

JonnyBurger3f4066015f00
diff --git a/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-89-video-frame-89-loop-boundary-step-back-chrome.png b/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-89-video-frame-89-loop-boundary-step-back-chrome.png
deleted file mode 100644
index 078df23de5..0000000000
Binary files a/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-89-video-frame-89-loop-boundary-step-back-chrome.png and /dev/null differ
diff --git a/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-90-video-frame-0-loop-boundary-step-back-chrome.png b/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-90-video-frame-0-loop-boundary-step-back-chrome.png
deleted file mode 100644
index d6e9d9dc96..0000000000
Binary files a/packages/media/src/test/__screenshots__/player-loop-frame-accuracy.test.tsx/media-player-frame-90-video-frame-0-loop-boundary-step-back-chrome.png and /dev/null differ
diff --git a/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-step-back-and-forward-chrome.png b/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-step-back-and-forward-chrome.png
deleted file mode 100644
index aab2d165d4..0000000000
Binary files a/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-step-back-and-forward-chrome.png and /dev/null differ
diff --git a/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-stepping-chrome.png b/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-stepping-chrome.png
deleted file mode 100644
index c5ab999d98..0000000000
Binary files a/packages/media/src/test/__screenshots__/player-preview-frame-accuracy.test.tsx/media-player-frame-48-accuracy-after-stepping-chrome.png and /dev/null differ
diff --git a/packages/media/src/test/player-loop-frame-accuracy.test.tsx b/packages/media/src/test/player-loop-frame-accuracy.test.tsx
index 0ea4fb30ff..66f20d897f 100644
--- a/packages/media/src/test/player-loop-frame-accuracy.test.tsx
+++ b/packages/media/src/test/player-loop-frame-accuracy.test.tsx
@@ -1,7 +1,6 @@
import {Player, type PlayerRef} from '@remotion/player';
import React from 'react';
import {createRoot} from 'react-dom/client';
-import {Loop} from 'remotion';
import {test} from 'vitest';
import {Video} from '../video/video';
import {
@@ -35,107 +34,6 @@ const seekToAndWaitForVideoFrame = async ({
await wait(settleTime);
};
-test('keeps preview frame stepping visually accurate when stepping back over a loop boundary', async () => {
- const VideoComposition: React.FC<{
- readonly onVideoFrame: () => void;
- }> = ({onVideoFrame}) => {
- return (
- <Loop durationInFrames={90} times={3} name="MediaLoop">
- <Video
- src="https://remotion.media/video.mp4"
- debugOverlay
- onVideoFrame={onVideoFrame}
- />
- </Loop>
- );
- };
-
- const TestPlayer: React.FC<{
- readonly onVideoFrame: () => void;
- readonly playerRef: React.RefObject<PlayerRef | null>;
- }> = ({onVideoFrame, playerRef: ref}) => {
- return (
- <Player
- ref={ref}
- acknowledgeRemotionLicense
- component={VideoComposition}
- compositionHeight={height}
- compositionWidth={width}
- durationInFrames={90 * 3}
- fps={fps}
- initiallyMuted
- inputProps={{onVideoFrame}}
- />
- );
- };
-
- let drawnFrames = 0;
- const container = document.createElement('div');
- document.body.appendChild(container);
-
- const root = createRoot(container);
- const playerRef = React.createRef<PlayerRef>();
- root.render(
- <TestPlayer
- playerRef={playerRef}
- onVideoFrame={() => {
- drawnFrames++;
- }}
- />,
- );
-
- try {
- await waitFor(() => playerRef.current !== null);
- await waitUntilCanvasIsVisible({container, height, width});
-
- playerRef.current!.play();
- await waitFor(() => playerRef.current!.getCurrentFrame() >= 93);
- await wait(250);
- playerRef.current!.pause();
- await wait(250);
-
- for (const frame of [92, 91]) {
- await seekToAndWaitForVideoFrame({
- playerRef,
- frame,
- getDrawnFrames: () => drawnFrames,
- settleTime: 500,
- });
- }
-
- await seekToAndWaitForVideoFrame({
- playerRef,
- frame: 90,
- getDrawnFrames: () => drawnFrames,
- settleTime: 500,
- });
- const boundaryFrameBlob = await canvasToBlob(findLargestCanvas(container));
- await testImage({
- allowedMismatchedPixelRatio: 0.001,
- blob: boundaryFrameBlob,
- testId: 'media-player-frame-90-video-frame-0-loop-boundary-step-back',
- });
-
- await seekToAndWaitForVideoFrame({
- playerRef,
- frame: 89,
- getDrawnFrames: () => drawnFrames,
- settleTime: 500,
- });
- const beforeBoundaryFrameBlob = await canvasToBlob(
- findLargestCanvas(container),
- );
- await testImage({
- allowedMismatchedPixelRatio: 0.001,
- blob: beforeBoundaryFrameBlob,
- testId: 'media-player-frame-89-video-frame-89-loop-boundary-step-back',
- });
- } finally {
- root.unmount();
- container.remove();
- }
-});
-
test('keeps preview frame stepping accurate after crossing a trimAfter loop boundary', async () => {
const VideoComposition: React.FC<{
readonly onVideoFrame: () => void;
diff --git a/packages/media/src/test/player-preview-frame-accuracy.test.tsx b/packages/media/src/test/player-preview-frame-accuracy.test.tsx
deleted file mode 100644
index 6fb5908217..0000000000
--- a/packages/media/src/test/player-preview-frame-accuracy.test.tsx
+++ /dev/null
@@ -1,100 +0,0 @@
-import {Player, type PlayerRef} from '@remotion/player';
-import React from 'react';
-import {createRoot} from 'react-dom/client';
-import {test} from 'vitest';
-import {Video} from '../video/video';
-import {
- canvasToBlob,
- findLargestCanvas,
- seekToAndWait,
- testImage,
- wait,
- waitFor,
- waitUntilCanvasIsVisible,
-} from './player-frame-accuracy-utils';
-
-const src = 'https://remotion.media/video.mp4';
-const fps = 30;
-const width = 1920;
-const height = 1080;
-const startFrame = 45;
-const framesToStepThrough = [46, 47, 48];
-const stepBackFrame = 47;
-const finalFrame = 48;
-const afterSteppingScreenshot = 'media-player-frame-48-accuracy-after-stepping';
-const afterStepBackAndForwardScreenshot =
- 'media-player-frame-48-accuracy-after-step-back-and-forward';
-// Allow tiny browser/decoder screenshot variance after seeks while still catching visible frame offsets.
-const allowedMismatchedPixelRatio = 0.001;
-
-const VideoComposition: React.FC = () => {
- return <Video src={src} debugOverlay />;
-};
-
-const TestPlayer: React.FC<{
- readonly playerRef: React.RefObject<PlayerRef | null>;
-}> = ({playerRef}) => {
- return (
- <Player
- ref={playerRef}
- acknowledgeRemotionLicense
- component={VideoComposition}
- compositionHeight={height}
- compositionWidth={width}
- durationInFrames={300}
- fps={fps}
- initiallyMuted
- inputProps={{}}
- />
- );
-};
-
-test('keeps preview frame stepping visually accurate in Player', async () => {
- const container = document.createElement('div');
- document.body.appendChild(container);
-
- const root = createRoot(container);
- const playerRef = React.createRef<PlayerRef>();
- root.render(<TestPlayer playerRef={playerRef} />);
-
- try {
- await waitFor(() => playerRef.current !== null);
- await waitUntilCanvasIsVisible({container, height, width});
-
- playerRef.current!.play();
- await wait(700);
- playerRef.current!.pause();
- await wait(250);
-
- await seekToAndWait({playerRef, frame: startFrame, settleTime: 500});
-
- for (const frame of framesToStepThrough) {
- await seekToAndWait({playerRef, frame, settleTime: 500});
- }
-
- playerRef.current!.pause();
- const afterSteppingBlob = await canvasToBlob(findLargestCanvas(container));
- await testImage({
- allowedMismatchedPixelRatio,
- blob: afterSteppingBlob,
- testId: afterSteppingScreenshot,
- });
-
- await seekToAndWait({playerRef, frame: stepBackFrame, settleTime: 500});
-
- await seekToAndWait({playerRef, frame: finalFrame, settleTime: 500});
-
- playerRef.current!.pause();
- const afterStepBackAndForwardBlob = await canvasToBlob(
- findLargestCanvas(container),
- );
- await testImage({
- allowedMismatchedPixelRatio,
- blob: afterStepBackAndForwardBlob,
- testId: afterStepBackAndForwardScreenshot,
- });
- } finally {
- root.unmount();
- container.remove();
- }
-});