🎥 Make videos programmatically with React
Simplify caption model download progress
JonnyBurger49a5cc4d0feb
diff --git a/packages/studio/src/components/RenderQueue/CaptionQueueProcessor.tsx b/packages/studio/src/components/RenderQueue/CaptionQueueProcessor.tsxindex 09ed7cda8d..6e4e4f5062 100644--- a/packages/studio/src/components/RenderQueue/CaptionQueueProcessor.tsx+++ b/packages/studio/src/components/RenderQueue/CaptionQueueProcessor.tsx@@ -1,4 +1,3 @@-import {formatBytes} from '@remotion/studio-shared';import {canUseWhisperWebGpu,clearStaleModels,@@ -47,20 +46,10 @@ export const CaptionQueueProcessor: React.FC = () => {onProgress: (progress) => {const percentage =progress.progress === null- ? null- : `${Math.round(progress.progress * 100)}%`;- const bytes =- progress.loadedBytes === null || progress.totalBytes === null- ? null- : `${formatBytes(progress.loadedBytes)} / ${formatBytes(progress.totalBytes)}`;+ ? ''+ : ` ${Math.round(progress.progress * 100)}%`;updateCaptionJobProgress(job.id, {- message: [- `${modelIsCached ? 'Loading' : 'Downloading'} ${job.model}…`,- percentage,- bytes,- ]- .filter(Boolean)- .join(' · '),+ message: `${modelIsCached ? 'Loading' : 'Downloading'} ${job.model}${percentage}`,value: 0.03 + (progress.progress ?? 0) * 0.27,});},diff --git a/packages/studio/src/test/caption-queue-processor.test.tsx b/packages/studio/src/test/caption-queue-processor.test.tsxindex a0c20e06ed..f22f097ea6 100644--- a/packages/studio/src/test/caption-queue-processor.test.tsx+++ b/packages/studio/src/test/caption-queue-processor.test.tsx@@ -268,8 +268,7 @@ test('downloads a model in the queued job before transcribing', async () => {throw new Error('Caption job is not running');}- expect(job.progress.message).toContain('Downloading tiny…');- expect(job.progress.message).toContain('50%');+ expect(job.progress.message).toBe('Downloading tiny 50%');expect(job.progress.value).toBeCloseTo(0.165);});expect(resamplingCalls).toEqual([]);diff --git a/packages/studio/src/test/renders-tab-caption-jobs.test.tsx b/packages/studio/src/test/renders-tab-caption-jobs.test.tsxindex 3ec45e1169..e87d54f231 100644--- a/packages/studio/src/test/renders-tab-caption-jobs.test.tsx+++ b/packages/studio/src/test/renders-tab-caption-jobs.test.tsx@@ -72,19 +72,19 @@ test('labels the renders tab as Jobs while a caption job is running', () => {...baseJob,status: 'running',progress: {- message: 'Downloading tiny.en… · 50% · 57.1 MB / 114.2 MB',+ message: 'Downloading tiny.en 50%',value: 0.165,},});expect(screen.getByText('Jobs')).toBeTruthy();- expect(screen.getByText(/Downloading tiny\.en… · 50%/)).toBeTruthy();+ expect(screen.getByText('Downloading tiny.en 50%')).toBeTruthy();const progress = screen.getByRole('progressbar', {name: 'Caption job progress',});expect(progress.getAttribute('aria-valuenow')).toBe('17');- expect(progress.getAttribute('aria-valuetext')).toContain(- 'Downloading tiny.en… · 50%',+ expect(progress.getAttribute('aria-valuetext')).toBe(+ 'Downloading tiny.en 50%',);});