Skip to content

🎥 Make videos programmatically with React

Remove transcription from sequence context menus

JonnyBurger50bc792d3184
diff --git a/packages/example/e2e/transcription-modal.test.mts b/packages/example/e2e/transcription-modal.test.mts
index fb1de4e6c4..abf8f96e42 100644
--- a/packages/example/e2e/transcription-modal.test.mts
+++ b/packages/example/e2e/transcription-modal.test.mts
@@ -187,27 +187,5 @@ test.describe('transcription modal', () => {
await transcribe.click();
await expect(dialog).toContainText('Transcribe sine.wav');
await page.keyboard.press('Escape');
-
- await page.goto(`${STUDIO_URL}/transcription-legacy-media-e2e`);
- await expect(page).toHaveURL(/transcription-legacy-media-e2e/, {
- timeout: 15_000,
- });
-
- for (const name of ['vp8-vorbis.webm', '<Legacy Audio>']) {
- const timelineItem = page.getByText(name, {exact: true}).first();
- await expect(timelineItem).toBeVisible({timeout: 15_000});
- await timelineItem.click({button: 'right'});
- const menu = page.locator('[data-remotion-menu-tree-id]').last();
- const contextMenuTranscribe = menu.getByRole('button', {
- name: 'Transcribe',
- exact: true,
- });
- await expect(contextMenuTranscribe).toBeVisible();
- await contextMenuTranscribe.click();
- await expect(page.getByRole('dialog')).toContainText(
- `Transcribe ${name}`,
- );
- await page.keyboard.press('Escape');
- }
});
});
diff --git a/packages/example/src/E2eTestRoot.tsx b/packages/example/src/E2eTestRoot.tsx
index 7af9e6564c..9a157a71ae 100644
--- a/packages/example/src/E2eTestRoot.tsx
+++ b/packages/example/src/E2eTestRoot.tsx
@@ -23,10 +23,6 @@ import {RotationKeyframeE2e} from './RotationKeyframeE2e';
import {SchemaTest, schemaTestSchema} from './SchemaTest';
import {TimelineNegativeFromResize} from './TimelineNegativeFromResize';
import {TimelineVirtualizationTestbed} from './TimelineVirtualizationTestbed';
-import {
- TranscriptionAudioE2e,
- TranscriptionLegacyMediaE2e,
-} from './TranscriptionE2e';
import {VisualControls} from './VisualControls';
import {VisualMode3D} from './VisualMode3D';
import {AffineFrameClock} from './VisualModeTests/AffineFrameClock';
@@ -268,22 +264,6 @@ export const E2eTestRoot: React.FC = () => {
fps={30}
durationInFrames={90}
/>
- <Composition
- id="transcription-audio-e2e"
- component={TranscriptionAudioE2e}
- width={1080}
- height={1080}
- fps={30}
- durationInFrames={90}
- />
- <Composition
- id="transcription-legacy-media-e2e"
- component={TranscriptionLegacyMediaE2e}
- width={1080}
- height={1080}
- fps={30}
- durationInFrames={90}
- />
<NewVideoComp />
</>
);
diff --git a/packages/example/src/TranscriptionE2e.tsx b/packages/example/src/TranscriptionE2e.tsx
deleted file mode 100644
index fdca2a71f0..0000000000
--- a/packages/example/src/TranscriptionE2e.tsx
+++ /dev/null
@@ -1,16 +0,0 @@
-import {Audio as MediaAudio} from '@remotion/media';
-import React from 'react';
-import {Audio as LegacyAudio, staticFile, Video as LegacyVideo} from 'remotion';
-
-export const TranscriptionAudioE2e: React.FC = () => {
- return <MediaAudio name="<Audio>" src={staticFile('chirp.wav')} />;
-};
-
-export const TranscriptionLegacyMediaE2e: React.FC = () => {
- return (
- <>
- <LegacyVideo name="vp8-vorbis.webm" src={staticFile('vp8-vorbis.webm')} />
- <LegacyAudio name="<Legacy Audio>" src={staticFile('chirp.wav')} />
- </>
- );
-};
diff --git a/packages/studio/src/components/SelectedOutlineElement.tsx b/packages/studio/src/components/SelectedOutlineElement.tsx
index 74360dbc54..91f2338cac 100644
--- a/packages/studio/src/components/SelectedOutlineElement.tsx
+++ b/packages/studio/src/components/SelectedOutlineElement.tsx
@@ -37,7 +37,6 @@ import {
} from './Timeline/TimelineSelection';
import {getOriginalLocationFromStack} from './Timeline/TimelineStack/get-stack';
import {useDeleteTimelineItems} from './Timeline/use-delete-timeline-items';
-import {isTranscribableSequence} from './Transcription/is-transcribable-sequence';
import {
useDefaultCodingAgentInfo,
useEditorOpening,
@@ -225,12 +224,6 @@ const SelectedOutlineElementUnmemoized: React.FC<
previewServerState.type === 'connected';
const canCrop = contextMenuTarget.canCrop && !sourceEditDisabled;
const canRotate = !sourceEditDisabled;
- const transcribableMedia = isTranscribableSequence(
- contextMenuTarget.sequence,
- )
- ? contextMenuTarget.sequence
- : null;
-
return getSequenceContextMenuItems({
assetLinkInfo,
canOpenInEditor,
@@ -288,20 +281,6 @@ const SelectedOutlineElementUnmemoized: React.FC<
confirm,
).catch(() => undefined);
},
- onTranscribe:
- sourceEditingEnabled &&
- previewServerState.type === 'connected' &&
- transcribableMedia !== null
- ? () => {
- setSelectedModal({
- type: 'transcribe',
- src: transcribableMedia.src,
- displayName: transcribableMedia.displayName,
- audioStreamIndex: transcribableMedia.audioStreamIndex,
- requestInit: transcribableMedia.requestInit,
- });
- }
- : null,
openInCodingAgent: (codingAgentId, codingAgentName, contextForAgents) => {
launchCodingAgent(codingAgentId, contextForAgents)
.then((response) => {
diff --git a/packages/studio/src/components/Timeline/TimelineSequence.tsx b/packages/studio/src/components/Timeline/TimelineSequence.tsx
index 2bd3be86d8..c5e86cd277 100644
--- a/packages/studio/src/components/Timeline/TimelineSequence.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequence.tsx
@@ -41,7 +41,6 @@ import {AudioWaveform} from '../AudioWaveform';
import {useConfirmationDialog} from '../ConfirmationDialog';
import {ContextMenu} from '../ContextMenu';
import {useSelectComposition} from '../InitialCompositionLoader';
-import {isTranscribableSequence} from '../Transcription/is-transcribable-sequence';
import {useSelectAsset} from '../use-select-asset';
import {disableSequenceInteractivity} from './disable-sequence-interactivity';
import {duplicateSequencesFromSource} from './duplicate-selected-timeline-item';
@@ -607,20 +606,6 @@ const TimelineSequenceInner: React.FC<{
s.type === 'audio' || s.type === 'video' || s.type === 'image'
? s.src
: null;
- const transcribableMedia = isTranscribableSequence(s) ? s : null;
- const onTranscribe = useCallback(() => {
- if (!previewInteractive || transcribableMedia === null) {
- return;
- }
-
- setSelectedModal({
- type: 'transcribe',
- src: transcribableMedia.src,
- displayName: transcribableMedia.displayName,
- audioStreamIndex: transcribableMedia.audioStreamIndex,
- requestInit: transcribableMedia.requestInit,
- });
- }, [previewInteractive, setSelectedModal, transcribableMedia]);
const onDuplicateSequenceFromSource = useCallback(() => {
if (!validatedLocation?.source || !nodePathInfo || duplicateDisabled) {
return;
@@ -752,8 +737,6 @@ const TimelineSequenceInner: React.FC<{
onDeleteSequenceFromSource,
onDisableSequenceInteractivity,
onDuplicateSequenceFromSource,
- onTranscribe:
- previewInteractive && transcribableMedia !== null ? onTranscribe : null,
openInCodingAgent,
openInEditor,
originalLocation,
@@ -784,7 +767,6 @@ const TimelineSequenceInner: React.FC<{
onDisableSequenceInteractivity,
onDuplicateSequenceFromSource,
onDuplicateSelectedSequences,
- onTranscribe,
openInCodingAgent,
openInEditor,
originalLocation,
@@ -800,7 +782,6 @@ const TimelineSequenceInner: React.FC<{
sequenceFrameOffset,
setPropStatuses,
setSelectedModal,
- transcribableMedia,
validatedLocation?.source,
]);
const {frozenFrame} = s;
diff --git a/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx b/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx
index 4b6628f6fa..8c1ebd7857 100644
--- a/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx
@@ -69,7 +69,6 @@ import {
cropFieldKeys,
rotateFieldKey,
} from '../selected-outline-types';
-import {isTranscribableSequence} from '../Transcription/is-transcribable-sequence';
import {useSelectAsset} from '../use-select-asset';
import {disableSequenceInteractivity} from './disable-sequence-interactivity';
import {duplicateSequencesFromSource} from './duplicate-selected-timeline-item';
@@ -813,23 +812,6 @@ const TimelineSequenceItemInner: React.FC<{
sequence.type === 'image'
? sequence.src
: null;
- const transcribableMedia = isTranscribableSequence(sequence)
- ? sequence
- : null;
- const onTranscribe = useCallback(() => {
- if (!previewInteractive || transcribableMedia === null) {
- return;
- }
-
- setSelectedModal({
- type: 'transcribe',
- src: transcribableMedia.src,
- displayName: transcribableMedia.displayName,
- audioStreamIndex: transcribableMedia.audioStreamIndex,
- requestInit: transcribableMedia.requestInit,
- });
- }, [previewInteractive, setSelectedModal, transcribableMedia]);
-
const isExpanded =
previewConnected && nodePathInfo !== null && getIsExpanded(nodePathInfo);
@@ -1203,8 +1185,6 @@ const TimelineSequenceItemInner: React.FC<{
onDeleteSequenceFromSource,
onDisableSequenceInteractivity,
onDuplicateSequenceFromSource,
- onTranscribe:
- previewInteractive && transcribableMedia !== null ? onTranscribe : null,
openInCodingAgent,
openInEditor,
originalLocation,
@@ -1315,7 +1295,6 @@ const TimelineSequenceItemInner: React.FC<{
onDuplicateSelectedSequences,
onRenameSequence,
onSelect,
- onTranscribe,
openInCodingAgent,
openInEditor,
originalLocation,
@@ -1331,7 +1310,6 @@ const TimelineSequenceItemInner: React.FC<{
sequenceFrameOffset,
setSelectedModal,
setPropStatuses,
- transcribableMedia,
validatedLocation?.source,
]);
const canDropEffect =
diff --git a/packages/studio/src/components/Timeline/get-sequence-context-menu-items.ts b/packages/studio/src/components/Timeline/get-sequence-context-menu-items.ts
index 72993b5fd8..b2dd49095d 100644
--- a/packages/studio/src/components/Timeline/get-sequence-context-menu-items.ts
+++ b/packages/studio/src/components/Timeline/get-sequence-context-menu-items.ts
@@ -96,7 +96,6 @@ export const getSequenceContextMenuItems = ({
onDeleteSequenceFromSource,
onDisableSequenceInteractivity,
onDuplicateSequenceFromSource,
- onTranscribe,
openInCodingAgent,
openInEditor,
originalLocation,
@@ -117,7 +116,6 @@ export const getSequenceContextMenuItems = ({
readonly onDeleteSequenceFromSource: () => void;
readonly onDisableSequenceInteractivity: () => void;
readonly onDuplicateSequenceFromSource: () => void;
- readonly onTranscribe: (() => void) | null;
readonly openInCodingAgent: (
codingAgentId: DefaultCodingAgent,
codingAgentName: string,
@@ -253,21 +251,7 @@ export const getSequenceContextMenuItems = ({
value: 'show-asset',
}
: null,
- onTranscribe
- ? {
- type: 'item' as const,
- id: 'transcribe',
- keyHint: null,
- label: 'Transcribe',
- leftItem: null,
- disabled: false,
- onClick: onTranscribe,
- quickSwitcherLabel: null,
- subMenu: null,
- value: 'transcribe',
- }
- : null,
- assetLinkInfo || onTranscribe
+ assetLinkInfo
? {
type: 'divider' as const,
id: 'sequence-link-divider',
diff --git a/packages/studio/src/components/Transcription/is-transcribable-sequence.ts b/packages/studio/src/components/Transcription/is-transcribable-sequence.ts
deleted file mode 100644
index e8cae50662..0000000000
--- a/packages/studio/src/components/Transcription/is-transcribable-sequence.ts
+++ /dev/null
@@ -1,29 +0,0 @@
-import type {TSequence} from 'remotion';
-
-export type TranscribableSequence =
- | Extract<TSequence, {type: 'audio'}>
- | Extract<TSequence, {type: 'video'}>;
-
-const modernComponentIdentities = {
- audio: 'dev.remotion.media.Audio',
- video: 'dev.remotion.media.Video',
-} as const;
-
-const legacyDocumentationLinks = {
- audio: 'https://www.remotion.dev/docs/html5-audio',
- video: 'https://www.remotion.dev/docs/html5-video',
-} as const;
-
-export const isTranscribableSequence = (
- sequence: TSequence,
-): sequence is TranscribableSequence => {
- if (sequence.type !== 'audio' && sequence.type !== 'video') {
- return false;
- }
-
- return (
- sequence.controls?.componentIdentity ===
- modernComponentIdentities[sequence.type] ||
- sequence.documentationLink === legacyDocumentationLinks[sequence.type]
- );
-};
diff --git a/packages/studio/src/test/sequence-context-menu-items.test.ts b/packages/studio/src/test/sequence-context-menu-items.test.ts
index 0e10558d7e..a94fdc3a1f 100644
--- a/packages/studio/src/test/sequence-context-menu-items.test.ts
+++ b/packages/studio/src/test/sequence-context-menu-items.test.ts
@@ -10,7 +10,6 @@ import {
isSequenceVisibleAtTimelinePosition,
shouldShowFreezeFrameMenuItem,
} from '../components/Timeline/use-sequence-freeze-frame-menu-item';
-import {isTranscribableSequence} from '../components/Transcription/is-transcribable-sequence';
const originalWindowDescriptor = Object.getOwnPropertyDescriptor(
globalThis,
@@ -70,44 +69,6 @@ const renameSequenceItem: ComboboxValue = {
const noop = () => undefined;
-test('recognizes current and legacy Audio and Video timeline sequences', () => {
- for (const [type, componentIdentity, documentationLink] of [
- [
- 'audio',
- 'dev.remotion.media.Audio',
- 'https://www.remotion.dev/docs/html5-audio',
- ],
- [
- 'video',
- 'dev.remotion.media.Video',
- 'https://www.remotion.dev/docs/html5-video',
- ],
- ] as const) {
- expect(
- isTranscribableSequence({
- type,
- controls: {componentIdentity},
- documentationLink: null,
- } as unknown as TSequence),
- ).toBe(true);
- expect(
- isTranscribableSequence({
- type,
- controls: null,
- documentationLink,
- } as unknown as TSequence),
- ).toBe(true);
- }
-
- expect(
- isTranscribableSequence({
- type: 'video',
- controls: null,
- documentationLink: 'https://www.remotion.dev/docs/offthreadvideo',
- } as unknown as TSequence),
- ).toBe(false);
-});
-
test('copy context menu items write their agent context to the clipboard', () => {
const copiedTexts: string[] = [];
Object.defineProperty(globalThis, 'navigator', {
@@ -180,7 +141,6 @@ const expectNoExtraDividers = (items: ComboboxValue[]) => {
test('sequence context menu normalizes dividers before source actions', () => {
installTestWindow();
- let transcribed = false;
const items = getSequenceContextMenuItems({
assetLinkInfo: null,
@@ -196,9 +156,6 @@ test('sequence context menu normalizes dividers before source actions', () => {
onDeleteSequenceFromSource: noop,
onDisableSequenceInteractivity: noop,
onDuplicateSequenceFromSource: noop,
- onTranscribe: () => {
- transcribed = true;
- },
openInCodingAgent: noop,
openInEditor: noop,
originalLocation: null,
@@ -218,15 +175,7 @@ test('sequence context menu normalizes dividers before source actions', () => {
expect(
items.slice(copyContextIndex + 1, renameIndex).map((item) => item.type),
- ).toEqual(['item', 'divider']);
-
- const transcribe = items.find((item) => item.id === 'transcribe');
- if (transcribe?.type !== 'item') {
- throw new Error('Expected Transcribe menu item');
- }
-
- transcribe.onClick('transcribe', null);
- expect(transcribed).toBe(true);
+ ).toEqual(['divider']);
});
test('sequence context menu shares alternate apps without repeating defaults', () => {
@@ -281,7 +230,6 @@ test('sequence context menu shares alternate apps without repeating defaults', (
onDeleteSequenceFromSource: noop,
onDisableSequenceInteractivity: noop,
onDuplicateSequenceFromSource: noop,
- onTranscribe: null,
openInCodingAgent: (codingAgentId, _codingAgentName, prompt) => {
openedCodingAgents.push({id: codingAgentId, prompt});
},
@@ -385,7 +333,6 @@ test('Interactive.Svg context menu can copy the rendered SVG', () => {
onDeleteSequenceFromSource: noop,
onDisableSequenceInteractivity: noop,
onDuplicateSequenceFromSource: noop,
- onTranscribe: null,
openInCodingAgent: noop,
openInEditor: noop,
originalLocation: null,
@@ -430,7 +377,6 @@ test('programmatically duplicated sequence menus apply actions to all instances'
onDeleteSequenceFromSource: noop,
onDisableSequenceInteractivity: noop,
onDuplicateSequenceFromSource: noop,
- onTranscribe: null,
openInCodingAgent: noop,
openInEditor: noop,
originalLocation: null,
@@ -465,7 +411,6 @@ test('read-only sequence menus only contain non-mutating actions', () => {
onDeleteSequenceFromSource: noop,
onDisableSequenceInteractivity: noop,
onDuplicateSequenceFromSource: noop,
- onTranscribe: null,
openInCodingAgent: noop,
openInEditor: noop,
originalLocation: null,