Skip to content

🎥 Make videos programmatically with React

`@remotion/studio`: Prevent Browser Studio render server requests (#10635)

Jonny Burger52587f1e0251
diff --git a/packages/browser-studio/e2e/browser-studio.test.ts b/packages/browser-studio/e2e/browser-studio.test.ts
index fc34fa1c32..f749c3509d 100644
--- a/packages/browser-studio/e2e/browser-studio.test.ts
+++ b/packages/browser-studio/e2e/browser-studio.test.ts
@@ -10,6 +10,7 @@ test('loads Browser Studio and can add, delete, and duplicate', async ({
const pageErrors: Error[] = [];
const applyCodemodRequests: string[] = [];
const remoteRemotionRequests: string[] = [];
+ const renderPersistenceRequests: string[] = [];
const updateAvailableRequests: string[] = [];
const workspacePackageRequests: string[] = [];
let rejectPageError: (error: Error) => void = () => undefined;
@@ -26,6 +27,13 @@ test('loads Browser Studio and can add, delete, and duplicate', async ({
updateAvailableRequests.push(request.url());
}
+ if (
+ requestUrl.pathname === '/api/upload-output' ||
+ requestUrl.pathname === '/api/register-client-render'
+ ) {
+ renderPersistenceRequests.push(request.url());
+ }
+
if (
requestUrl.pathname.startsWith('/__remotion_browser_studio_workspace__/')
) {
@@ -61,11 +69,14 @@ test('loads Browser Studio and can add, delete, and duplicate', async ({
await expect(
studio.getByText('Input Props', {exact: true}),
).toBeVisible();
- await page.keyboard.press('Escape');
- await studio.locator('[data-sidebar-toggle="right"]').click();
- await expect(
- studio.getByRole('button', {name: 'Inspector'}),
- ).toBeVisible();
+ await studio.getByText('Still', {exact: true}).click();
+ const downloadPromise = page.waitForEvent('download');
+ await studio.getByRole('button', {name: 'Render still'}).click();
+ const download = await downloadPromise;
+ expect(download.suggestedFilename()).toBe('MyComp.png');
+ const inspector = studio.getByRole('button', {name: 'Inspector'});
+ await expect(inspector).toBeVisible();
+ await inspector.click();
await studio.getByRole('button', {name: 'Add Solid'}).click();
const solid = studio.getByText('<Solid>', {exact: true});
await expect(solid).toBeVisible();
@@ -132,6 +143,7 @@ test('loads Browser Studio and can add, delete, and duplicate', async ({
);
expect(remoteRemotionRequests).toEqual([]);
expect(applyCodemodRequests).toEqual([]);
+ expect(renderPersistenceRequests).toEqual([]);
expect(updateAvailableRequests).toEqual([]);
});
diff --git a/packages/studio/src/components/RenderQueue/ClientRenderQueueProcessor.tsx b/packages/studio/src/components/RenderQueue/ClientRenderQueueProcessor.tsx
index 9d8cac7772..97d0f732e3 100644
--- a/packages/studio/src/components/RenderQueue/ClientRenderQueueProcessor.tsx
+++ b/packages/studio/src/components/RenderQueue/ClientRenderQueueProcessor.tsx
@@ -10,6 +10,7 @@ import {
registerClientRender,
saveOutputFile,
} from '../../api/save-render-output';
+import {getBrowserStudioOperations} from '../../helpers/browser-studio-operations';
import {downloadBlob} from '../../helpers/download-blob';
import type {
ClientRenderJob,
@@ -186,7 +187,10 @@ export const ClientRenderQueueProcessor: React.FC = () => {
markClientJobDone(job.id, metadata, getBlob);
};
- if (window.remotion_isReadOnlyStudio) {
+ if (
+ window.remotion_isReadOnlyStudio ||
+ getBrowserStudioOperations() !== null
+ ) {
downloadAndFinish();
} else {
try {