Skip to content

🎥 Make videos programmatically with React

refactor: require nullable pitch preference in internal render assets

JonnyBurger54961cf944eb
diff --git a/packages/core/src/CompositionManager.tsx b/packages/core/src/CompositionManager.tsx
index 43a7073dc3..c01fbee00d 100644
--- a/packages/core/src/CompositionManager.tsx
+++ b/packages/core/src/CompositionManager.tsx
@@ -158,7 +158,7 @@ export type AudioOrVideoAsset = {
toneFrequency: number;
audioStartFrame: number;
audioStreamIndex: number;
- preservePitch?: boolean;
+ preservePitch: boolean | null;
};
export type InlineAudioAsset = {
diff --git a/packages/core/src/no-react.ts b/packages/core/src/no-react.ts
index a0e96a18c1..87bd0308a7 100644
--- a/packages/core/src/no-react.ts
+++ b/packages/core/src/no-react.ts
@@ -1,9 +1,19 @@
-export type {
+import type {
ArtifactAsset,
- AudioOrVideoAsset,
+ AudioOrVideoAsset as InternalAudioOrVideoAsset,
InlineAudioAsset,
- TRenderAsset,
} from './CompositionManager';
+export type {ArtifactAsset, InlineAudioAsset} from './CompositionManager';
+
+// Older consumers can still supply assets without a pitch preference.
+export type AudioOrVideoAsset = Omit<
+ InternalAudioOrVideoAsset,
+ 'preservePitch'
+> & {
+ preservePitch?: boolean | null;
+};
+
+export type TRenderAsset = AudioOrVideoAsset | ArtifactAsset | InlineAudioAsset;
export type {DownloadBehavior} from './download-behavior';
export {
assertValidInterpolateEasingOption,
diff --git a/packages/renderer/src/test/calculate-asset-positions.test.ts b/packages/renderer/src/test/calculate-asset-positions.test.ts
index 7f08b45e32..0ced7dc2a1 100644
--- a/packages/renderer/src/test/calculate-asset-positions.test.ts
+++ b/packages/renderer/src/test/calculate-asset-positions.test.ts
@@ -25,6 +25,7 @@ const makeAsset = ({
playbackRate: 1,
mediaFrame: mediaFrame ?? frame,
toneFrequency: 1,
+ preservePitch: null,
audioStartFrame: 0,
audioStreamIndex: 0,
};