Skip to content

🎥 Make videos programmatically with React

Internal: Require nullable inline audio start

JonnyBurger63cb7962658d
diff --git a/packages/core/src/CompositionManager.tsx b/packages/core/src/CompositionManager.tsx
index 09c0205069..af3ab24bc2 100644
--- a/packages/core/src/CompositionManager.tsx
+++ b/packages/core/src/CompositionManager.tsx
@@ -162,7 +162,7 @@ export type InlineAudioAsset = {
id: string;
audio: Int16Array | number[];
frame: number;
- startInVideo?: number;
+ startInVideo: number | null;
timestamp: number;
duration: number;
toneFrequency: number;
diff --git a/packages/renderer/src/test/inline-audio-mixing.test.ts b/packages/renderer/src/test/inline-audio-mixing.test.ts
index db721c197f..6bc835bc80 100644
--- a/packages/renderer/src/test/inline-audio-mixing.test.ts
+++ b/packages/renderer/src/test/inline-audio-mixing.test.ts
@@ -18,7 +18,7 @@ const makeAsset = ({
}: {
id: string;
frame: number;
- startInVideo: number | undefined;
+ startInVideo: number | null;
}): InlineAudioAsset => ({
type: 'inline-audio',
id,
@@ -84,7 +84,7 @@ test('keeps a composition-relative fallback for an unknown clip origin', async (
try {
mixing.addAsset({
- asset: makeAsset({id: 'unknown', frame: 3, startInVideo: undefined}),
+ asset: makeAsset({id: 'unknown', frame: 3, startInVideo: null}),
fps: FPS,
totalNumberOfFrames: 4,
firstFrame: 0,