🎥 Make videos programmatically with React
Allow muted video preview with unsupported audio
Alec Watts6b533df89a10
diff --git a/packages/media/src/media-player.ts b/packages/media/src/media-player.tsindex e0784637f4..4ba36d1e42 100644--- a/packages/media/src/media-player.ts+++ b/packages/media/src/media-player.ts@@ -67,6 +67,8 @@ export class MediaPlayer {private sharedAudioContext: SharedAudioContextForMediaPlayer | null;audioIteratorManager: AudioIteratorManager | null = null;+ private muted = false;+ private unsupportedAudioError: Error | null = null;videoIteratorManager: VideoIteratorManager | null = null;private playing = false;@@ -250,6 +252,7 @@ export class MediaPlayer {initialMuted: boolean,initialVolume: number,): Promise<MediaPlayerInitResult> {+ this.muted = initialMuted;const promise = this._initialize(startTimeUnresolved,initialMuted,@@ -423,7 +426,7 @@ export class MediaPlayer {}const canDecode = await audioTrack.canDecode();- if (!canDecode) {+ if (!canDecode && !this.muted) {return {type: 'cannot-decode'};}@@ -431,22 +434,30 @@ export class MediaPlayer {return {type: 'disposed'};}- this.audioIteratorManager = audioIteratorManager({- audioTrack,- delayPlaybackHandleIfNotPremounting:- this.delayPlaybackHandleIfNotPremounting,- sharedAudioContext: this.sharedAudioContext,- getMediaEndTimestamp: () => this.getMediaEndTimestamp(),- getSequenceEndTimestamp: () => this.getSequenceEndTimestamp(),- getStartTime: () => this.getStartTime(),- initialMuted,- initialVolume,- toneFrequency: this.toneFrequency,- drawDebugOverlay: this.drawDebugOverlay,- onError: (error) => this.reportTerminalError(error),- getSequenceDurationInSeconds: () =>- this.getSequenceDurationInSeconds(),- });+ if (canDecode) {+ this.audioIteratorManager = audioIteratorManager({+ audioTrack,+ delayPlaybackHandleIfNotPremounting:+ this.delayPlaybackHandleIfNotPremounting,+ sharedAudioContext: this.sharedAudioContext,+ getMediaEndTimestamp: () => this.getMediaEndTimestamp(),+ getSequenceEndTimestamp: () => this.getSequenceEndTimestamp(),+ getStartTime: () => this.getStartTime(),+ initialMuted,+ initialVolume,+ toneFrequency: this.toneFrequency,+ drawDebugOverlay: this.drawDebugOverlay,+ onError: (error) => this.reportTerminalError(error),+ getSequenceDurationInSeconds: () =>+ this.getSequenceDurationInSeconds(),+ });+ } else {+ // Muted video can draw without an audio decoder. Report the+ // unavailable audio if the caller later requests sound.+ this.unsupportedAudioError = new Error(+ `Cannot decode audio for ${this.src}.`,+ );+ }}const nonce = this.nonceManager.createAsyncOperation();@@ -632,6 +643,12 @@ export class MediaPlayer {}public setMuted(muted: boolean): void {+ this.muted = muted;+ if (!muted && this.unsupportedAudioError) {+ this.reportTerminalError(this.unsupportedAudioError);+ return;+ }+this.audioIteratorManager?.setMuted(muted);}diff --git a/packages/media/src/test/media-player.test.ts b/packages/media/src/test/media-player.test.tsindex ad43ab8649..66157c20b4 100644--- a/packages/media/src/test/media-player.test.ts+++ b/packages/media/src/test/media-player.test.ts@@ -1,4 +1,9 @@-import {AudioBufferSink, CanvasSink, InputVideoTrack} from 'mediabunny';+import {+ AudioBufferSink,+ CanvasSink,+ InputAudioTrack,+ InputVideoTrack,+} from 'mediabunny';import type {EffectDefinitionAndStack} from 'remotion';import {Internals} from 'remotion';import {expect, test, vi} from 'vitest';@@ -488,3 +493,39 @@ test('disposal clears a rendered canvas only once', async () => {await player.dispose();}});++// Regression: unsupported audio blocked even the muted video surface.+test('draws muted video with unsupported audio and reports it on unmute', async () => {+ const support = vi+ .spyOn(InputAudioTrack.prototype, 'canDecode')+ .mockResolvedValue(false);+ const errors: Error[] = [];+ let frames = 0;+ const sharedAudioContext = makeSharedAudioContext();+ const player = makeAudioPlayer(+ sharedAudioContext,+ (error) => errors.push(error),+ 'video',+ {+ src: '/bigbuckbunny.mp4',+ canvas: document.createElement('canvas'),+ onVideoFrameCallback: () => {+ frames++;+ },+ },+ );+ try {+ expect((await player.initialize(0, true, 1)).type).toBe('success');+ expect(frames).toBeGreaterThan(0);+ expect(errors).toHaveLength(0);+ player.setMuted(false);+ expect(errors).toHaveLength(1);+ expect(errors[0].message).toContain('Cannot decode audio');+ player.setMuted(false);+ expect(errors).toHaveLength(1);+ } finally {+ await player.dispose();+ await sharedAudioContext.audioContext.close();+ support.mockRestore();+ }+});