Skip to content

🎥 Make videos programmatically with React

Remove obsolete sequence transcription metadata

JonnyBurger7e76fa11aa2b
diff --git a/packages/core/src/CompositionManager.tsx b/packages/core/src/CompositionManager.tsx
index 98969cc10f..2848d97d70 100644
--- a/packages/core/src/CompositionManager.tsx
+++ b/packages/core/src/CompositionManager.tsx
@@ -72,8 +72,6 @@ type EnhancedTSequenceData =
| {
type: 'audio';
src: string;
- audioStreamIndex: number | null;
- requestInit: Omit<RequestInit, 'signal'> | null;
// Volume is represented as a comma separated list - if it's a string
// React can more efficiently update and will not rerender if anonymous functions
// are passed.
@@ -89,8 +87,6 @@ type EnhancedTSequenceData =
| {
type: 'video';
src: string;
- audioStreamIndex: number | null;
- requestInit: Omit<RequestInit, 'signal'> | null;
volume: string | number;
doesVolumeChange: boolean;
muted: boolean;
diff --git a/packages/core/src/Sequence.tsx b/packages/core/src/Sequence.tsx
index 1bd5710f87..d40f0db0d3 100644
--- a/packages/core/src/Sequence.tsx
+++ b/packages/core/src/Sequence.tsx
@@ -508,8 +508,6 @@ const RegularSequenceRefForwardingFunction: React.ForwardRefRenderFunction<
showInTimeline,
timelineOrder: null,
src: isMedia.data.src,
- audioStreamIndex: isMedia.data.audioStreamIndex,
- requestInit: isMedia.data.requestInit,
getStack: () => stackRef.current,
startMediaFrom: startMediaFrom ?? isMedia.data.startMediaFrom,
mediaFrameAtSequenceZero,
diff --git a/packages/core/src/audio/AudioForPreview.tsx b/packages/core/src/audio/AudioForPreview.tsx
index cb6b6de640..1af9b0cc27 100644
--- a/packages/core/src/audio/AudioForPreview.tsx
+++ b/packages/core/src/audio/AudioForPreview.tsx
@@ -192,8 +192,6 @@ const AudioForDevelopmentForwardRefFunction: React.ForwardRefRenderFunction<
documentationLink: 'https://www.remotion.dev/docs/html5-audio',
refForOutline: null,
muted: muted ?? false,
- audioStreamIndex: audioStreamIndex ?? null,
- requestInit: null,
});
// putting playback before useVolume
diff --git a/packages/core/src/test/sequence-register-once.test.tsx b/packages/core/src/test/sequence-register-once.test.tsx
index b29b99ec70..6f5eac2f24 100644
--- a/packages/core/src/test/sequence-register-once.test.tsx
+++ b/packages/core/src/test/sequence-register-once.test.tsx
@@ -227,8 +227,6 @@ const makeMediaInTimelineData = ({
startMediaFrom,
src: 'video.mp4',
playbackRate,
- audioStreamIndex: 3,
- requestInit: {credentials: 'include'},
}) as unknown as BasicMediaInTimelineReturnType;
test('Sequence calls registerSequence exactly once on mount', () => {
@@ -1173,8 +1171,6 @@ test('Video media registration accounts for its own negative from', () => {
expect(videoSequence?.startMediaFrom).toBe(15);
expect(videoSequence?.mediaFrameAtSequenceZero).toBe(5);
- expect(videoSequence?.audioStreamIndex).toBe(3);
- expect(videoSequence?.requestInit).toEqual({credentials: 'include'});
});
test('Video media registration keeps trimBefore at sequence frame zero', () => {
diff --git a/packages/core/src/test/use-media-in-timeline.test.tsx b/packages/core/src/test/use-media-in-timeline.test.tsx
index 249a1e920d..d5b9d74e52 100644
--- a/packages/core/src/test/use-media-in-timeline.test.tsx
+++ b/packages/core/src/test/use-media-in-timeline.test.tsx
@@ -86,11 +86,6 @@ test('useMediaInTimeline registers muted changes and unregisters the sequence',
documentationLink: null,
refForOutline: null,
muted,
- audioStreamIndex: 2,
- requestInit: {
- credentials: 'include',
- headers: {'x-remotion-test': 'timeline'},
- },
}),
{
wrapper,
@@ -99,11 +94,6 @@ test('useMediaInTimeline registers muted changes and unregisters the sequence',
);
expect(registerSequence).toHaveBeenCalled();
expect(registerSequence.mock.calls[0]?.[0]).toMatchObject({
- audioStreamIndex: 2,
- requestInit: {
- credentials: 'include',
- headers: {'x-remotion-test': 'timeline'},
- },
mediaFrameAtSequenceZero: null,
muted: false,
});
@@ -159,8 +149,6 @@ test('useMediaInTimeline keeps documentation links for custom display names', ()
documentationLink: 'https://www.remotion.dev/docs/html5-video',
refForOutline: null,
muted: false,
- audioStreamIndex: null,
- requestInit: null,
}),
{
wrapper,
diff --git a/packages/core/src/use-media-in-timeline.ts b/packages/core/src/use-media-in-timeline.ts
index f014956663..ae0c54a1e2 100644
--- a/packages/core/src/use-media-in-timeline.ts
+++ b/packages/core/src/use-media-in-timeline.ts
@@ -35,8 +35,6 @@ export const useBasicMediaInTimeline = ({
mediaStartsAt,
loop,
muted,
- audioStreamIndex,
- requestInit,
}: {
volume: VolumeProp | undefined;
mediaVolume: number;
@@ -50,8 +48,6 @@ export const useBasicMediaInTimeline = ({
mediaStartsAt: number;
loop: boolean;
muted: boolean;
- audioStreamIndex: number | null;
- requestInit: Omit<RequestInit, 'signal'> | null;
}) => {
if (!src) {
throw new Error('No src passed');
@@ -117,8 +113,6 @@ export const useBasicMediaInTimeline = ({
src,
playbackRate,
muted,
- audioStreamIndex,
- requestInit,
};
}, [
volumes,
@@ -129,8 +123,6 @@ export const useBasicMediaInTimeline = ({
startMediaFrom,
playbackRate,
muted,
- audioStreamIndex,
- requestInit,
]);
return memoizedResult;
@@ -156,8 +148,6 @@ export const useMediaInTimeline = ({
documentationLink,
refForOutline,
muted,
- audioStreamIndex,
- requestInit,
}: {
volume: VolumeProp | undefined;
mediaVolume: number;
@@ -174,8 +164,6 @@ export const useMediaInTimeline = ({
documentationLink: string | null;
refForOutline: React.RefObject<Element | null> | null;
muted: boolean;
- audioStreamIndex: number | null;
- requestInit: Omit<RequestInit, 'signal'> | null;
}) => {
const parentSequence = useContext(SequenceContext);
const startsAt = useMediaStartsAt();
@@ -197,8 +185,6 @@ export const useMediaInTimeline = ({
mediaStartsAt,
loop: false,
muted,
- audioStreamIndex,
- requestInit,
});
const {isStudio} = useRemotionEnvironment();
@@ -212,8 +198,6 @@ export const useMediaInTimeline = ({
effectRuntimeValues: null,
type: mediaType,
src,
- audioStreamIndex,
- requestInit,
id,
duration,
from: 0,
@@ -258,8 +242,6 @@ export const useMediaInTimeline = ({
finalDisplayName,
refForOutline,
muted,
- audioStreamIndex,
- requestInit,
]);
const registrationEnabled =
isStudio ||
diff --git a/packages/core/src/video/VideoForPreview.tsx b/packages/core/src/video/VideoForPreview.tsx
index b4eb1339d8..9694b0b5c0 100644
--- a/packages/core/src/video/VideoForPreview.tsx
+++ b/packages/core/src/video/VideoForPreview.tsx
@@ -181,8 +181,6 @@ const VideoForDevelopmentRefForwardingFunction: React.ForwardRefRenderFunction<
: 'https://www.remotion.dev/docs/html5-video',
refForOutline: videoRef,
muted: muted ?? false,
- audioStreamIndex: audioStreamIndex ?? 0,
- requestInit: null,
});
// putting playback before useVolume
diff --git a/packages/media/src/audio/audio.tsx b/packages/media/src/audio/audio.tsx
index f91ee4856c..9f112992ce 100644
--- a/packages/media/src/audio/audio.tsx
+++ b/packages/media/src/audio/audio.tsx
@@ -9,7 +9,6 @@ import {
type SequenceControls,
type InteractivitySchema,
} from 'remotion';
-import {resolveRequestInit} from '../request-init';
import {getLoopDisplay} from '../show-in-timeline';
import {validateToneFrequency} from '../validate-tone-frequency';
import {AudioForPreview} from './audio-for-preview';
@@ -86,13 +85,6 @@ const AudioInner: React.FC<
const [mediaVolume] = Internals.useMediaVolumeState();
const mediaStartsAt = Internals.useMediaStartsAt();
const videoConfig = useVideoConfig();
- const [resolvedRequestInit] = useState(
- () =>
- resolveRequestInit({
- credentials: props.credentials,
- requestInit: props.requestInit,
- }) ?? null,
- );
const sequenceDurationInFrames = Math.min(
durationInFrames ?? Infinity,
Math.max(0, videoConfig.durationInFrames - (from ?? 0)),
@@ -111,8 +103,6 @@ const AudioInner: React.FC<
mediaStartsAt,
loop: props.loop ?? false,
muted: props.muted ?? false,
- audioStreamIndex: props.audioStreamIndex ?? null,
- requestInit: resolvedRequestInit,
});
// TODO: Redundant with what we do in the Studio
diff --git a/packages/media/src/video/video.tsx b/packages/media/src/video/video.tsx
index 156e579655..9046bf97ff 100644
--- a/packages/media/src/video/video.tsx
+++ b/packages/media/src/video/video.tsx
@@ -9,7 +9,6 @@ import {
type SequenceControls,
type InteractivitySchema,
} from 'remotion';
-import {resolveRequestInit} from '../request-init';
import {getLoopDisplay} from '../show-in-timeline';
import {validateToneFrequency} from '../validate-tone-frequency';
import {getVideoSequenceDuration} from './get-video-sequence-duration';
@@ -268,9 +267,6 @@ const VideoInner: React.FC<
const [mediaVolume] = Internals.useMediaVolumeState();
const mediaStartsAt = Internals.useMediaStartsAt();
const videoConfig = useVideoConfig();
- const [resolvedRequestInit] = useState(
- () => resolveRequestInit({credentials, requestInit}) ?? null,
- );
const sequenceDurationInFrames = Math.min(
durationInFrames ?? Infinity,
Math.max(0, videoConfig.durationInFrames - (from ?? 0)),
@@ -296,8 +292,6 @@ const VideoInner: React.FC<
mediaStartsAt,
loop: loop ?? false,
muted: muted ?? false,
- audioStreamIndex: audioStreamIndex ?? 0,
- requestInit: resolvedRequestInit,
});
// TODO: Redundant with what we do in the Studio