Skip to content

🎥 Make videos programmatically with React

test(studio): add minimum-duration trim repros and unit coverage

Jonny Burger8befe9fb5dad
diff --git a/packages/example/src/Root.tsx b/packages/example/src/Root.tsx
index b6756ad2bf..7957abe688 100644
--- a/packages/example/src/Root.tsx
+++ b/packages/example/src/Root.tsx
@@ -341,10 +341,12 @@ import {
import {InteractivePaths} from './VisualModeTests/InteractivePaths';
import {Issue9170} from './VisualModeTests/Issue9170';
import {KeyframeDeleteFlash} from './VisualModeTests/KeyframeDeleteFlash';
+import {OneFrameTrimRepro} from './VisualModeTests/OneFrameTrimRepro';
import {OutlineSelectionCases} from './VisualModeTests/OutlineSelectionCases';
import {SequenceDurationInterpolation} from './VisualModeTests/SequenceDurationInterpolation';
import {SequenceShiftRepro} from './VisualModeTests/SequenceShiftRepro';
import {SvgPaintSchema} from './VisualModeTests/SvgPaintSchema';
+import {TimelineMinimumDurationRepro} from './VisualModeTests/TimelineMinimumDurationRepro';
import {VideoConfigExpressions} from './VisualModeTests/VideoConfigExpressions';
import {VoiceVisualization} from './voice-visualization';
import {WhisperWeb} from './WhisperWeb';
@@ -3102,6 +3104,22 @@ export const Index: React.FC = () => {
durationInFrames={300}
/>
<Folder name="VisualModeTests">
+ <Composition
+ id="timeline-minimum-duration-repro"
+ component={TimelineMinimumDurationRepro}
+ width={1280}
+ height={720}
+ fps={30}
+ durationInFrames={120}
+ />
+ <Composition
+ id="one-frame-trim-repro"
+ component={OneFrameTrimRepro}
+ width={1280}
+ height={720}
+ fps={30}
+ durationInFrames={600}
+ />
<Composition
id="SourceSubscriptionChurn"
component={SourceSubscriptionChurn}
diff --git a/packages/example/src/VisualModeTests/OneFrameTrimRepro.tsx b/packages/example/src/VisualModeTests/OneFrameTrimRepro.tsx
new file mode 100644
index 0000000000..cb94478714
--- /dev/null
+++ b/packages/example/src/VisualModeTests/OneFrameTrimRepro.tsx
@@ -0,0 +1,38 @@
+import React from 'react';
+import {
+ AbsoluteFill,
+ Sequence,
+ interpolate,
+ useCurrentFrame,
+ useVideoConfig,
+} from 'remotion';
+
+const Child: React.FC = () => {
+ const frame = useCurrentFrame();
+ const {durationInFrames} = useVideoConfig();
+
+ return (
+ <div
+ style={{
+ opacity: interpolate(frame, [0, durationInFrames - 1], [0, 1]),
+ }}
+ >
+ Child
+ </div>
+ );
+};
+
+export const OneFrameTrimRepro: React.FC = () => (
+ <AbsoluteFill
+ style={{backgroundColor: '#eee', color: '#111', fontSize: 28, padding: 40}}
+ >
+ <div>
+ Issue #11996: keep the playhead at frame 0 and trim &quot;Trim this
+ parent&quot; to one frame. The child&apos;s interpolation becomes [0, 0]
+ and throws.
+ </div>
+ <Sequence name="Trim this parent" durationInFrames={300} layout="none">
+ <Child />
+ </Sequence>
+ </AbsoluteFill>
+);
diff --git a/packages/example/src/VisualModeTests/TimelineMinimumDurationRepro.tsx b/packages/example/src/VisualModeTests/TimelineMinimumDurationRepro.tsx
new file mode 100644
index 0000000000..464a9d4fcb
--- /dev/null
+++ b/packages/example/src/VisualModeTests/TimelineMinimumDurationRepro.tsx
@@ -0,0 +1,82 @@
+import React from 'react';
+import {
+ AbsoluteFill,
+ Sequence,
+ useCurrentFrame,
+ useVideoConfig,
+} from 'remotion';
+
+const DurationReadout: React.FC<{readonly label: string}> = ({label}) => {
+ const frame = useCurrentFrame();
+ const {durationInFrames} = useVideoConfig();
+
+ return (
+ <div>
+ <div style={{fontWeight: 'bold', marginBottom: 16}}>{label}</div>
+ <div>Current local frame: {frame}</div>
+ <div>Local duration: {durationInFrames}</div>
+ <div>Remaining local frames: {durationInFrames - frame}</div>
+ </div>
+ );
+};
+
+export const TimelineMinimumDurationRepro: React.FC = () => {
+ return (
+ <AbsoluteFill
+ style={{
+ backgroundColor: '#111827',
+ color: 'white',
+ fontFamily: 'sans-serif',
+ fontSize: 28,
+ }}
+ >
+ <div style={{padding: 40}}>
+ Keep the playhead at frame 0 and drag either blue clip&apos;s right edge
+ past frame 0. It must keep one visible timeline frame.
+ </div>
+ <Sequence
+ name="Ancestor starts at -30"
+ from={-30}
+ durationInFrames={120}
+ layout="none"
+ >
+ <Sequence
+ name="Trim clipped child (minimum 31)"
+ durationInFrames={60}
+ style={{
+ top: 160,
+ left: 40,
+ width: 1200,
+ height: 220,
+ padding: 28,
+ backgroundColor: '#2563eb',
+ }}
+ >
+ <DurationReadout label="1× parent: minimum duration 31, remaining 1" />
+ </Sequence>
+ </Sequence>
+ <Sequence
+ name="2× ancestor starts at -30"
+ from={-30}
+ durationInFrames={240}
+ playbackRate={2}
+ layout="none"
+ >
+ <Sequence
+ name="Trim sped-up child (minimum 62)"
+ durationInFrames={120}
+ style={{
+ top: 400,
+ left: 40,
+ width: 1200,
+ height: 220,
+ padding: 28,
+ backgroundColor: '#2563eb',
+ }}
+ >
+ <DurationReadout label="2× parent: minimum duration 62, remaining 2" />
+ </Sequence>
+ </Sequence>
+ </AbsoluteFill>
+ );
+};
diff --git a/packages/studio/src/test/timeline-selection.test.ts b/packages/studio/src/test/timeline-selection.test.ts
index 909bc33657..6fb4cd7183 100644
--- a/packages/studio/src/test/timeline-selection.test.ts
+++ b/packages/studio/src/test/timeline-selection.test.ts
@@ -1930,6 +1930,113 @@ test('Timeline duration drag uses the declared duration for negative from values
).toEqual([]);
});
+test.each([
+ {
+ name: 'negative ancestor start',
+ parentFrom: -30,
+ parentPlaybackRate: 1,
+ parentTrimBefore: 0,
+ childFrom: 0,
+ childPlaybackRate: 1,
+ expectedDurationInFrames: 31,
+ },
+ {
+ name: 'positive child start under a negative ancestor',
+ parentFrom: -30,
+ parentPlaybackRate: 1,
+ parentTrimBefore: 0,
+ childFrom: 10,
+ childPlaybackRate: 1,
+ expectedDurationInFrames: 21,
+ },
+ {
+ name: 'ancestor trimBefore',
+ parentFrom: 0,
+ parentPlaybackRate: 1,
+ parentTrimBefore: 30,
+ childFrom: 0,
+ childPlaybackRate: 1,
+ expectedDurationInFrames: 31,
+ },
+ {
+ name: 'sped-up ancestor',
+ parentFrom: -30,
+ parentPlaybackRate: 2,
+ parentTrimBefore: 0,
+ childFrom: 0,
+ childPlaybackRate: 1,
+ expectedDurationInFrames: 62,
+ },
+ {
+ name: 'sped-up ancestor with a slowed-down child',
+ parentFrom: -30,
+ parentPlaybackRate: 2,
+ parentTrimBefore: 0,
+ childFrom: 0,
+ childPlaybackRate: 0.5,
+ expectedDurationInFrames: 31,
+ },
+])('Timeline duration drag retains one visible frame: $name', (scenario) => {
+ const schema = {} satisfies InteractivitySchema;
+ const nodePathInfo = makeNodePathInfo(['body', 0, 'children', 0], []);
+ const nodePath = nodePathInfo.sequenceSubscriptionKey;
+ const parent = makeTimelineSequence({
+ schema,
+ id: 'parent',
+ overrideId: 'parent',
+ from: scenario.parentFrom,
+ duration: 300,
+ trimBefore: scenario.parentTrimBefore,
+ sequencePlaybackRate: scenario.parentPlaybackRate,
+ });
+ const child = makeTimelineSequence({
+ schema,
+ id: 'child',
+ overrideId: 'child',
+ parentId: parent.id,
+ from: scenario.childFrom,
+ duration: 60 * scenario.parentPlaybackRate,
+ sequencePlaybackRate: scenario.childPlaybackRate,
+ });
+ const overrideIdsToNodePaths = {child: nodePath};
+ const targets = getTimelineSequenceDurationDragTargets({
+ draggedNodePathInfo: nodePathInfo,
+ draggedSequenceMediaDurationDragLimits: null,
+ selectedSequenceMediaDurationDragLimits: null,
+ selectedItems: [{type: 'sequence', nodePathInfo}],
+ sequences: [parent, child],
+ overrideIdsToNodePaths,
+ propStatuses: makeDurationPropStatuses([nodePath]),
+ timelineDurationInFrames: 600,
+ });
+ const changes = getTimelineSequenceDurationDragChanges({
+ targets: targets ?? [],
+ deltaFrames: -1000,
+ });
+
+ expect(changes.map(({fieldKey, value}) => ({fieldKey, value}))).toEqual([
+ {
+ fieldKey: 'durationInFrames',
+ value: scenario.expectedDurationInFrames,
+ },
+ ]);
+
+ const resizedTracks = calculateTimeline({
+ sequences: [
+ parent,
+ {
+ ...child,
+ duration: Number(changes[0].value) / child.sequencePlaybackRate,
+ },
+ ],
+ overrideIdsToNodePaths,
+ });
+ expect(
+ resizedTracks.find((track) => track.sequence.id === child.id)?.sequence
+ .duration,
+ ).toBe(1);
+});
+
test('Timeline duration drag clamps to the composition end', () => {
const schema = {} satisfies InteractivitySchema;
const nodePathInfo = makeNodePathInfo(['body', 0], []);