Skip to content

🎥 Make videos programmatically with React

Revert "Wait for package install before rebuilding"

JonnyBurger965dafdbab2d
diff --git a/packages/studio-server/src/preview-server/routes/install-dependency.ts b/packages/studio-server/src/preview-server/routes/install-dependency.ts
index 1cc9fe062d..2997d79c7c 100644
--- a/packages/studio-server/src/preview-server/routes/install-dependency.ts
+++ b/packages/studio-server/src/preview-server/routes/install-dependency.ts
@@ -103,6 +103,7 @@ export const handleInstallPackage = async ({
RenderInternals.Log.info({indent: true, logLevel}, line),
),
);
+ cmd.stdout.on('end', resolve);
cmd.on('close', (code, signal) =>
code === 0
? resolve()
diff --git a/packages/studio-server/src/test/install-dependency.test.ts b/packages/studio-server/src/test/install-dependency.test.ts
index 2c999ade89..c7e0fba416 100644
--- a/packages/studio-server/src/test/install-dependency.test.ts
+++ b/packages/studio-server/src/test/install-dependency.test.ts
@@ -22,7 +22,6 @@ type SpawnCall = {
const mockPackageManagerSpawn = () => {
const calls: SpawnCall[] = [];
- let closedProcesses = 0;
const replacement = (
command: string,
args: readonly string[],
@@ -34,10 +33,7 @@ const mockPackageManagerSpawn = () => {
child.stdout = stdout;
queueMicrotask(() => {
stdout.end();
- setTimeout(() => {
- closedProcesses++;
- child.emit('close', 0, null);
- }, 0);
+ child.emit('close', 0, null);
});
return child;
};
@@ -46,7 +42,7 @@ const mockPackageManagerSpawn = () => {
replacement as typeof childProcess.spawn,
);
- return {calls, getClosedProcesses: () => closedProcesses, spawnSpy};
+ return {calls, spawnSpy};
};
test('uses the matching version for Remotion packages', () => {
@@ -93,11 +89,7 @@ test('always aligns Remotion package versions', () => {
});
test('installs without running dependency lifecycle scripts', async () => {
- const {
- calls: spawnCalls,
- getClosedProcesses,
- spawnSpy,
- } = mockPackageManagerSpawn();
+ const {calls: spawnCalls, spawnSpy} = mockPackageManagerSpawn();
const lockfiles: Record<PackageManager, string> = {
npm: 'package-lock.json',
pnpm: 'pnpm-lock.yaml',
@@ -128,7 +120,6 @@ test('installs without running dependency lifecycle scripts', async () => {
},
logLevel: 'error',
invalidateBundle: () => {
- expect(getClosedProcesses()).toBe(temporaryDirectories.length);
invalidations++;
return Promise.resolve();
},