Skip to content

🎥 Make videos programmatically with React

Reuse interactive HTML testbed for inspector text states

Igor Samokhovets96b1c273607b
diff --git a/packages/example/e2e/mixed-content-inspector.test.mts b/packages/example/e2e/mixed-content-inspector.test.mts
index a3af240c55..14dcf21fcc 100644
--- a/packages/example/e2e/mixed-content-inspector.test.mts
+++ b/packages/example/e2e/mixed-content-inspector.test.mts
@@ -1,45 +1,31 @@
-import fs from 'fs';
import {expect, test} from '@playwright/test';
-import {
- EXPANDED_SIDEBAR_STATE,
- STUDIO_URL,
- visualMode3DFile,
-} from './constants.mts';
+import {EXPANDED_SIDEBAR_STATE, STUDIO_URL} from './constants.mts';
import {startStudio, stopStudio} from './studio-server.mts';
test.use({storageState: EXPANDED_SIDEBAR_STATE});
-test('shows mixed text children as computed in the inspector', async ({
- page,
-}) => {
- const originalSource = fs.readFileSync(visualMode3DFile, 'utf-8');
+test('shows editable and computed text in the inspector', async ({page}) => {
try {
await startStudio();
- fs.writeFileSync(
- visualMode3DFile,
- `
-import React from 'react';
-import {Interactive} from 'remotion';
-export const VisualMode3D = () => (
- <Interactive.Div name="Headline" style={{fontSize: 72, lineHeight: 1.03, letterSpacing: -4, fontWeight: 500}}>
- Ideas, in<br />
- <span style={{fontFamily: 'Georgia, serif', fontStyle: 'italic', color: '#698357'}}>motion.</span>
- </Interactive.Div>
-);
-`,
- );
- await page.goto(`${STUDIO_URL}/visual-mode-3d`);
+ await page.goto(`${STUDIO_URL}/interactive-html-elements`);
await expect(async () => {
await page
- .locator('[data-timeline-marquee-item][title="Headline"]')
+ .locator('[data-timeline-marquee-item][title="Editable text"]')
.click();
- await expect(
- page.getByRole('button', {name: 'Collapse Text', exact: true}),
- ).toBeVisible({timeout: 1_000});
+ await expect(page.getByRole('textbox')).toHaveValue(
+ 'Editable text schema',
+ {
+ timeout: 1_000,
+ },
+ );
}).toPass({timeout: 30_000});
+ await expect(page.getByRole('textbox')).toBeEditable();
+
+ await page
+ .locator('[data-timeline-marquee-item][title="Mixed text (computed)"]')
+ .click();
await expect(page.getByText('computed', {exact: true})).toBeVisible();
} finally {
await stopStudio();
- fs.writeFileSync(visualMode3DFile, originalSource);
}
});
diff --git a/packages/example/src/E2eTestRoot.tsx b/packages/example/src/E2eTestRoot.tsx
index 9a157a71ae..dc7f493795 100644
--- a/packages/example/src/E2eTestRoot.tsx
+++ b/packages/example/src/E2eTestRoot.tsx
@@ -27,6 +27,7 @@ import {VisualControls} from './VisualControls';
import {VisualMode3D} from './VisualMode3D';
import {AffineFrameClock} from './VisualModeTests/AffineFrameClock';
import {FontWeightControls} from './VisualModeTests/FontWeightControls';
+import {InteractiveHtmlElements} from './VisualModeTests/InteractiveComponents';
import {OutlineSelectionCases} from './VisualModeTests/OutlineSelectionCases';
import {SequenceShiftRepro} from './VisualModeTests/SequenceShiftRepro';
@@ -264,6 +265,14 @@ export const E2eTestRoot: React.FC = () => {
fps={30}
durationInFrames={90}
/>
+ <Composition
+ id="interactive-html-elements"
+ component={InteractiveHtmlElements}
+ width={1080}
+ height={1080}
+ fps={30}
+ durationInFrames={90}
+ />
<NewVideoComp />
</>
);
diff --git a/packages/example/src/VisualModeTests/InteractiveComponents.tsx b/packages/example/src/VisualModeTests/InteractiveComponents.tsx
index e88e61297d..44c99759fb 100644
--- a/packages/example/src/VisualModeTests/InteractiveComponents.tsx
+++ b/packages/example/src/VisualModeTests/InteractiveComponents.tsx
@@ -78,6 +78,7 @@ export const InteractiveHtmlElements: React.FC = () => {
Button
</Interactive.Button>
<Interactive.P
+ name="Editable text"
style={{
position: 'absolute',
left: 620,
@@ -116,6 +117,31 @@ export const InteractiveHtmlElements: React.FC = () => {
&lt;Interactive.Section /&gt;
</Interactive.Code>
</Interactive.Section>
+ <Interactive.Div
+ name="Mixed text (computed)"
+ style={{
+ position: 'absolute',
+ left: 110,
+ top: 750,
+ color: '#f8fafc',
+ fontSize: 72,
+ lineHeight: 1.03,
+ letterSpacing: -4,
+ fontWeight: 500,
+ }}
+ >
+ &lt;br /&gt;
+ <br />
+ <span
+ style={{
+ fontFamily: 'Georgia, serif',
+ fontStyle: 'italic',
+ color: '#698357',
+ }}
+ >
+ inside
+ </span>
+ </Interactive.Div>
</AbsoluteFill>
);
};