Skip to content

🎥 Make videos programmatically with React

`@remotion/studio`: Gracefully reject visual control saves and Figma pastes in Browser Studio (#10582)

Jonny Burger999760aa52f4
diff --git a/packages/studio/src/components/VisualControls/VisualControlHandle.tsx b/packages/studio/src/components/VisualControls/VisualControlHandle.tsx
index d43b37e1e8..b6400dbf0d 100644
--- a/packages/studio/src/components/VisualControls/VisualControlHandle.tsx
+++ b/packages/studio/src/components/VisualControls/VisualControlHandle.tsx
@@ -1,6 +1,7 @@
import React, {useCallback, useContext, useEffect, useState} from 'react';
import {NoReactInternals} from 'remotion/no-react';
import {FastRefreshContext} from '../../fast-refresh-context';
+import {getBrowserStudioOperations} from '../../helpers/browser-studio-operations';
import {getVisualControlEditedValue} from '../../visual-controls/get-current-edited-value';
import {
SetVisualControlsContext,
@@ -51,6 +52,17 @@ export const VisualControlHandle: React.FC<{
return;
}
+ // Saving visual control changes goes through
+ // /api/apply-visual-control-change, which Browser Studio does not
+ // support.
+ if (getBrowserStudioOperations()) {
+ showNotification(
+ 'Saving visual control changes is not supported in Browser Studio',
+ 4000,
+ );
+ return;
+ }
+
if (originalFileName.type !== 'loaded') {
throw new Error('Original file name is not loaded');
}
diff --git a/packages/studio/src/components/import-assets.ts b/packages/studio/src/components/import-assets.ts
index 7bf0764d22..a9b0fb507e 100644
--- a/packages/studio/src/components/import-assets.ts
+++ b/packages/studio/src/components/import-assets.ts
@@ -937,6 +937,16 @@ export const importFigmaClipboard = async ({
dropPosition: InsertElementDropPosition | null;
html: string;
}) => {
+ // Figma clipboard conversion requires the SVGR-based pipeline in
+ // @remotion/studio-server, which Browser Studio does not support.
+ if (getBrowserStudioOperations()) {
+ showNotification(
+ 'Importing Figma clipboard data is not supported in Browser Studio',
+ 4000,
+ );
+ return;
+ }
+
try {
const converted = await callApi('/api/convert-figma-clipboard-to-svg', {
html,