Skip to content

🎥 Make videos programmatically with React

Skip frame subscriptions for static Studio effect values

Jonny Burgera4e87412b810
diff --git a/packages/studio/src/components/Timeline/TimelineEffectPropItem.tsx b/packages/studio/src/components/Timeline/TimelineEffectPropItem.tsx
index ec55f24a7f..9df502aa6a 100644
--- a/packages/studio/src/components/Timeline/TimelineEffectPropItem.tsx
+++ b/packages/studio/src/components/Timeline/TimelineEffectPropItem.tsx
@@ -404,6 +404,7 @@ const TimelineEffectPropValueAtCurrentFrame: React.FC<{
readonly keyframePlaybackRate: number;
readonly propStatus: CanUpdateSequencePropStatus | null;
readonly runtimeValueStore: RuntimeValueStore | null;
+ readonly subscribeToTimelinePosition: boolean;
}> = ({
field,
nodePath,
@@ -412,8 +413,12 @@ const TimelineEffectPropValueAtCurrentFrame: React.FC<{
keyframePlaybackRate,
propStatus,
runtimeValueStore,
+ subscribeToTimelinePosition,
}) => {
- const timelinePosition = Internals.Timeline.useTimelinePosition();
+ const timelinePosition =
+ Internals.Timeline.useTimelinePositionWithOptionalSubscription(
+ subscribeToTimelinePosition,
+ );
return (
<TimelineEffectPropValue
@@ -699,6 +704,10 @@ export const TimelineEffectPropItem: React.FC<{
keyframePlaybackRate={keyframePlaybackRate}
propStatus={propStatus}
runtimeValueStore={runtimeValueStore}
+ subscribeToTimelinePosition={
+ propStatus?.status === 'keyframed' ||
+ dragOverrideValue?.type === 'keyframed'
+ }
/>
</TimelineFieldRowContent>
</TimelineRowChrome>