Skip to content

🎥 Make videos programmatically with React

Remove unrelated FFmpeg CI workaround

Jonny Burgera53917839cd3
diff --git a/packages/renderer/src/prespawn-ffmpeg.ts b/packages/renderer/src/prespawn-ffmpeg.ts
index ae9b233469..3316763e10 100644
--- a/packages/renderer/src/prespawn-ffmpeg.ts
+++ b/packages/renderer/src/prespawn-ffmpeg.ts
@@ -235,8 +235,8 @@ export const prespawnFfmpeg = (options: PreStitcherOptions) => {
['-f', 'remotionshm'],
['-video_size', `${options.width}x${options.height}`],
['-framerate', fpsAsFraction(options.fps)],
- ['-control_fd', '0'],
- ['-ack_fd', '1'],
+ ['-control_fd', '3'],
+ ['-ack_fd', '4'],
options.remotionSharedMemoryPoolDirectory === null
? null
: ['-pool_dir', options.remotionSharedMemoryPoolDirectory],
@@ -291,19 +291,14 @@ export const prespawnFfmpeg = (options: PreStitcherOptions) => {
cancelSignal: options.signal,
options:
options.inputMode === 'remotion-shared-memory'
- ? {
- // Bun 1.3.3 can double-close extra stdio FDs. Use stdin/stdout
- // for the protocol, and let the bridge consume ACKs without buffering.
- stdio: 'pipe',
- buffer: false,
- }
+ ? {stdio: ['ignore', 'pipe', 'pipe', 'pipe', 'pipe']}
: undefined,
});
const remotionSharedMemory =
options.inputMode === 'remotion-shared-memory'
? createRemotionSharedMemoryFfmpegBridge({
- control: task.stdin as Writable,
- acknowledgements: task.stdout as Readable,
+ control: task.stdio[3] as Writable,
+ acknowledgements: task.stdio[4] as Readable,
})
: null;