Skip to content

🎥 Make videos programmatically with React

Fix failed Element dependency installs (#11541)

Igor Samokhovetsa8d5ee301ae1
diff --git a/packages/studio-server/src/preview-server/routes/install-dependency.ts b/packages/studio-server/src/preview-server/routes/install-dependency.ts
index 7d99a52bae..bf22f958a9 100644
--- a/packages/studio-server/src/preview-server/routes/install-dependency.ts
+++ b/packages/studio-server/src/preview-server/routes/install-dependency.ts
@@ -107,6 +107,7 @@ export const handleInstallPackage = async ({
YARN_ENABLE_SCRIPTS: 'false',
},
});
+ let stderr = '';
cmd.on('error', reject);
cmd.stdout.on('data', (d: Buffer) =>
d
@@ -117,16 +118,24 @@ export const handleInstallPackage = async ({
RenderInternals.Log.info({indent: true, logLevel}, line),
),
);
- cmd.stdout.on('end', resolve);
- cmd.on('close', (code, signal) =>
- code === 0
- ? resolve()
- : reject(
- new Error(
- `Command exited with code ${code} and signal ${signal}`,
- ),
- ),
- );
+ cmd.stderr.on('data', (data: Buffer) => {
+ stderr += data.toString();
+ });
+ cmd.on('close', (code, signal) => {
+ if (code === 0) {
+ resolve();
+ return;
+ }
+
+ const packageManagerError = stderr.trim();
+ reject(
+ new Error(
+ packageManagerError.length > 0
+ ? `Package installation failed:\n${packageManagerError}`
+ : `Package installation failed: Command exited with code ${code} and signal ${signal}`,
+ ),
+ );
+ });
});
await invalidateBundle();
RenderInternals.Log.info(
diff --git a/packages/studio-server/src/test/install-dependency.test.ts b/packages/studio-server/src/test/install-dependency.test.ts
index ecd2c74efb..9b99de97ee 100644
--- a/packages/studio-server/src/test/install-dependency.test.ts
+++ b/packages/studio-server/src/test/install-dependency.test.ts
@@ -30,9 +30,12 @@ const mockPackageManagerSpawn = () => {
calls.push({command, args, options});
const child = new EventEmitter() as ReturnType<typeof childProcess.spawn>;
const stdout = new PassThrough();
+ const stderr = new PassThrough();
child.stdout = stdout;
+ child.stderr = stderr;
queueMicrotask(() => {
stdout.end();
+ stderr.end();
child.emit('close', 0, null);
});
return child;
@@ -88,6 +91,63 @@ test('always aligns Remotion package versions', () => {
).toBe(`@remotion/effects@${VERSION}`);
});
+test('propagates package manager stderr when installation fails', async () => {
+ const remotionRoot = await mkdtemp(
+ path.join(tmpdir(), 'remotion-install-failure-'),
+ );
+ await writeFile(path.join(remotionRoot, 'package-lock.json'), '');
+ const spawnSpy = spyOn(childProcess, 'spawn').mockImplementation((() => {
+ const child = new EventEmitter() as ReturnType<typeof childProcess.spawn>;
+ const stdout = new PassThrough();
+ const stderr = new PassThrough();
+ child.stdout = stdout;
+ child.stderr = stderr;
+ queueMicrotask(() => {
+ stderr.write(
+ 'npm error code E401\nnpm error Unable to authenticate, your authentication token seems to be invalid.',
+ );
+ stdout.end();
+ stderr.end();
+ setTimeout(() => child.emit('close', 1, null), 0);
+ });
+ return child;
+ }) as typeof childProcess.spawn);
+ let invalidations = 0;
+
+ try {
+ await expect(
+ handleInstallPackage({
+ binariesDirectory: null,
+ configFile: null,
+ entryPoint: '',
+ getDefaultCodingAgent: () => null,
+ getDefaultEditor: () => null,
+ input: {
+ dependencies: [{name: '@private/package', version: null}],
+ },
+ invalidateBundle: () => {
+ invalidations++;
+ return Promise.resolve();
+ },
+ logLevel: 'error',
+ methods: {
+ addJob: () => undefined,
+ cancelJob: () => undefined,
+ removeJob: () => undefined,
+ },
+ publicDir: remotionRoot,
+ remotionRoot,
+ request: {} as IncomingMessage,
+ response: {} as ServerResponse,
+ }),
+ ).rejects.toThrow(/E401[\s\S]*Unable to authenticate/);
+ expect(invalidations).toBe(0);
+ } finally {
+ spawnSpy.mockRestore();
+ await rm(remotionRoot, {force: true, recursive: true});
+ }
+});
+
test('installs without running dependency lifecycle scripts', async () => {
const {calls: spawnCalls, spawnSpy} = mockPackageManagerSpawn();
const versionSpy = spyOn(childProcess, 'execFileSync').mockReturnValue('');