Skip to content

🎥 Make videos programmatically with React

`@remotion/studio`: Keep unchanged source prop statuses after saves

Cursor Agentad4a5799ceec
diff --git a/packages/studio/src/components/Timeline/SequencePropsObserver.tsx b/packages/studio/src/components/Timeline/SequencePropsObserver.tsx
index bd52076f15..7e214f94ec 100644
--- a/packages/studio/src/components/Timeline/SequencePropsObserver.tsx
+++ b/packages/studio/src/components/Timeline/SequencePropsObserver.tsx
@@ -13,6 +13,7 @@ import {FastRefreshContext} from '../../fast-refresh-context';
import {StudioServerConnectionCtx} from '../../helpers/client-id';
import {takePendingSequenceNodePathMutations} from '../../helpers/sequence-node-path-mutations';
import {ExpandedTracksSetterContext} from '../ExpandedTracksProvider';
+import {deepEqual} from '../RenderModal/SchemaEditor/deep-equal';
import {refreshSequencePropsSubscription} from './sequence-props-subscription-store';
import {useTimelineSelection} from './TimelineSelection';
@@ -65,7 +66,11 @@ export const SequencePropsObserver = () => {
return;
}
- setPropStatuses(event.nodePath, () => event.result);
+ // Every save re-sends all subscribed nodes of the file. Keep unchanged
+ // statuses so their consumers do not rerender.
+ setPropStatuses(event.nodePath, (prev) =>
+ deepEqual(prev, event.result) ? prev : event.result,
+ );
};
const unsubscribe = subscribeToEvent('sequence-props-updated', handleEvent);
diff --git a/packages/studio/src/components/Timeline/use-sequence-props-subscription.ts b/packages/studio/src/components/Timeline/use-sequence-props-subscription.ts
index 7f987336a4..59adb5e2dd 100644
--- a/packages/studio/src/components/Timeline/use-sequence-props-subscription.ts
+++ b/packages/studio/src/components/Timeline/use-sequence-props-subscription.ts
@@ -12,6 +12,7 @@ import {Internals} from 'remotion';
import type {OriginalPosition} from '../../error-overlay/react-overlay/utils/get-source-map';
import {StudioServerConnectionCtx} from '../../helpers/client-id';
import {ExpandedTracksSetterContext} from '../ExpandedTracksProvider';
+import {deepEqual} from '../RenderModal/SchemaEditor/deep-equal';
import {
acquireSequencePropsSubscription,
subscribeToSequencePropsRefresh,
@@ -121,7 +122,10 @@ export const useSequencePropsSubscription = ({
return;
}
- setPropStatuses(result.nodePath, () => result.status);
+ // Edits that shift source lines resubscribe every following node.
+ setPropStatuses(result.nodePath, (prev) =>
+ deepEqual(prev, result.status) ? prev : result.status,
+ );
},
applyEach: (result) => {
if (!result.success) {