Skip to content

🎥 Make videos programmatically with React

Require nullable duration-dependent keyframe metadata

JonnyBurgerb901c679adca
diff --git a/packages/codemods/src/get-node-props.ts b/packages/codemods/src/get-node-props.ts
index 319b7a8ef8..37ed51e0d9 100644
--- a/packages/codemods/src/get-node-props.ts
+++ b/packages/codemods/src/get-node-props.ts
@@ -23,7 +23,7 @@ export type GetNodePropsOptions = {
export type NodeProps = Pick<
CanUpdateSequencePropsResponseTrue,
- 'canUpdate' | 'props' | 'effects'
+ 'canUpdate' | 'props' | 'effects' | 'durationDependentKeyframes'
>;
export const getNodeProps = ({
diff --git a/packages/codemods/src/sequence-props.ts b/packages/codemods/src/sequence-props.ts
index 429c4465a8..04e9c2d07d 100644
--- a/packages/codemods/src/sequence-props.ts
+++ b/packages/codemods/src/sequence-props.ts
@@ -2367,7 +2367,7 @@ const computeSequencePropsStatusFromAstAndIdentifiers = ({
return {
canUpdate: true as const,
- ...(durationDependentKeyframes ? {durationDependentKeyframes} : {}),
+ durationDependentKeyframes,
props: Object.fromEntries(
Object.entries(filteredProps).map(([key, status]) => [
key,
diff --git a/packages/core/src/SequenceManager.tsx b/packages/core/src/SequenceManager.tsx
index 28e8963594..ee55506d7a 100644
--- a/packages/core/src/SequenceManager.tsx
+++ b/packages/core/src/SequenceManager.tsx
@@ -198,10 +198,10 @@ export type CanUpdateSequencePropsResponseTrue<Numeric = SourceNumericValue> = {
props: Record<string, CanUpdateSequencePropStatus<Numeric>>;
effects: CanUpdateEffectPropsResponse<Numeric>[];
/** Source ranges also include interpolations outside the editable schema. */
- durationDependentKeyframes?: {
+ durationDependentKeyframes: {
readonly scope: SequenceNodePath;
readonly inputRanges: readonly (readonly SourceNumericValue[] | null)[];
- };
+ } | null;
};
export type CanUpdateSequencePropsResponseFalse = {
diff --git a/packages/core/src/test/sequence-register-once.test.tsx b/packages/core/src/test/sequence-register-once.test.tsx
index 79e4ab63e2..f286cfd152 100644
--- a/packages/core/src/test/sequence-register-once.test.tsx
+++ b/packages/core/src/test/sequence-register-once.test.tsx
@@ -761,6 +761,7 @@ test('Series.Sequence timing overrides cascade to later sequences', async () =>
},
propStatuses: {
[subscriptionKey]: {
+ durationDependentKeyframes: null,
canUpdate: true as const,
props: {
durationInFrames: {
@@ -1686,6 +1687,7 @@ test('Imperative sequence refs update without rerendering ref-only consumers', a
React.useEffect(() => {
registerSequence({id: 'imperative-sequence'} as TSequence);
setPropStatuses(nodePath, () => ({
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
diff --git a/packages/studio-shared/src/test/optimistic-add-keyframe.test.ts b/packages/studio-shared/src/test/optimistic-add-keyframe.test.ts
index c23b97163b..3d8867935e 100644
--- a/packages/studio-shared/src/test/optimistic-add-keyframe.test.ts
+++ b/packages/studio-shared/src/test/optimistic-add-keyframe.test.ts
@@ -10,6 +10,7 @@ import {
test('optimisticAddSequenceKeyframe converts a static prop to a single keyframe', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -46,6 +47,7 @@ test('optimisticAddSequenceKeyframe converts a static prop to a single keyframe'
test('optimisticAddSequenceKeyframe adds a missing prop before keyframing it', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
@@ -82,6 +84,7 @@ test('optimisticAddSequenceKeyframe adds a missing prop before keyframing it', (
test('optimisticAddSequenceKeyframe uses interpolate for translate fields', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.translate': {
@@ -124,6 +127,7 @@ test('optimisticAddSequenceKeyframe uses interpolate for translate fields', () =
test('optimisticAddSequenceKeyframe uses interpolate for rotation-css fields', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.rotate': {
@@ -166,6 +170,7 @@ test('optimisticAddSequenceKeyframe uses interpolate for rotation-css fields', (
test('optimisticAddSequenceKeyframe ignores non-keyframable fields', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
playbackRate: {
@@ -199,6 +204,7 @@ test('optimisticAddSequenceKeyframe ignores non-keyframable fields', () => {
test('optimisticAddSequenceKeyframe ignores enum fields', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
layout: {
@@ -245,6 +251,7 @@ test('optimisticAddSequenceKeyframe uses hold easing for enabled enum fields', (
},
} satisfies InteractivitySchema;
const initial: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
cursor: {
@@ -291,6 +298,7 @@ test('optimisticAddSequenceKeyframe uses hold easing for enabled enum fields', (
test('optimisticAddSequenceKeyframe appends a keyframe to an existing interpolation', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
@@ -337,6 +345,7 @@ test('optimisticAddSequenceKeyframe appends a keyframe to an existing interpolat
test('optimisticAddSequenceKeyframe duplicates the easing for the split segment', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
@@ -386,6 +395,7 @@ test('optimisticAddSequenceKeyframe duplicates the easing for the split segment'
test('optimisticAddSequenceKeyframe uses linear easing outside the keyframe range', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
@@ -430,6 +440,7 @@ test('optimisticAddSequenceKeyframe uses linear easing outside the keyframe rang
test('optimisticAddSequenceKeyframe updates an existing keyframe at the same frame', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
@@ -475,6 +486,7 @@ test('optimisticAddSequenceKeyframe updates an existing keyframe at the same fra
test('optimisticAddEffectKeyframe appends a keyframe on the target effect', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -530,6 +542,7 @@ test('optimisticAddEffectKeyframe appends a keyframe on the target effect', () =
test('optimisticAddEffectKeyframe converts a static prop to a single keyframe', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -579,6 +592,7 @@ test('optimisticAddEffectKeyframe converts a static prop to a single keyframe',
test('optimisticAddEffectKeyframe adds a missing prop before keyframing it', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
diff --git a/packages/studio-shared/src/test/optimistic-delete-keyframe.test.ts b/packages/studio-shared/src/test/optimistic-delete-keyframe.test.ts
index aa9a960936..d34dec3743 100644
--- a/packages/studio-shared/src/test/optimistic-delete-keyframe.test.ts
+++ b/packages/studio-shared/src/test/optimistic-delete-keyframe.test.ts
@@ -9,6 +9,7 @@ import {
test('optimisticDeleteSequenceKeyframe removes the matching keyframe and an easing segment', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -54,6 +55,7 @@ test('optimisticDeleteSequenceKeyframe removes the matching keyframe and an easi
test('optimisticDeleteSequenceKeyframe preserves the left segment easing when removing a middle keyframe', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -103,6 +105,7 @@ test('optimisticDeleteSequenceKeyframe preserves the left segment easing when re
test('optimisticDeleteSequenceKeyframe converts the last keyframe to a static value', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
width: {
@@ -139,6 +142,7 @@ test('optimisticDeleteSequenceKeyframe converts the last keyframe to a static va
test('optimisticDeleteSequenceKeyframe is a no-op when no keyframe matches', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -185,6 +189,7 @@ test('optimisticDeleteSequenceKeyframe is a no-op when sequence is not updateabl
test('optimisticDeleteSequenceKeyframes deletes multiple keyframes in one pass', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
width: {
@@ -229,6 +234,7 @@ test('optimisticDeleteSequenceKeyframes deletes multiple keyframes in one pass',
test('optimisticDeleteSequenceKeyframes uses the playhead value when deleting all keyframes', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
width: {
@@ -274,6 +280,7 @@ test('optimisticDeleteSequenceKeyframes uses the playhead value when deleting al
test('optimisticDeleteEffectKeyframe removes the matching keyframe on the target effect', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -329,6 +336,7 @@ test('optimisticDeleteEffectKeyframe removes the matching keyframe on the target
test('optimisticDeleteEffectKeyframe converts the last keyframe on the target effect to a static value', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -379,6 +387,7 @@ test('optimisticDeleteEffectKeyframe converts the last keyframe on the target ef
test('optimisticDeleteEffectKeyframe is a no-op when effect index not found', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
@@ -397,6 +406,7 @@ test('optimisticDeleteEffectKeyframe is a no-op when effect index not found', ()
test('optimisticDeleteEffectKeyframes deletes multiple keyframes in one pass', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -454,6 +464,7 @@ test('optimisticDeleteEffectKeyframes deletes multiple keyframes in one pass', (
test('optimisticDeleteEffectKeyframes uses the playhead value when deleting all keyframes', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
diff --git a/packages/studio-shared/src/test/optimistic-move-keyframe.test.ts b/packages/studio-shared/src/test/optimistic-move-keyframe.test.ts
index 153b8cf98b..df5c6393f7 100644
--- a/packages/studio-shared/src/test/optimistic-move-keyframe.test.ts
+++ b/packages/studio-shared/src/test/optimistic-move-keyframe.test.ts
@@ -7,6 +7,7 @@ import {
} from '../optimistic-move-keyframe';
const previous: CanUpdateSequencePropsResponse<number> = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
diff --git a/packages/studio-shared/src/test/optimistic-update-for-effect-prop-statuses.test.ts b/packages/studio-shared/src/test/optimistic-update-for-effect-prop-statuses.test.ts
index 477cd92430..4a945c7c24 100644
--- a/packages/studio-shared/src/test/optimistic-update-for-effect-prop-statuses.test.ts
+++ b/packages/studio-shared/src/test/optimistic-update-for-effect-prop-statuses.test.ts
@@ -4,6 +4,7 @@ import {optimisticUpdateForEffectPropStatuses} from '../optimistic-update-for-ef
test('optimisticUpdateForEffectPropStatuses updates the matching effect prop', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -76,6 +77,7 @@ test('optimisticUpdateForEffectPropStatuses is a no-op when sequence is not upda
test('optimisticUpdateForEffectPropStatuses is a no-op when effect index not found', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
@@ -94,6 +96,7 @@ test('optimisticUpdateForEffectPropStatuses is a no-op when effect index not fou
test('optimisticUpdateForEffectPropStatuses applies when effect props are unset (zero-arg style)', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
diff --git a/packages/studio-shared/src/test/optimistic-update-for-prop-statuses.test.ts b/packages/studio-shared/src/test/optimistic-update-for-prop-statuses.test.ts
index 481df660f8..c4d953e89e 100644
--- a/packages/studio-shared/src/test/optimistic-update-for-prop-statuses.test.ts
+++ b/packages/studio-shared/src/test/optimistic-update-for-prop-statuses.test.ts
@@ -5,6 +5,7 @@ import {optimisticUpdateForPropStatuses} from '../optimistic-update-for-prop-sta
test('optimisticUpdateForPropStatuses should return the correct response', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -23,6 +24,7 @@ test('optimisticUpdateForPropStatuses should return the correct response', () =>
});
expect(updated).toEqual({
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -41,6 +43,7 @@ test('optimisticUpdateForPropStatuses should return the correct response', () =>
schema: NoReactInternals.sequenceSchema,
});
expect(layout).toEqual({
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
layout: {
@@ -55,6 +58,7 @@ test('optimisticUpdateForPropStatuses should return the correct response', () =>
test('optimisticUpdateForPropStatuses should use undefined for removed default values', () => {
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
name: {
@@ -75,6 +79,7 @@ test('optimisticUpdateForPropStatuses should use undefined for removed default v
});
expect(updated).toEqual({
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
name: {
diff --git a/packages/studio-shared/src/test/optimistic-update-keyframe-settings.test.ts b/packages/studio-shared/src/test/optimistic-update-keyframe-settings.test.ts
index 890ab88dfe..65e2f4d75c 100644
--- a/packages/studio-shared/src/test/optimistic-update-keyframe-settings.test.ts
+++ b/packages/studio-shared/src/test/optimistic-update-keyframe-settings.test.ts
@@ -6,6 +6,7 @@ import {
} from '../optimistic-update-keyframe-settings';
const previous: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
scale: {
diff --git a/packages/studio-shared/src/test/schema-field-info.test.ts b/packages/studio-shared/src/test/schema-field-info.test.ts
index f80c424c46..b15b85377d 100644
--- a/packages/studio-shared/src/test/schema-field-info.test.ts
+++ b/packages/studio-shared/src/test/schema-field-info.test.ts
@@ -117,6 +117,7 @@ const getBorderRadiusFields = (
getDragOverrides: () => ({}),
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props,
effects: [],
@@ -132,6 +133,7 @@ test('getEffectFieldsToShow uses the active enum variant', () => {
nodePath,
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -199,6 +201,7 @@ test('getEffectFieldsToShow sizes array fields from the current value', () => {
nodePath,
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
diff --git a/packages/studio/src/components/Timeline/get-keyframe-duration-limits.ts b/packages/studio/src/components/Timeline/get-keyframe-duration-limits.ts
index 671b0e857a..bbe3a7e558 100644
--- a/packages/studio/src/components/Timeline/get-keyframe-duration-limits.ts
+++ b/packages/studio/src/components/Timeline/get-keyframe-duration-limits.ts
@@ -97,7 +97,7 @@ export const getKeyframeDurationLimits = ({
const constraints = status?.canUpdate
? status.durationDependentKeyframes
: null;
- if (!constraints) continue;
+ if (constraints === null) continue;
// A hook in the render function reads the context outside its outermost
// JSX element. Nested JSX sequences do not change that hook's clock.
diff --git a/packages/studio/src/test/border-radius-representation.test.ts b/packages/studio/src/test/border-radius-representation.test.ts
index b5759e1501..8bfa9485f6 100644
--- a/packages/studio/src/test/border-radius-representation.test.ts
+++ b/packages/studio/src/test/border-radius-representation.test.ts
@@ -35,6 +35,7 @@ test('a static shorthand can be converted to individual corners', () => {
]);
const initial: CanUpdateSequencePropsResponse = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
[BORDER_RADIUS_SHORTHAND_KEY]: {
diff --git a/packages/studio/src/test/browser-studio-sequence-props.test.ts b/packages/studio/src/test/browser-studio-sequence-props.test.ts
index 475505c069..0d1ae5ee2f 100644
--- a/packages/studio/src/test/browser-studio-sequence-props.test.ts
+++ b/packages/studio/src/test/browser-studio-sequence-props.test.ts
@@ -60,6 +60,7 @@ test('routes sequence prop operations through Browser Studio', async () => {
success: true,
nodePath,
status: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: {
@@ -161,6 +162,7 @@ test('batches server sequence prop subscriptions into one request', async () =>
},
},
status: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: {
diff --git a/packages/studio/src/test/split-selected-timeline-item.test.ts b/packages/studio/src/test/split-selected-timeline-item.test.ts
index 7a284a9f42..39acce6973 100644
--- a/packages/studio/src/test/split-selected-timeline-item.test.ts
+++ b/packages/studio/src/test/split-selected-timeline-item.test.ts
@@ -217,6 +217,7 @@ test('splitSelectedTimelineItems splits the selected sequence at the playhead',
[Internals.makeSequencePropsSubscriptionKey(
nodePathInfo.sequenceSubscriptionKey,
)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: staticNumber(10),
diff --git a/packages/studio/src/test/timeline-keyframes.test.ts b/packages/studio/src/test/timeline-keyframes.test.ts
index 8d4f80a362..8a2f07b17d 100644
--- a/packages/studio/src/test/timeline-keyframes.test.ts
+++ b/packages/studio/src/test/timeline-keyframes.test.ts
@@ -165,6 +165,7 @@ const makePropStatuses = (
nodePath: SequencePropsSubscriptionKey,
): PropStatuses => ({
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.scale': makeKeyframedStatus(),
@@ -319,6 +320,7 @@ test('keyframes retain their source frames across nested rates and trimmed clock
};
const propStatuses: PropStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {'style.scale': status},
effects: [],
diff --git a/packages/studio/src/test/timeline-selection.test.ts b/packages/studio/src/test/timeline-selection.test.ts
index c6060ce09e..ce1d634c3b 100644
--- a/packages/studio/src/test/timeline-selection.test.ts
+++ b/packages/studio/src/test/timeline-selection.test.ts
@@ -302,6 +302,7 @@ const makeDurationPropStatuses = (
const propStatuses: PropStatuses = {};
for (const nodePath of nodePaths) {
propStatuses[Internals.makeSequencePropsSubscriptionKey(nodePath)] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -323,6 +324,7 @@ const makeFromPropStatuses = (
const propStatuses: PropStatuses = {};
for (const nodePath of nodePaths) {
propStatuses[Internals.makeSequencePropsSubscriptionKey(nodePath)] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: {
@@ -347,6 +349,7 @@ const makeLeftEdgePropStatuses = (
const propStatuses: PropStatuses = {};
for (const [index, nodePath] of nodePaths.entries()) {
propStatuses[Internals.makeSequencePropsSubscriptionKey(nodePath)] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
...(includeTimelineRange
@@ -767,6 +770,7 @@ test('copying a keyframed effect creates a structured snapshot', () => {
const nodePath = effectNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -866,6 +870,7 @@ test('copying a selected effect prop creates an effect prop payload', () => {
const nodePath = effectPropNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -934,6 +939,7 @@ test('copying selected keyframes preserves their frame deltas', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -996,6 +1002,7 @@ test('pasting keyframes onto a sequence targets the copied property', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.translate': {
@@ -1056,6 +1063,7 @@ test('copies a keyframed sequence prop between components with matching schemas'
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(sourceNodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.rotate': {
@@ -1075,6 +1083,7 @@ test('copies a keyframed sequence prop between components with matching schemas'
effects: [],
},
[Internals.makeSequencePropsSubscriptionKey(targetNodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.rotate': {
@@ -1145,6 +1154,7 @@ test('copying selected keyframes requires one property', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -1193,6 +1203,7 @@ test('pasting keyframes targets one selected property at the playhead', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -1253,6 +1264,7 @@ test('pasting keyframes replaces the destination range and preserves easing', ()
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -1329,6 +1341,7 @@ test('pasting a keyframe rejects an incompatible property', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
background: {
@@ -1385,6 +1398,7 @@ test('copying a selected sequence easing creates an easing payload', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -1440,6 +1454,7 @@ test('copying a selected effect easing creates an easing payload', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -1507,6 +1522,7 @@ test('pasting an effect prop targets a matching selected effect', () => {
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -1600,11 +1616,13 @@ test('pasting an effect prop targets multiple matching selected effects', () =>
} as const;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(firstNodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [effectStatus],
},
[Internals.makeSequencePropsSubscriptionKey(secondNodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [effectStatus],
@@ -1694,6 +1712,7 @@ test('pasting an effect prop requires the same effect type and prop key', () =>
} satisfies InteractivitySchema;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -2119,6 +2138,7 @@ test('Timeline edge drags edit durationInFrames in the child clock', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses: PropStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -2401,6 +2421,7 @@ test('Timeline duration drag trims audio and video without an explicit duration'
},
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -2461,6 +2482,7 @@ test('Timeline duration drag waits for an effective implicit media duration', ()
overrideIdsToNodePaths: {override: nodePath},
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -2626,6 +2648,7 @@ test('Timeline duration drag is blocked if one selected sequence cannot update d
secondNodePathInfo.sequenceSubscriptionKey,
)
] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
@@ -2679,6 +2702,7 @@ test('Timeline duration drag is blocked if one selected sequence duration is key
secondNodePathInfo.sequenceSubscriptionKey,
)
] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -2941,6 +2965,7 @@ test('TransitionSeries.Sequence self-trim changes its duration and trimBefore',
},
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(subscriptionKey)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -2999,6 +3024,7 @@ test('Series.Sequence self-trim changes its duration and trimBefore', () => {
},
propStatuses: {
[Internals.makeSequencePropsSubscriptionKey(subscriptionKey)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
durationInFrames: {
@@ -3366,6 +3392,7 @@ test('Timeline from drag moves all owned sequence keyframes by the same delta',
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = makeFromPropStatuses([nodePath]);
propStatuses[Internals.makeSequencePropsSubscriptionKey(nodePath)] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: {
@@ -3460,6 +3487,7 @@ test('Timeline from drag moves only descendant keyframes tied to an outer frame
propStatuses[
Internals.makeSequencePropsSubscriptionKey(outerFrameDescendantNodePath)
] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
color: {
@@ -3472,6 +3500,7 @@ test('Timeline from drag moves only descendant keyframes tied to an outer frame
propStatuses[
Internals.makeSequencePropsSubscriptionKey(localFrameDescendantNodePath)
] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
color: {
@@ -3550,6 +3579,7 @@ test('Timeline from drag moves owned effect keyframes by the same delta', () =>
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = makeFromPropStatuses([nodePath]);
propStatuses[Internals.makeSequencePropsSubscriptionKey(nodePath)] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
from: {
@@ -3745,6 +3775,7 @@ test('Timeline from drag is blocked if one selected sequence cannot update from'
secondNodePathInfo.sequenceSubscriptionKey,
)
] = {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [],
@@ -6184,6 +6215,7 @@ const getUvHandlesForSelectedEffectChild = (selectedFieldKey: string) => {
} as const satisfies InteractivitySchema;
const propStatuses: PropStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -6376,6 +6408,7 @@ test('UV handles are requested for keyframed selected effect props', () => {
} as const satisfies InteractivitySchema;
const propStatuses: PropStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -6616,6 +6649,7 @@ test('Derived selectable timeline items follow expanded timeline order', () => {
const nodePath = sequenceNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -6753,6 +6787,7 @@ test('Backspace reset targets multiple selected sequence props', () => {
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -6806,6 +6841,7 @@ test('Backspace reset targets stroke with the SVG default', () => {
const nodePath = strokeNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
stroke: {
@@ -6852,6 +6888,7 @@ test('Backspace reset targets border radius with the CSS default', () => {
const nodePath = radiusNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.borderRadius': {
@@ -6903,6 +6940,7 @@ test('Backspace reset targets selected keyframed sequence props', () => {
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -6960,6 +6998,7 @@ test('Backspace reset skips selected computed sequence props with defaults', ()
const nodePath = scaleNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.scale': {
@@ -6994,6 +7033,7 @@ test('Backspace reset targets flattened built-in keyframed sequence style props'
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
'style.opacity': {
@@ -7053,6 +7093,7 @@ test('Backspace reset skips keyframed sequence props without defaults', () => {
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -7901,6 +7942,7 @@ test('Backspace reset targets selected effect props', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -7978,6 +8020,7 @@ test('Backspace reset targets active enum variant effect props', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -8048,6 +8091,7 @@ test('Backspace reset targets selected static blur radius with default', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -8113,6 +8157,7 @@ test('Backspace reset targets selected keyframed effect props', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -8186,6 +8231,7 @@ test('Backspace reset skips keyframed effect props without defaults', () => {
const nodePath = nodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {},
effects: [
@@ -8254,6 +8300,7 @@ test('Backspace reset targets mixed selected sequence and effect props', () => {
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
@@ -8582,6 +8629,7 @@ test('Deleting all selected keyframes preserves the value at the playhead', asyn
const nodePath = opacityNodePathInfo.sequenceSubscriptionKey;
const propStatuses = {
[Internals.makeSequencePropsSubscriptionKey(nodePath)]: {
+ durationDependentKeyframes: null,
canUpdate: true,
props: {
opacity: {
diff --git a/packages/transitions/src/test/transition-series-stack.test.tsx b/packages/transitions/src/test/transition-series-stack.test.tsx
index 563f17ba0a..e1c3f28048 100644
--- a/packages/transitions/src/test/transition-series-stack.test.tsx
+++ b/packages/transitions/src/test/transition-series-stack.test.tsx
@@ -430,6 +430,7 @@ test('TransitionSeries.Sequence timing overrides cascade to later sequences', as
},
propStatuses: {
[subscriptionKey]: {
+ durationDependentKeyframes: null,
canUpdate: true as const,
props: {
durationInFrames: {